Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 655052 - app-text/texlive-core-2017-r4 stable request
Summary: app-text/texlive-core-2017-r4 stable request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Stabilization (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: TeX project
URL:
Whiteboard: Was: app-text/texlive-core-2017-r3 st...
Keywords:
: 656238 (view as bug list)
Depends on:
Blocks: CVE-2018-6942 freetype-config 659828
  Show dependency tree
 
Reported: 2018-05-06 08:39 UTC by Maxim Koltsov (RETIRED)
Modified: 2018-10-12 12:41 UTC (History)
20 users (show)

See Also:
Package list:
app-text/texlive-core-2017-r4
Runtime testing required: ---
stable-bot: sanity-check+


Attachments
Build log (build.log,24.44 KB, text/x-log)
2018-05-06 08:39 UTC, Maxim Koltsov (RETIRED)
no flags Details
texlive-freetype2.patch (texlive-freetype2.patch,1.13 KB, patch)
2018-05-10 02:18 UTC, maurerpe
no flags Details | Diff
texlive_core-2017-r4.ebuild (texlive-core-2017-r101.ebuild,11.35 KB, text/plain)
2018-05-10 02:20 UTC, maurerpe
no flags Details
texlive_core-2017-r3.ebuild.patch (texlive-core-2017-r3.ebuild.patch,652 bytes, patch)
2018-05-10 02:21 UTC, maurerpe
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maxim Koltsov (RETIRED) gentoo-dev 2018-05-06 08:39:17 UTC
Created attachment 530166 [details]
Build log

checking for freetype-config... no
configure: error: did not find freetype-config required for system freetype2 library
Comment 1 maurerpe 2018-05-10 02:16:54 UTC
The solution is to update m4/kpse-freetype2-flags.m4 to try pkg-config first and fall back to freetype-config if that fails.  For the changes to take effect you must run the provided ./reautoconf script (which takes forever).

patches attached
Comment 2 maurerpe 2018-05-10 02:18:13 UTC
Created attachment 530660 [details, diff]
texlive-freetype2.patch

try pkg-config freetype2 before freetype-config
Comment 3 maurerpe 2018-05-10 02:20:09 UTC
Created attachment 530662 [details]
texlive_core-2017-r4.ebuild

updated ebuild
Comment 4 maurerpe 2018-05-10 02:21:20 UTC
Created attachment 530664 [details, diff]
texlive_core-2017-r3.ebuild.patch

patch to the existing ebuild to make the changes easier to see.
Comment 5 Nikos Chantziaras 2018-05-10 07:13:28 UTC
From freetype's documentation:

The `configure' script no longer installs `freetype-config' by default. For  backwards compatibility, a new configure option `--enable-freetype-config' is provided that reverts this decision.
Comment 6 Ulrich Müller gentoo-dev 2018-05-10 08:13:10 UTC
(In reply to maurerpe from comment #2)
> Created attachment 530660 [details, diff] [details, diff]
> texlive-freetype2.patch
> 
> try pkg-config freetype2 before freetype-config

The fallback to freetype-config doesn't make much sense, given that all freetype versions in the tree support pkg-config.


(In reply to Nikos Chantziaras from comment #5)
> From freetype's documentation:
> 
> The `configure' script no longer installs `freetype-config' by default. For 
> backwards compatibility, a new configure option `--enable-freetype-config'
> is provided that reverts this decision.

Yes, we know. :)
Comment 7 Alexis Ballier gentoo-dev 2018-05-11 14:40:19 UTC
(In reply to maurerpe from comment #3)
> Created attachment 530662 [details]
> texlive_core-2017-r4.ebuild
> 
> updated ebuild

please attach a diff to make this more readable

but from the look of it you are using a custom autoreconf script without adding proper autotools deps, so that won't work

I'm not sure if that's a great idea, but the rule has always been to use autotools.eclass for this.
Comment 8 maurerpe 2018-05-12 03:19:26 UTC
(In reply to Alexis Ballier from comment #7)
> (In reply to maurerpe from comment #3)
> > Created attachment 530662 [details]
> > texlive_core-2017-r4.ebuild
> > 
> > updated ebuild
> 
> please attach a diff to make this more readable

I did.  It is the texlive_core-2017-r3.ebuild.patch attachment.

> but from the look of it you are using a custom autoreconf script without
> adding proper autotools deps, so that won't work
> 
> I'm not sure if that's a great idea, but the rule has always been to use
> autotools.eclass for this.

I am using upstream's provided reautoconf script.  It goes through a couple dozen directories and reruns all the necessary autoconf tools.  It takes a couple of minutes to run.  I don't think it is as simple as adding autotools.eclass and calling autoreconf.  I expect that it will require a manual list of every autoconf directory and calling autoreconf on each one.  I am not sure the best way to do this.  Do you have an example of an ebuild that does this?
Comment 9 maurerpe 2018-05-12 03:37:49 UTC
> The fallback to freetype-config doesn't make much sense, given that all
> freetype versions in the tree support pkg-config.

By fallback, I simply mean that I didn't delete the old code that uses freetype-config.  My usual approach to these patches is to not break existing functionality.  My experience has been that this accelerates upstream adoption as it is easier for them to verify it doesn't break existing use cases.

Which reminds me, I need to submit this upstream.  I have now emailed tex-live@tug.org.  They don't seem to have a bug tracker.
Comment 10 maurerpe 2018-05-12 03:49:05 UTC
> (In reply to Alexis Ballier from comment #7)
> > but from the look of it you are using a custom autoreconf script without
> > adding proper autotools deps, so that won't work

> I expect that it will require a
> manual list of every autoconf directory and calling autoreconf on each one. 
> I am not sure the best way to do this.  Do you have an example of an ebuild
> that does this?

I think I may have figured it out by copying lines from the upstream provided script.

Would something like:
	list=". auxdir/auxsub libs utils texk `find libs utils texk -type d -name ac | sed 's,/ac\$,,'`"
	for dir in $list; do
		(cd $dir; autoreconf)
	done
be acceptable?  If so, I can provide an updated ebuild & ebuild patch.
Comment 11 Ulrich Müller gentoo-dev 2018-05-12 06:39:33 UTC
(In reply to maurerpe from comment #9)
> > The fallback to freetype-config doesn't make much sense, given that all
> > freetype versions in the tree support pkg-config.
> 
> By fallback, I simply mean that I didn't delete the old code that uses
> freetype-config.  My usual approach to these patches is to not break
> existing functionality.  My experience has been that this accelerates
> upstream adoption as it is easier for them to verify it doesn't break
> existing use cases.

*shrug* FreeType supports pkg-config since its version 2.1.5, which was released in 2003. So I don't think you'll do upstream a favour by keeping the cruft.
Comment 12 Sergei Trofimovich (RETIRED) gentoo-dev 2018-05-13 11:24:06 UTC
freetype-2.9.1 went stable and now contends with app-text/texlive-core-2017-r3 (has <media-libs/freetype-2.9.1 in DEPEND)
Comment 13 Nikos Chantziaras 2018-05-13 11:41:46 UTC
Maybe it's better to provide a patch for the generated files instead of going through the (unreasonably long) reconf step during emerge?
Comment 14 Nikos Chantziaras 2018-05-13 13:16:16 UTC
I filed a bug for changing the current dep to freetype-2.9.1-r1 which does not provide freetype-config:

https://bugs.gentoo.org/655650

I'm not doing a git PR since I don't know if we really want the revbump or not (it looks like we might not, in order to get stable users the bug fixes of freetype 2.9.1.)

This is obviously a temporary solution until a patch to use pkg-config is available.
Comment 15 Nikos Chantziaras 2018-05-13 13:17:00 UTC
(In reply to Nikos Chantziaras from comment #14)
> I filed a bug for changing the current dep to freetype-2.9.1-r1 which does
> not provide freetype-config

Uh, typo. It should be "which DOES provide freetype-config."
Comment 16 Coacher 2018-05-13 14:21:49 UTC
*** Bug 655650 has been marked as a duplicate of this bug. ***
Comment 17 Anton Bolshakov 2018-05-16 16:20:47 UTC
Guys, this bug breaks stable users. Please fix it ASAP!
Comment 18 Nikos Chantziaras 2018-05-16 16:58:35 UTC
(In reply to Anton Bolshakov from comment #17)
> Guys, this bug breaks stable users. Please fix it ASAP!
This has been already fixed for the time being. See bug 655650.
Comment 19 Anton Bolshakov 2018-05-17 03:11:29 UTC
(In reply to Nikos Chantziaras from comment #18)
> This has been already fixed for the time being. See bug 655650.

Thanks, apologies. A mirror which I'm using was slow to pick up this change.
Comment 20 Ulenrich 2018-05-17 15:29:08 UTC
The dependency patch of
https://bugs.gentoo.org/655650#c7
is wrong now

See following comment at:
https://bugs.gentoo.org/655650#c8

(I mention here, because that bug is closed, so normaly nobody cares)
Comment 21 Andreas K. Hüttel archtester gentoo-dev 2018-05-20 20:25:39 UTC
This was starting to get annoying, so I gave it a shot. Unfortunately some of our eltpatch magic (the stuff you only understand when your name starts with M) consistently fails even after forcing all eauto* functions into the build system using a crowbar and a sonic screwdriver.

Thus, I went for a suboptimal but working solution: added a mini-patch for freetype and regenerated all the autoconf files in a vanilla tarball, then diff'ed against the original. (The resulting patch is 600kByte xz-compressed.)

Also backported an upstream patch for poppler-0.64.0. Not sure if that code actually makes sense, but if upstream thinks so...

Testing done: builds against current freetype, builds against poppler-0.63, builds against poppler-0.64.

Committing as texlive-core-2017-r4 without keywords for runtime testing and review.
Comment 22 Larry the Git Cow gentoo-dev 2018-05-20 20:26:16 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=edc56c40bdf0d98d3d01dd13a4368c462c58be4e

commit edc56c40bdf0d98d3d01dd13a4368c462c58be4e
Author:     Andreas K. Hüttel <dilfridge@gentoo.org>
AuthorDate: 2018-05-20 20:25:47 +0000
Commit:     Andreas K. Hüttel <dilfridge@gentoo.org>
CommitDate: 2018-05-20 20:26:10 +0000

    app-text/texlive-core: Revbump for poppler-0.64 and recent freetype
    
    Bug: https://bugs.gentoo.org/655052
    Package-Manager: Portage-2.3.38, Repoman-2.3.9

 app-text/texlive-core/Manifest                     |   1 +
 .../files/texlive-core-2017-poppler064.patch       | 118 +++++++
 app-text/texlive-core/texlive-core-2017-r4.ebuild  | 366 +++++++++++++++++++++
 3 files changed, 485 insertions(+)
Comment 23 Nikos Chantziaras 2018-05-21 18:10:09 UTC
Added to package.keywords and it works fine here.
Comment 24 O. William McClung 2018-05-24 15:41:05 UTC
I added '=app-text/texlive-core-2017-r4 **' to package.accept_keywords and it emerged successfully.
Comment 25 maurerpe 2018-05-26 22:50:13 UTC
(In reply to O. William McClung from comment #24)
> I added '=app-text/texlive-core-2017-r4 **' to package.accept_keywords and
> it emerged successfully.

I did the same and got the same result.  I think this is ready to keyword now.
Comment 26 Felix Tiede 2018-06-02 04:15:56 UTC
Works for me as well.
Comment 27 Alarig Le Lay 2018-06-12 11:54:02 UTC
Hi,

As the patch from Andreas seems to fix the bug, do you think that it’s time to stabilise -r4?
This bug still prevent media-libs/freetype-2.9.1-r3 from being installed.
Comment 28 Pacho Ramos gentoo-dev 2018-06-16 18:03:48 UTC
*** Bug 656238 has been marked as a duplicate of this bug. ***
Comment 29 Pacho Ramos gentoo-dev 2018-06-16 18:05:31 UTC
I will CC arches in a week if nobody disagrees
Comment 30 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2018-06-23 20:51:04 UTC
amd64 stable
Comment 31 Larry the Git Cow gentoo-dev 2018-06-24 01:37:42 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8f2f048c792333669aa3029dacd4d0eb853f688b

commit 8f2f048c792333669aa3029dacd4d0eb853f688b
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2018-06-24 01:36:41 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2018-06-24 01:37:36 +0000

    app-text/texlive-core: stable 2017-r4 for ia64, bug #655052
    
    Bug: https://bugs.gentoo.org/655052
    Package-Manager: Portage-2.3.40, Repoman-2.3.9
    RepoMan-Options: --include-arches="ia64"

 app-text/texlive-core/texlive-core-2017-r4.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 32 Larry the Git Cow gentoo-dev 2018-06-24 20:24:22 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3e7a7904585b72ce06249eebfc19d446f4e8f126

commit 3e7a7904585b72ce06249eebfc19d446f4e8f126
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2018-06-24 19:49:03 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2018-06-24 20:20:25 +0000

    app-text/texlive-core: stable 2017-r4 for ppc64, bug #655052
    
    Bug: https://bugs.gentoo.org/655052
    Package-Manager: Portage-2.3.40, Repoman-2.3.9
    RepoMan-Options: --include-arches="ppc64"

 app-text/texlive-core/texlive-core-2017-r4.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 33 Tobias Klausmann (RETIRED) gentoo-dev 2018-06-25 13:37:01 UTC
Stable on alpha.
Comment 34 Thomas Deutschmann (RETIRED) gentoo-dev 2018-06-25 23:27:16 UTC
x86 stable
Comment 35 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2018-06-26 15:46:39 UTC
arm stable
Comment 36 Mart Raudsepp gentoo-dev 2018-06-27 22:26:56 UTC
arm64 stable
Comment 37 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2018-06-30 21:17:02 UTC
s390 stable
Comment 38 ernsteiswuerfel archtester 2018-07-22 20:07:25 UTC
Looking good on ppc.

# cat texlive-core-655052.report 
USE tests started on So 22. Jul 12:55:25 CEST 2018

FEATURES=' test' USE='' succeeded for =app-text/texlive-core-2017-r4
USE='-X cjk doc luajittex -source -tk -xetex' succeeded for =app-text/texlive-core-2017-r4
USE='-X cjk -doc -luajittex source -tk -xetex' succeeded for =app-text/texlive-core-2017-r4
USE='X -cjk -doc luajittex source -tk -xetex' succeeded for =app-text/texlive-core-2017-r4
USE='-X cjk doc luajittex source -tk -xetex' succeeded for =app-text/texlive-core-2017-r4
USE='-X -cjk doc -luajittex -source tk -xetex' succeeded for =app-text/texlive-core-2017-r4
USE='-X -cjk doc luajittex -source tk -xetex' succeeded for =app-text/texlive-core-2017-r4
USE='-X cjk -doc luajittex source tk -xetex' succeeded for =app-text/texlive-core-2017-r4
USE='-X cjk doc -luajittex -source -tk xetex' succeeded for =app-text/texlive-core-2017-r4
USE='X cjk doc -luajittex source -tk xetex' succeeded for =app-text/texlive-core-2017-r4
USE='X cjk -doc luajittex -source tk xetex' succeeded for =app-text/texlive-core-2017-r4
USE='-X -cjk doc luajittex -source tk xetex' succeeded for =app-text/texlive-core-2017-r4
USE='-X -cjk -doc luajittex source tk xetex' succeeded for =app-text/texlive-core-2017-r4

revdep tests started on So 22. Jul 21:37:48 CEST 2018

FEATURES=' test' USE='' succeeded for dev-texlive/texlive-langitalian
FEATURES=' test' USE='' succeeded for dev-texlive/texlive-context
FEATURES=' test' USE='' succeeded for dev-texlive/texlive-metapost
FEATURES=' test' USE='' succeeded for dev-texlive/texlive-langczechslovak
FEATURES=' test' USE='' succeeded for dev-texlive/texlive-bibtexextra
FEATURES=' test' USE='' succeeded for dev-texlive/texlive-langcjk
FEATURES=' test' USE='' succeeded for dev-texlive/texlive-langenglish
FEATURES=' test' USE='' succeeded for dev-texlive/texlive-luatex
FEATURES=' test' USE='' succeeded for dev-texlive/texlive-publishers
FEATURES=' test' USE='' succeeded for dev-texlive/texlive-langcyrillic
Comment 39 Sergei Trofimovich (RETIRED) gentoo-dev 2018-07-30 22:03:05 UTC
ppc stable (thanks to ernsteiswuerfel)
Comment 40 Rolf Eike Beer archtester 2018-10-06 16:20:04 UTC
sparc done, the omfonts problem is likely no regression.
Comment 41 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2018-10-12 12:41:13 UTC
hppa dropped