Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 654596 - =dev-libs/appstream-glib-0.7.9 version bump
Summary: =dev-libs/appstream-glib-0.7.9 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 654594
  Show dependency tree
 
Reported: 2018-05-02 11:09 UTC by Lars Wendler (Polynomial-C) (RETIRED)
Modified: 2018-06-27 16:50 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
appstream-glib-0.7.8.ebuild (appstream-glib-0.7.8.ebuild,1.53 KB, text/plain)
2018-05-02 11:45 UTC, Lars Wendler (Polynomial-C) (RETIRED)
Details
appstream-glib-0.7.8.ebuild.diff (appstream-glib-0.7.8.ebuild.diff,1.31 KB, patch)
2018-05-02 11:46 UTC, Lars Wendler (Polynomial-C) (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2018-05-02 11:09:31 UTC
>=appstream-glib-0.7.4 is required for >=sys-apps/fwupd-1.0.7
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2018-05-02 11:45:51 UTC
Created attachment 529332 [details]
appstream-glib-0.7.8.ebuild

Possible ebuild. Dependencies might need some overhaul.
Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2018-05-02 11:46:32 UTC
Created attachment 529334 [details, diff]
appstream-glib-0.7.8.ebuild.diff

Patch against appstream-glib ebuild from ::gentoo
Comment 3 Mart Raudsepp gentoo-dev 2018-06-27 16:46:53 UTC
After doing my version of the bump and comparing with what's attached here, I found the following issues with the one attached here:

* json-glib dep not updated to >=1.1.2 as meson.build requires
* Redundant bash-completions-r1 inherit (there's no bash completion dir option for meson, always goes to install_dir/share/bash-completion/ -- hopefully that will work out for eprefix...)
* Redundant IUSE=nls
* Unnecessary sqlite dep, sources don't refer to it (but this was unnecessary in 0.6.x ebuild probably too)
* Potentially missing libxml2:2 build time depend for glib-compile-resources functioning
* Missing docbook-xml-dtd:4.2 dep for manpages building
* Missing gtk-doc dependency with USE=doc (and no point in gtk-doc-am dep in meson world, unfortunately, as gtkdoc-rebase isn't used as there's no pregenerated docs in tarball); docbook-xml-dtd:4.3 appears to be a dep only for gtk-docs, so should have moved to a doc? () block along the missing gtk-doc dep.
* Missing explicit -Dalpm=false argument
* emesonargs not sorted the same as in meson_options.txt
* Redundant quoting of "true", "false" and other meson -D argument values
* Usage of usex instead of meson_use
* Missing xdg inherit, though it might not be necessary - added in my bump just in case or so. xdg_environment_reset should be useful though, which this gives us - as this isn't EAPI-7 yet, so no ENV_UNSET (and I'm not sure ENV_UNSET covers all we need in the first place, as some things need to get set to specific values, like inside portage offered temporary dir).

This comment is just meant to assist in future meson conversions, as things to look out for. My bump push will follow in a moment.
Comment 4 Larry the Git Cow gentoo-dev 2018-06-27 16:50:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=08d3fdc2f16f976a70d18cde219710fb6a64f2af

commit 08d3fdc2f16f976a70d18cde219710fb6a64f2af
Author:     Mart Raudsepp <leio@gentoo.org>
AuthorDate: 2018-06-27 16:18:29 +0000
Commit:     Mart Raudsepp <leio@gentoo.org>
CommitDate: 2018-06-27 16:48:11 +0000

    dev-libs/appstream-glib: bump to 0.7.9
    
    Closes: https://bugs.gentoo.org/654596
    Package-Manager: Portage-2.3.40, Repoman-2.3.9

 dev-libs/appstream-glib/Manifest                   |  1 +
 .../appstream-glib/appstream-glib-0.7.9.ebuild     | 65 ++++++++++++++++++++++
 2 files changed, 66 insertions(+)