Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 654588 - net-libs/gtk-vnc USE=vala inexplicably sets econf --disable-vala
Summary: net-libs/gtk-vnc USE=vala inexplicably sets econf --disable-vala
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-02 09:41 UTC by bingquick
Modified: 2018-12-09 16:04 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description bingquick 2018-05-02 09:41:05 UTC 
In net-libs/gtk-vnc-0.7.2.ebuild it has "vala" conf option in IUSE:
---
IUSE="examples +introspection pulseaudio sasl vala"
---

However in "src_configure" session it has a hard-coded "--disable-vala" line:
---
src_configure() {
        
        --disable-vala
        
    )
---

It looks like it should be "$(use_enable vala)" instead.
Comment 1 Mart Raudsepp gentoo-dev 2018-08-05 20:47:18 UTC 
Commented on PR
Comment 2 Larry the Git Cow gentoo-dev 2018-12-09 16:04:58 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c3127bed42e6d50557e9459ea025657062d85cae

commit c3127bed42e6d50557e9459ea025657062d85cae
Author:     Reto Gantenbein <reto.gantenbein@linuxmonk.ch>
AuthorDate: 2018-08-05 22:29:20 +0000
Commit:     Gilles Dartiguelongue <eva@gentoo.org>
CommitDate: 2018-12-09 16:04:39 +0000

    net-libs/gtk-vnc: Properly generate vala files when USE='vala'
    
    Vala bindings are required for newer Gnome packages releases using vala
    and built with meson as C source files are not pre-generated anymore.
    
    Closes: https://bugs.gentoo.org/654588
    Closes: https://github.com/gentoo/gentoo/pull/9457
    
    Tested-by: Reto Gantenbein <reto.gantenbein@linuxmonk.ch>
    Closes: https://github.com/gentoo/gentoo/pull/9457
    Signed-off-by: Gilles Dartiguelongue <eva@gentoo.org>

 net-libs/gtk-vnc/gtk-vnc-0.8.0-r1.ebuild | 70 ++++++++++++++++++++++++++++++++
 1 file changed, 70 insertions(+)