Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 654496 - dev-util/kyua-0.13-r1: installs non-FHS /usr/tests (amd64-fbsd?)
Summary: dev-util/kyua-0.13-r1: installs non-FHS /usr/tests (amd64-fbsd?)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Quality Assurance Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-01 09:23 UTC by Michał Górny
Modified: 2018-09-07 17:18 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
dev-util:kyua-0.13-r1:20180501-092010.log.xz (dev-util:kyua-0.13-r1:20180501-092010.log.xz,13.59 KB, application/x-xz)
2018-05-01 09:23 UTC, Michał Górny
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-05-01 09:23:24 UTC
Created attachment 529230 [details]
dev-util:kyua-0.13-r1:20180501-092010.log.xz

Not sure if it applies to Linux as well but:

--- /usr/tests/
--- /usr/tests/kyua/
>>> /usr/tests/kyua/Kyuafile
--- /usr/tests/kyua/store/
>>> /usr/tests/kyua/store/migrate_test
>>> /usr/tests/kyua/store/write_backend_test
...
Comment 1 Mike Gilbert gentoo-dev 2018-05-01 15:03:40 UTC
Please contact the upstream developer about this.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-05-01 16:38:01 UTC
Why do you claim that it is *my* duty to contact upstream of *your* package about the QA violations *you* introduced by committing it without ensuring proper quality in the first place?
Comment 3 Mike Gilbert gentoo-dev 2018-05-01 16:54:27 UTC
QA violation is a strong way to put it. I asked you to report it because I don't care to argue with upstream about it.
Comment 4 Ulrich Müller gentoo-dev 2018-09-05 10:54:17 UTC
We have a policy about filesystem layout:
https://devmanual.gentoo.org/general-concepts/filesystem/index.html

So I would consider this a QA issue as well. These files should be moved to /usr/lib* or /usr/share.
Comment 5 Mike Gilbert gentoo-dev 2018-09-05 13:44:37 UTC
(In reply to Ulrich Müller from comment #4)

Please feel free to do so; just fix the reverse deps.
Comment 6 Mike Gilbert gentoo-dev 2018-09-06 20:58:27 UTC
According to this FreeBSD man page, they install their test suite in /usr/tests. This is probably why dev-util/atf and dev-util/kyua chose that location to install stuff.

https://www.freebsd.org/cgi/man.cgi?query=tests&apropos=0&sektion=7&manpath=FreeBSD+11.2-RELEASE&arch=default&format=html

Please consider adding /usr/tests to the semi-arbitrary list of valid paths in the devmanual.
Comment 7 Mike Gilbert gentoo-dev 2018-09-06 20:59:18 UTC
Might as well add /usr/src while you are at it, since all kernel packages install files there.
Comment 8 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-09-06 21:00:22 UTC
Let's not forget about /mgorny because I just arbitrarily want it.  If you really insist, I can even write a package that purposely installs files there to prove the point.
Comment 9 Mike Gilbert gentoo-dev 2018-09-06 21:01:08 UTC
(In reply to Michał Górny from comment #8)
> Let's not forget about /mgorny because I just arbitrarily want it.  If you
> really insist, I can even write a package that purposely installs files
> there to prove the point.

My point is that /usr/tests has precedent on nother POSIX-compatible OS.
Comment 10 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-09-06 21:16:25 UTC
So has /usr/man.  Yet we install manpages into /usr/share/man consistently.
Comment 11 Mike Gilbert gentoo-dev 2018-09-06 21:19:27 UTC
(In reply to Michał Górny from comment #10)

/usr/share/tests is not commonly used anywhere, so far as I can tell. Why reinvent the wheel?
Comment 12 Mike Gilbert gentoo-dev 2018-09-06 21:19:58 UTC
NetBSD also uses /usr/tests.

http://netbsd.gw.com/cgi-bin/man-cgi?tests+7+NetBSD-current
Comment 13 Ulrich Müller gentoo-dev 2018-09-07 05:57:51 UTC
(In reply to Mike Gilbert from comment #6)
> According to this FreeBSD man page, they install their test suite in
> /usr/tests. This is probably why dev-util/atf and dev-util/kyua chose that
> location to install stuff.
> 
> https://www.freebsd.org/cgi/man.cgi?query=tests&apropos=0&sektion=7&manpath=FreeBSD+11.2-RELEASE&arch=default&format=html

That says: "The FreeBSD Test Suite first appeared in FreeBSD 10.1."
FreeBSD 10.1 was released in November 2014, long after the FHS was established.

> Please consider adding /usr/tests to the semi-arbitrary list of valid paths
> in the devmanual.

IMHO we should avoid adding new subtrees that are both against our existing policy and against FHS. Especially, when there are obvious alternatives (like /usr/share or /usr/lib*).
Comment 14 Mike Gilbert gentoo-dev 2018-09-07 14:30:07 UTC
Ok, please tell me where to put the files and I will move them.
Comment 15 Larry the Git Cow gentoo-dev 2018-09-07 17:18:51 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=eeb12b3ce2c3790ede09202a74284dbfe5e7f3de

commit eeb12b3ce2c3790ede09202a74284dbfe5e7f3de
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2018-09-07 17:18:23 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2018-09-07 17:18:45 +0000

    dev-util/kyua: remove /usr/tests
    
    Closes: https://bugs.gentoo.org/654496
    Package-Manager: Portage-2.3.49_p2, Repoman-2.3.10_p48

 dev-util/kyua/{kyua-0.13-r1.ebuild => kyua-0.13-r2.ebuild} | 5 +++++
 1 file changed, 5 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3b520e5686ec099557f0ae8cd010616312045fb2

commit 3b520e5686ec099557f0ae8cd010616312045fb2
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2018-09-07 14:53:22 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2018-09-07 17:18:44 +0000

    dev-libs/atf: remove /usr/tests
    
    Bug: https://bugs.gentoo.org/654496
    Package-Manager: Portage-2.3.49_p2, Repoman-2.3.10_p48

 dev-libs/atf/{atf-0.21-r1.ebuild => atf-0.21-r2.ebuild} | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)