Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 654470 - games-emulation/mupen64plus-video-glide64mk2: Remove dependency on media-libs/libtxc_dxtn
Summary: games-emulation/mupen64plus-video-glide64mk2: Remove dependency on media-libs...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michał Górny
URL: https://github.com/mupen64plus/mupen6...
Whiteboard:
Keywords:
Depends on:
Blocks: 654464
  Show dependency tree
 
Reported: 2018-05-01 07:17 UTC by Matt Turner
Modified: 2019-09-28 05:35 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Turner gentoo-dev 2018-05-01 07:17:55 UTC
Presumably this dependency was simply to ensure it was installed so Mesa drivers would support S3TC, and not an actual dependency of mupen64plus-video-glide64mk2 itself.

libtxc_dxtn is now integrated in Mesa, so the dependency is unnecessary (presumably) and media-libs/libtxc_dxtn is being given last rites. Please remove the dependency.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-05-01 07:22:31 UTC
It dlopen()s 'libtxc_dxtn.so' and uses it directly.
Comment 2 Matt Turner gentoo-dev 2018-05-01 16:08:50 UTC
Dang. You are right.

Looks like it already imports code from Mesa, so I'll submit a pull request upstream to pull the DXTn code into the project as well.
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-09-15 09:47:28 UTC
It seems that we can switch to bundled S3TC support.  The code doesn't match libtxc_dxtn, so I'm not sure if it's exactly equivalent but I've just done minimal testing and things seem to work still.

Let's give it a few days.  Feel free to ping me to remove old version then.
Comment 4 Larry the Git Cow gentoo-dev 2019-09-15 09:51:30 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cdac2757d0bdd9582146655e47918978aa92f509

commit cdac2757d0bdd9582146655e47918978aa92f509
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2019-09-15 09:33:10 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2019-09-15 09:51:22 +0000

    games-emulation/mupen64plus-video-glide*: Switch to bundled txc_dxtn
    
    Bug: https://bugs.gentoo.org/654470
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 .../mupen64plus-video-glide64mk2-2.5.9.ebuild                       | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Comment 5 Matt Turner gentoo-dev 2019-09-15 16:30:40 UTC
Thanks. That'll switch from using the external libtxc_dxtn which implements S3TC to the bundled "S2TC" code. S3TC was patent-encumbered until a year or two ago, so someone created S2TC which avoided the patented parts but generated incorrect colors (if I understood correctly).

Since S3TC is no longer patented, ideally upstream would replace the S3TC code with the code from libtxc_dxtn.

But this works for my purposes :)
Comment 6 Matt Turner gentoo-dev 2019-09-28 04:10:14 UTC
(In reply to Michał Górny from comment #3)
> Let's give it a few days.  Feel free to ping me to remove old version then.

Ping :)
Comment 7 Larry the Git Cow gentoo-dev 2019-09-28 05:35:14 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=66a0cd2c537b5206412d7a36ff6c36daa5728df9

commit 66a0cd2c537b5206412d7a36ff6c36daa5728df9
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2019-09-28 05:32:02 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2019-09-28 05:35:03 +0000

    games-emulation/mupen64plus-video-glide64mk2: Drop old (2.5)
    
    Closes: https://bugs.gentoo.org/654470
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 .../mupen64plus-video-glide64mk2/Manifest          |  1 -
 .../mupen64plus-video-glide64mk2-2.5.ebuild        | 88 ----------------------
 2 files changed, 89 deletions(-)