Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 654162 - x11-misc/lightdm - add support for vala bindings
Summary: x11-misc/lightdm - add support for vala bindings
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Markos Chandras (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-27 02:04 UTC by jorgicio
Modified: 2018-04-29 07:41 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
The patch for ebuilds to enable Vala support (lightdm-vala.patch,8.35 KB, patch)
2018-04-27 15:04 UTC, jorgicio
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jorgicio 2018-04-27 02:04:13 UTC
Hi!

I maintain the lightdm-slick-greeter in my overlay. However, it depends on the Vala bindings for lightdm, which are disabled by default and no options to enable it (I mean, there's no USE-flag or Vala support for lightdm).

Please, consider it for later releases. Meanwhile, I'm trying it on my overlay too and it works.

Thanks.

Reproducible: Always
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2018-04-27 08:31:45 UTC
If you happen got get it working, I'd be happy about an ebuild patch (please use a "diff -u" formatted patch and not a full ebuild file).
Comment 2 jorgicio 2018-04-27 14:53:27 UTC
(In reply to Lars Wendler (Polynomial-C) from comment #1)
> If you happen got get it working, I'd be happy about an ebuild patch (please
> use a "diff -u" formatted patch and not a full ebuild file).

Ok.

1.18.3-r1:

https://paste.pound-python.org/show/7hqDxupGrddGbDgdmp3z/

1.24.0-r1:

https://paste.pound-python.org/show/Pu5s4FHmJTjnpY8EcQVI/

1.26.0

https://paste.pound-python.org/show/8diFb2w4D8zEHYjSamK1/
Comment 3 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2018-04-27 14:55:55 UTC
Pleae attach the patches to this bug.
Comment 4 jorgicio 2018-04-27 15:04:19 UTC
Created attachment 528708 [details, diff]
The patch for ebuilds to enable Vala support

I found easier compress everything in just one patch file, so there is.

Also, I tried both three ebuilds and all compile fine.
Comment 5 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2018-04-27 15:24:53 UTC
May I ask why you enabled vala USE flag by default?
Comment 6 jorgicio 2018-04-27 15:28:18 UTC
Maybe for the same reason gtk and introspection are enabled by default, but you can disable it you if want it.
Comment 7 Larry the Git Cow gentoo-dev 2018-04-29 07:39:29 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=89ee646017b617b091995740be5e4ddb2872270a

commit 89ee646017b617b091995740be5e4ddb2872270a
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2018-04-29 07:39:06 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2018-04-29 07:39:23 +0000

    x11-misc/lightdm: Revbump to add dev-lang/vala support.
    
    Thanks to jorgicio for the bug report and the initial patch.
    
    Closes: https://bugs.gentoo.org/654162
    Package-Manager: Portage-2.3.31, Repoman-2.3.9

 x11-misc/lightdm/lightdm-1.26.0-r1.ebuild | 143 ++++++++++++++++++++++++++++++
 1 file changed, 143 insertions(+)
Comment 8 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2018-04-29 07:41:12 UTC
I've added lightdm-1.26.0-r1 to our tree with your changes added. I kept the vala USE flag default disabled because that's how every other ebuild using the vala USE flag is handling it. I also decided to not add this change to the stable ebuild because we need a newer version of lightdm stable anyway.