When installing links, even when USE="-X" desktop-file-utils are pulled in, even though completely point and useless on a non-GUI system. Reproducible: Always Steps to Reproduce: 1.) emerge links with USE="-X" Actual Results: desktop-file-utils is pulled in even though not required or of any use. Expected Results: a build that properly honors the USE-Flags
A year down the road and still nto fixed. Okay, here's an update to this: Ebuild inherits xdg.eclass - as inherits are unconditional, the DEPS set up by the eclass are unconditional. Possible Fixes: * Do not use xdg.eclass * Fix eclass to not include any DEPs or * Make inherits conditional
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a76f277c5df141247cf5fec4afda4c38361f97d2 commit a76f277c5df141247cf5fec4afda4c38361f97d2 Author: Patrice Clement <monsieurp@gentoo.org> AuthorDate: 2020-03-25 11:00:55 +0000 Commit: Patrice Clement <monsieurp@gentoo.org> CommitDate: 2020-03-25 11:01:05 +0000 www-client/links: make inherits conditional. Remove xdg and desktop eclasses from the global scope and make them conditonal on the X USE flag. Closes: https://bugs.gentoo.org/654074 Package-Manager: Portage-2.3.89, Repoman-2.3.20 Signed-off-by: Patrice Clement <monsieurp@gentoo.org> www-client/links/links-2.20.2-r1.ebuild | 183 ++++++++++++++++++++++++++++++++ 1 file changed, 183 insertions(+)
Ben reverted that commit. Apparently, there's no easy fix.
Created attachment 625754 [details, diff] ebuild diff Attached patch should fix this. Switched to xdg-utils eclass and called functions directly.
I think it is better to add eapply_user directly in src_prepare instead of default, because now eautoreconf is not called after eapply_user.
Or just call default before eautoreconf
(In reply to Ben Kohler from comment #6) > Or just call default before eautoreconf Yep :) Want PR?
I'll just slightly modify what you've attached so far, thanks
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b7189840becdc988a8007db0bfaa2f8c7724ccd0 commit b7189840becdc988a8007db0bfaa2f8c7724ccd0 Author: Ben Kohler <bkohler@gentoo.org> AuthorDate: 2020-03-25 16:11:55 +0000 Commit: Ben Kohler <bkohler@gentoo.org> CommitDate: 2020-03-25 16:13:21 +0000 www-client/links: another approach to make xdg deps optional Patch by Stephan Hartmann Closes: https://bugs.gentoo.org/654074 Package-Manager: Portage-2.3.95, Repoman-2.3.21 Signed-off-by: Ben Kohler <bkohler@gentoo.org> www-client/links/links-2.20.2-r1.ebuild | 169 ++++++++++++++++++++++++++++++++ 1 file changed, 169 insertions(+)
