Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 654072 - =www-client/firefox-59.0.2 eme-free useflag broken
Summary: =www-client/firefox-59.0.2 eme-free useflag broken
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-25 13:33 UTC by Oliver Freyermuth
Modified: 2018-04-26 22:55 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Freyermuth 2018-04-25 13:33:59 UTC
As already outlined in https://bugs.gentoo.org/show_bug.cgi?id=650472 , the eme-free useflag has been broken by https://cgit.gentoo.org/proj/mozilla.git/commit/?id=7bb771a5a29810e66a6e77a5662d0efdcfd0dfbf . 

That commit inverted the logic, i.e. activating "eme-free" now results in "--enable-eme" and disabling eme-free now results in "--disable-eme". 

This fully breaks EME since the rest of the ebuild utilizes "use eme-free" which assumes the correct logic.
Comment 1 Larry the Git Cow gentoo-dev 2018-04-25 13:43:14 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/mozilla.git/commit/?id=5022c8a9637194e7277cd406a5e1f1366f9b37c8

commit 5022c8a9637194e7277cd406a5e1f1366f9b37c8
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2018-04-25 13:42:54 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2018-04-25 13:42:54 +0000

    www-client/firefox: Attempt to fix inverted logic for USE="eme-free"
    
    Bug: https://bugs.gentoo.org/654072
    Package-Manager: Portage-2.3.31, Repoman-2.3.9
    Manifest-Sign-Key: 0x498FE765960E9B39

 www-client/firefox/firefox-59.0.2.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)}
Comment 2 Larry the Git Cow gentoo-dev 2018-04-25 13:45:14 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8a3aee62a345dc38c9403bc645a0d5fbabde9597

commit 8a3aee62a345dc38c9403bc645a0d5fbabde9597
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2018-04-25 13:44:53 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2018-04-25 13:45:08 +0000

    www-client/firefox: Attempt to fix inverted logic for USE="eme-free"
    
    Bug: https://bugs.gentoo.org/654072
    Package-Manager: Portage-2.3.31, Repoman-2.3.9

 www-client/firefox/firefox-59.0.2.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)}
Comment 3 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2018-04-25 13:45:51 UTC
Please test and report back if it's fixed now.
Comment 4 Oliver Freyermuth 2018-04-25 17:09:22 UTC
I'm not completely sure, but it seems still broken - visiting:
https://bitmovin.com/mpeg-dash-hls-drm-test-player/
I get:
"EME is supported by your current browser.
Tested Key Systems
- widevine"
widevine is *not* marked with a green checkmark, as it is with Firefox 58. 

However, I can confirm that "--enable-eme" is now correctly passed in the configure process, if "eme-free" is not set.
Comment 5 Georgy Yakovlev archtester gentoo-dev 2018-04-25 17:34:30 UTC
As I reported in previous bug, it fixed the logic, but does not fix the DRM support itself.
Just build tested and DRM does not work.


Here is a simple patch to fix it:

--- firefox-59.0.2.ebuild	2018-04-25 10:02:28.801560092 -0700
+++ www-client/firefox/firefox-59.0.2-r1.ebuild	2018-04-07 23:46:57.340378695 -0700
@@ -192,7 +192,7 @@
 	mozconfig_use_enable jack
 
 	# Enable/Disable eme support
-	mozconfig_use_enable !eme-free eme
+	use eme-free && mozconfig_annotate '+eme-free' --disable-eme
 
 	# It doesn't compile on alpha without this LDFLAGS
 	use alpha && append-ldflags "-Wl,--no-relax"
Comment 6 Nowa Ammerlaan gentoo-dev 2018-04-25 18:47:12 UTC
Patch in Comment 5 worked for me, now I can continue watching netflix :D 
Thanks
Comment 7 Larry the Git Cow gentoo-dev 2018-04-26 22:55:07 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a78e30c0068c3da0493ed5b6ad39c58531878ccf

commit a78e30c0068c3da0493ed5b6ad39c58531878ccf
Author:     Matthias Maier <tamiko@gentoo.org>
AuthorDate: 2018-04-26 22:54:07 +0000
Commit:     Matthias Maier <tamiko@gentoo.org>
CommitDate: 2018-04-26 22:54:53 +0000

    www-client/firefox: fix eme-free use flag
    
    Reverting to old logic, do not do a revision bump.
    
    Closes: https://bugs.gentoo.org/654072
    Package-Manager: Portage-2.3.31, Repoman-2.3.9

 www-client/firefox/firefox-59.0.2.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)