Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 653876 - sys-cluster/slurm: ebuild enhancements
Summary: sys-cluster/slurm: ebuild enhancements
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Alexey Shvetsov
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-23 10:56 UTC by Timo Rothenpieler
Modified: 2018-09-04 13:37 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
slurm-17.11.5.ebuild (slurm-17.11.5.ebuild,8.08 KB, text/plain)
2018-04-23 10:56 UTC, Timo Rothenpieler
Details
slurm.tmpfiles (slurm.tmpfiles,31 bytes, text/plain)
2018-04-23 10:57 UTC, Timo Rothenpieler
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Timo Rothenpieler 2018-04-23 10:56:57 UTC
Created attachment 528252 [details]
slurm-17.11.5.ebuild

Also see my pull request on github: https://github.com/gentoo/gentoo/pull/8025/files

Adds systemd support.
Fixes building perl modules.
Adds some more useflags/optional dependencies with useful features.
Kernel-Options did not match a modern kernels menuconfig, use more generic format.
Various minor fixes.
Comment 1 Timo Rothenpieler 2018-04-23 10:57:33 UTC
Created attachment 528254 [details]
slurm.tmpfiles
Comment 2 Jonas Stein gentoo-dev 2018-04-23 18:26:39 UTC
Thank you for your contribution. I had a short look on the ebuild. 
Here a few ideas:

* external commands (mkdir, ...) need || die
* older_path needs a "local older_path" before
Comment 3 Timo Rothenpieler 2018-04-23 18:55:23 UTC
Yeah, there are a few instances of unchecked commands.
Can fix them as well I guess.

By older_path, you mean folder_path?
Comment 4 Larry the Git Cow gentoo-dev 2018-09-04 13:37:16 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=87493661de13b2f850a0b7de0f955d8e9504fe83

commit 87493661de13b2f850a0b7de0f955d8e9504fe83
Author:     Alexey Shvetsov <alexxy@gentoo.org>
AuthorDate: 2018-09-04 13:31:38 +0000
Commit:     Alexey Shvetsov <alexxy@gentoo.org>
CommitDate: 2018-09-04 13:31:38 +0000

    sys-cluster/slurm: enhance ebuild and migrate to eapi6 and eapi7_ver
    
    Include fixes from Timo Rothenpieler
    Add systemd support.
    Fix building perl modules.
    Add some more useflags with useful features.
    Kernel-Options did not match a modern kernel, use more generic format.
    
    Package-Manager: Portage-2.3.49, Repoman-2.3.10
    Closes: https://bugs.gentoo.org/653876

 sys-cluster/slurm/Manifest                         |   2 +-
 sys-cluster/slurm/files/slurm.tmpfiles             |   1 +
 sys-cluster/slurm/metadata.xml                     |   6 ++
 .../{slurm-17.11.7.ebuild => slurm-17.11.9.ebuild} | 105 +++++++++++++--------
 4 files changed, 75 insertions(+), 39 deletions(-)