Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 653704 - app-shells/zsh-5.5 [-unicode] fails V09datetime, D04parameter, D01prompt, B03print, A03quoting tests
Summary: app-shells/zsh-5.5 [-unicode] fails V09datetime, D04parameter, D01prompt, B03...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: PPC Linux
: Normal normal (vote)
Assignee: Piotr Karbowski (RETIRED)
URL:
Whiteboard:
Keywords: REGRESSION, TESTFAILURE
Depends on: 859586
Blocks:
  Show dependency tree
 
Reported: 2018-04-21 15:21 UTC by ernsteiswuerfel
Modified: 2022-11-26 21:39 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (file_653704.txt,5.64 KB, text/plain)
2018-04-21 15:21 UTC, ernsteiswuerfel
Details
build.log (build.log,107.82 KB, text/plain)
2018-04-21 15:22 UTC, ernsteiswuerfel
Details
build.log (zsh-5.6.2) (zsh-5.6.2:20181020-124045.log,106.36 KB, text/plain)
2018-10-20 13:10 UTC, ernsteiswuerfel
Details
build.log (5.7.1, ppc) (zsh-5.7.1:20190504-193058.log,114.13 KB, text/plain)
2019-05-04 20:02 UTC, ernsteiswuerfel
Details
build.log (ppc64, 5.9) (zsh-5.9:20220720-212332.log,132.87 KB, text/plain)
2022-07-20 21:31 UTC, ernsteiswuerfel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ernsteiswuerfel archtester 2018-04-21 15:21:43 UTC
Created attachment 528158 [details]
emerge --info

With USE="-unicode" these tests fail:

Test ./V09datetime.ztst failed: output differs from expected as shown above for:
  print -r -- ${(V)"$(strftime $'%Y\0%m\0%d' 100000000)"}
Was testing: Embedded nulls
./V09datetime.ztst: test failed.

./D04parameter.ztst: starting.
--- /tmp/zsh.ztst.25921/ztst.out        2018-04-21 16:50:28.838884051 +0200                                                                                                                                        
+++ /tmp/zsh.ztst.25921/ztst.tout	2018-04-21 16:50:28.838884051 +0200
@@ -1 +1 @@
-^?^@
+\C-?\C-@
Test ./D04parameter.ztst failed: output differs from expected as shown above for:
  foo=$'\x7f\x00'
  print -r -- ${(V)foo}
Was testing: ${(V)...}
./D04parameter.ztst: test failed.

./D01prompt.ztst: starting.
--- /tmp/zsh.ztst.25491/ztst.out	2018-04-21 16:50:23.935295170 +0200
+++ /tmp/zsh.ztst.25491/ztst.tout	2018-04-21 16:50:23.938628677 +0200
@@ -1 +1 @@
-
+V
Test ./D01prompt.ztst failed: output differs from expected as shown above for:
  print ${(%U)Y-%(v}
Was testing: Regression test for test on empty psvar
./D01prompt.ztst: test failed.

Test ./B03print.ztst failed: output differs from expected as shown above for:
 unset foo
 print -v foo once more
 typeset -p foo
 printf -v foo "%s\0%s-" into the breach
 typeset -p foo
Was testing: print and printf into a variable
./B03print.ztst: test failed.

./A03quoting.ztst: starting.
--- /tmp/zsh.ztst.16408/ztst.out	2018-04-21 16:49:32.902624006 +0200
+++ /tmp/zsh.ztst.16408/ztst.tout	2018-04-21 16:49:32.905957514 +0200
@@ -1 +1,3 @@
-$'one\\two\n\'buckle\'\tmy\\shoe\n'
+'one\two
+'\''buckle'\''	my\shoe
+'
Test ./A03quoting.ztst failed: output differs from expected as shown above for:
 foo=$'one\\two\n\'buckle\'\tmy\\shoe\n'
 print -r ${(q+)foo}
Was testing: Extended minimal quoting of quotes and backslashes
./A03quoting.ztst: test failed.


This is a regression over zsh-5.3.1 (see bug #633970) where only 3 tests fail:
V09datetime.ztst
D04parameter.ztst
B03print.ztst failed
Comment 1 ernsteiswuerfel archtester 2018-04-21 15:22:11 UTC
Created attachment 528160 [details]
build.log
Comment 2 ernsteiswuerfel archtester 2018-10-20 13:10:40 UTC
Created attachment 551954 [details]
build.log (zsh-5.6.2)

zsh-5.5.1-r1, 5.6.1, 5.6.2 show the same test failures.
Comment 3 ernsteiswuerfel archtester 2019-05-04 20:02:56 UTC
Created attachment 575184 [details]
build.log (5.7.1, ppc)

zsh-5.7.1 fails 7 tests on ppc w. USE=-unicode:

./A03quoting.ztst: test failed.
./B02typeset.ztst: test failed.
./B03print.ztst: test failed.
./D01prompt.ztst: test failed.
./D04parameter.ztst: test failed.
./V09datetime.ztst: test failed.
./V10private.ztst: test failed.
Comment 4 ernsteiswuerfel archtester 2019-05-04 20:27:34 UTC
Re-tested from vanilla zsh-5.7.1.tar.xz and sent a mail to zsh-workers@zsh.org for upstream bug report.
Comment 5 ernsteiswuerfel archtester 2022-07-20 21:31:02 UTC
Created attachment 792668 [details]
build.log (ppc64, 5.9)
Comment 6 Piotr Karbowski (RETIRED) gentoo-dev 2022-07-21 16:26:33 UTC
I will most likely drop the unicode USE flag and make it always on, unless someone here can voice the opinion why not. It seems that even embedded support unicode just fine, hardly any reason to support codepath without unicode.
Comment 7 Larry the Git Cow gentoo-dev 2022-11-26 21:39:02 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c1c6619fe78c334f9b45baeaa8b8300696656c46

commit c1c6619fe78c334f9b45baeaa8b8300696656c46
Author:     Piotr Karbowski <slashbeast@gentoo.org>
AuthorDate: 2022-11-26 21:37:36 +0000
Commit:     Piotr Karbowski <slashbeast@gentoo.org>
CommitDate: 2022-11-26 21:37:36 +0000

    app-shells/zsh: drop unicode USE flag.
    
    THe unicode USE flag makes absolute no sense since the ncurses we really
    depends on will support unicode regardless of this flag, on the top of
    that without unicode support tests are failing. The unicode support is
    now always enabled.
    
    Closes: https://bugs.gentoo.org/653704
    Signed-off-by: Piotr Karbowski <slashbeast@gentoo.org>

 app-shells/zsh/zsh-5.9-r2.ebuild | 235 +++++++++++++++++++++++++++++++++++++++
 app-shells/zsh/zsh-9999.ebuild   |   6 +-
 2 files changed, 238 insertions(+), 3 deletions(-)