Bug 653254 – media-video/handbrake-1.1.0: ../libhb/muxavformat.c:1152:26: error: ‘AV_PKT_FLAG_DISPOSABLE’ undeclared (first use in this function); did you mean ‘AV_PKT_FLAG_DISCARD’?

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Erik Zeek 2018-04-15 17:29:23 UTC]

Created attachment 527534 [details]
Build log

I get the following:

../libhb/muxavformat.c: In function ‘avformatMux’:
../libhb/muxavformat.c:1152:26: error: ‘AV_PKT_FLAG_DISPOSABLE’ undeclared (first use in this function); did you mean ‘AV_PKT_FLAG_DISCARD’?
             pkt.flags |= AV_PKT_FLAG_DISPOSABLE;
                          ^~~~~~~~~~~~~~~~~~~~~~
                          AV_PKT_FLAG_DISCARD

[Comment 1 Erik Zeek 2018-04-15 17:30:20 UTC]

Created attachment 527536 [details]
emerge --info '=media-video/handbrake-1.1.0::gentoo'

[Comment 2 jms 2018-04-15 18:13:38 UTC]

Created attachment 527540 [details]
jms emerge --info handbrake

[Comment 3 jms 2018-04-15 18:13:58 UTC]

same here

[Comment 4 Lars Wendler (Polynomial-C) (RETIRED) 2018-04-15 19:51:47 UTC]

We need to revert the follwing commit with USE="-libav":

https://github.com/HandBrake/HandBrake/commit/9e1f245708a157231c427c0ef9b91729d59a30e1

[Comment 5 Wil Reichert 2018-04-16 02:09:02 UTC]

Patching ffmpeg with this commit works also. 
 https://github.com/FFmpeg/FFmpeg/commit/00d454ed2ca3f8b4d454a837e95931afe604c53f

Tho practically speaking Apple TV 4k support for 2160p60 video is unlikely a high priority for many Gentoo users.

[Comment 6 andcycle-gentoo.bugs 2018-04-17 18:52:50 UTC]

the backport for this patch on stable ffmpeg 3.4 been rejected,

https://www.mail-archive.com/[e-mail]/msg67848.html

[Comment 7 Attila Tóth 2018-04-17 19:16:04 UTC]

(In reply to Wil Reichert from comment #5)
> Patching ffmpeg with this commit works also. 
>  https://github.com/FFmpeg/FFmpeg/commit/
> 00d454ed2ca3f8b4d454a837e95931afe604c53f
> 
> Tho practically speaking Apple TV 4k support for 2160p60 video is unlikely a
> high priority for many Gentoo users.

Works for me.

[Comment 8 fff 2018-04-20 07:46:12 UTC]

same here:

/usr/x86_64-pc-linux-gnu/bin/ld -m elf_x86_64
checking if the linker (/usr/x86_64-pc-linux-gnu/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/x86_64-pc-linux-gnu/bin/ld -m elf_x86_64) supports shared libraries... yes
/usr/bin/gcc -std=gnu99 -pipe -fmessage-length=0 -Wall -g0 -O3 -O2 -pipe -march=native -mfpmath=sse -msse2 -DUSE_LIBAV_AAC -D__LIBHB__ -DUSo
/usr/bin/gcc -std=gnu99 -pipe -fmessage-length=0 -Wall -g0 -O3 -O2 -pipe -march=native -mfpmath=sse -msse2 -DUSE_LIBAV_AAC -D__LIBHB__ -DUSo
../libhb/muxavformat.c: In function ‘avformatMux’:
../libhb/muxavformat.c:1152:26: error: ‘AV_PKT_FLAG_DISPOSABLE’ undeclared (first use in this function)
             pkt.flags |= AV_PKT_FLAG_DISPOSABLE;
                          ^~~~~~~~~~~~~~~~~~~~~~
../libhb/muxavformat.c:1152:26: note: each undeclared identifier is reported only once for each function it appears in
make: *** [../libhb/module.rules:12: libhb/muxavformat.o] Error 1
make: *** Waiting for unfinished jobs....



emerge --info '=media-video/handbrake-1.1.0::gentoo'
Portage 2.3.24 (python 2.7.14-final-0, default/linux/amd64/17.0/systemd, gcc-6.4.0, glibc-2.25-r11, 4.16.2-gentoo-nuc x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-4.16.2-gentoo-nuc-x86_64-Intel-R-_Celeron-R-_CPU_N2830_@_2.16GHz-with-gentoo-2.4.1
KiB Mem:     3934612 total,    138076 free
KiB Swap:    5242876 total,   5156348 free
Timestamp of repository gentoo: Fri, 20 Apr 2018 06:00:01 +0000
Head commit of repository gentoo: 34c74d0331df8135b17f88aa0daee5af8a21809c
sh bash 4.4_p12
ld GNU ld (Gentoo 2.29.1 p3) 2.29.1
app-shells/bash:          4.4_p12::gentoo
dev-java/java-config:     2.2.0-r4::gentoo
dev-lang/perl:            5.24.3-r1::gentoo
dev-lang/python:          2.7.14-r1::gentoo, 3.5.5::gentoo
dev-util/cmake:           3.9.6::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.4.1-r2::gentoo
sys-apps/sandbox:         2.13::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.11.6-r3::gentoo, 1.15.1-r2::gentoo
sys-devel/binutils:       2.29.1-r1::gentoo
sys-devel/gcc:            6.4.0-r1::gentoo
sys-devel/gcc-config:     1.8-r1::gentoo
sys-devel/libtool:        2.4.6-r3::gentoo
sys-devel/make:           4.2.1::gentoo
sys-kernel/linux-headers: 4.16-r1::gentoo (virtual/os-headers)
sys-libs/glibc:           2.25-r11::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-metamanifest: no
    sync-rsync-extra-opts: 

x11
    location: /var/lib/layman/x11
    masters: gentoo
    priority: 50

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA AdobeFlash-10.3 AdobeFlash-10.1 AdobeFlash-11.x Broadcom skype-eula dlj-1.1 Oracle-BCLA-JavaSE cadsoft google-chrome skype-4.0.0.7-copyright"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=native"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /etc/stunnel/stunnel.conf /usr/share/easy-rsa /usr/share/gnupg/qualified.txt /var/bind"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe -march=native"
DISTDIR="/usr/portage/distfiles"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync multilib-strict news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en es"
MAKEOPTS="-j 3"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/almacen/portage-tmp"
USE="X a52 aac acl acpi alsa amd64 apache2 apm audit avx berkdb bluetooth bluray bs2b bzip2 cairo caps cdr cdrtools cli crypt cxx dbus dhcpcd dri dts dv dvb dvd dvdnav dvdr egl emerald encode ffmpeg flac fortran fuse gallium gdbm gif gles1 gles2 glitz graphviz hal iconv idn ipv6 jpeg jpeg2k kdrive kerberos laptop lcms ldap libnotify libsamplerate lirc lvm mad matroska mmx mmxext modules mp3 mpeg multilib ncurses nfs nls nptl nss ogg opengl openmax openmp openvg pam pcre perl png rar readline resolvconf rtmp sasl seccomp slp smp sna sse sse2 sse3 sse4 sse4_1 sse4_2 ssl ssse3 svg systemd tcpd theora threads tiff truetype udev udisks unicode upower vaapi vdpau vlm vorbis wifi x264 x265 xa xattr xcb xcomposite xrandr xv xvid xvmc zlib" ABI_X86="64" ALSA_CARDS="hda-intel" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon plan sheets stage words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-64" INPUT_DEVICES="evdev keyboard mouse synaptics" KERNEL="linux" L10N="en_US es_ES l10n_es" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LIRC_DEVICES="userspace" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6 php7-0" POSTGRES_TARGETS="postgres9_5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_5" RUBY_TARGETS="ruby22 ruby23" USERLAND="GNU" VIDEO_CARDS="intel i965" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

[Comment 9 Ulenrich 2018-04-20 12:02:30 UTC]

@Polynomial-C very thanks for your overlay
media-video/handbrake-1.1.0.ebuild
compiled fine with USE -libav 
having sys-devel/gcc-7.3.0

... yet not tested running handbrake-1.1

[Comment 10 Larry the Git Cow 2018-04-20 19:11:18 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5af06626ddac2bdc28d9eeb557a231c0e1ff1b81

commit 5af06626ddac2bdc28d9eeb557a231c0e1ff1b81
Author:     Lars Wendler <[e-mail]>
AuthorDate: 2018-04-19 08:26:19 +0000
Commit:     Ian Whyman <[e-mail]>
CommitDate: 2018-04-20 19:11:14 +0000

    media-video/handbrake: Fixed build with USE="-libav".
    
    Also add xdg_desktop_database_update calls.
    
    Closes: https://bugs.gentoo.org/653254
    Package-Manager: Portage-2.3.30, Repoman-2.3.9
    Closes: https://github.com/gentoo/gentoo/pull/8065

 .../handbrake/files/handbrake-1.1.0-nolibav.patch  | 235 +++++++++++++++++++++
 media-video/handbrake/handbrake-1.1.0.ebuild       |   6 +-
 2 files changed, 239 insertions(+), 2 deletions(-)

[Comment 11 Ian Whyman (thev00d00) (RETIRED) 2018-04-20 19:19:38 UTC]

Thanks for the patch, Lars!