A couple of weeks ago, upstream sent us a friendly email pointing to us that they already provided an easy to use bundle of packaged dependencies with each release. And true enough, those bundled dependencies work fine and make our ebuild much simpler. I've had a PR waiting for a couple of days at https://github.com/gentoo/gentoo/pull/7775 but it seems like you didn't notice it Erik, so I'm opening a bug here.
You can read more about our policy on using bundled dependencies at: https://wiki.gentoo.org/wiki/Why_not_bundle_dependencies
I think we can close this here, see the link by Gilles for more information. Thank you.
Thanks for the link, but this is a go application we're talking about here and currently, the ebuild vendorized the same dependency. The end result is a statically linked bin. This is already what we do. If this was a C library, I would totally agree with you, but this is Go we're talking about here. However, our vendorisation process is complex and we need to pin each of the dependency ourselves, something upstream *already* does. This is why I suggest that we piggy-back on that work. Could we please re-open?
I reopen for a review by the maintainers.
Virgil, this looks great. Thanks for finding it. I'll use this but I'll delay until the next point release if you don't mind. It offers value to devs but for users the resulting files are in theory identical. So, not worth triggering rebuilds for users that have already installed 3.0.0-r1. Therefore I'll close the merge but leave this ticket open so I can snag the change next time.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d6be94961308bcbc954135412868267b9216f78e commit d6be94961308bcbc954135412868267b9216f78e Author: Erik Mackdanz <stasibear@gentoo.org> AuthorDate: 2018-05-21 01:26:29 +0000 Commit: Erik Mackdanz <stasibear@gentoo.org> CommitDate: 2018-05-21 01:26:29 +0000 app-emulation/lxd: bump to 3.1 Closes: https://bugs.gentoo.org/652846 Closes: https://bugs.gentoo.org/639020 Package-Manager: Portage-2.3.38, Repoman-2.3.9 app-emulation/lxd/Manifest | 1 + .../lxd/files/ja-translation-newline.patch | 11 ++ app-emulation/lxd/lxd-3.1.ebuild | 180 +++++++++++++++++++++ 3 files changed, 192 insertions(+)
