Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 652754 - >=sys-apps/dbus-1.10.24: Why do the tests depend on USE flag 'debug'?
Summary: >=sys-apps/dbus-1.10.24: Why do the tests depend on USE flag 'debug'?
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Freedesktop bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-07 17:37 UTC by gentoo_usr
Modified: 2018-12-05 10:15 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description gentoo_usr 2018-04-07 17:37:21 UTC
Dear maintainers,

I wonder why the test suite of dbus needs the 'debug' USE flag enabled, i.e. the --enable-stats and --enable-verbose-mode? Is there any particular reason?

If they are necessary for testing, wouldn't it be more elegant to pass them to the second configure (used for testing) as the it is already done for --enable-asserts, --enable-checks and --enable-embedded-tests?

I asked because I stumbled upon the failure of test-refs (see #627702). The test suite succeeds, however, if compiled without --enable-verbose-mode. May guess is that the tests fails somehow due to the large log file (~400M) which contains all the verbose output of dbus.
Comment 1 Gilles Dartiguelongue (RETIRED) gentoo-dev 2018-11-18 00:35:12 UTC
This change was introduced in commit 79156e15250b00e3abf4e9b7cfbc1983e791dc0b without much detail about the reason to proceed this way. I have no objection to changing it the way you suggest.

Anyone else ?
Comment 2 Larry the Git Cow gentoo-dev 2018-12-05 10:15:16 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=847a03d1a661c58fe17a4e210af9c573f59b99bb

commit 847a03d1a661c58fe17a4e210af9c573f59b99bb
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2018-12-05 09:44:25 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2018-12-05 10:15:05 +0000

    sys-apps/dbus: Bump to version 1.12.12
    
    Do not require USE="debug" with FEATURES="test" anymore.
    
    Closes: https://bugs.gentoo.org/652754
    Package-Manager: Portage-2.3.52, Repoman-2.3.12
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 sys-apps/dbus/Manifest            |   1 +
 sys-apps/dbus/dbus-1.12.12.ebuild | 279 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 280 insertions(+)