Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 652428 - net-wireless/crda-3.18-r1 with >=dev-libs/openssl-1.1.0 - keys-ssl.c:57:19: error: field ‘e’ has incomplete type
Summary: net-wireless/crda-3.18-r1 with >=dev-libs/openssl-1.1.0 - keys-ssl.c:57:19: e...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Rick Farina (Zero_Chaos)
URL:
Whiteboard:
Keywords: PATCH
: 655684 669550 (view as bug list)
Depends on:
Blocks: openssl-1.1
  Show dependency tree
 
Reported: 2018-04-04 16:52 UTC by Quentin Minster
Modified: 2018-10-25 06:41 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (file_652428.txt,23.23 KB, text/plain)
2018-04-04 16:52 UTC, Quentin Minster
Details
crda-3.18-openssl-1.1.0-compatibility.patch (crda-3.18-openssl-1.1.0-compatibility.patch,8.78 KB, patch)
2018-04-04 16:54 UTC, Quentin Minster
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Quentin Minster 2018-04-04 16:52:26 UTC
Created attachment 526532 [details]
build.log

Since OpenSSL 1.1.0 made most structures opaque, net-wireless/crda fails to build against it. This is due to crda constructing OpenSSL bignums manually instead of using OpenSSL's API.
Comment 1 Quentin Minster 2018-04-04 16:54:57 UTC
Created attachment 526534 [details, diff]
crda-3.18-openssl-1.1.0-compatibility.patch

Here is the patch I just sent upstream for this issue. It applies cleanly to upstream's master as well as Gentoo's crda 3.18.
Comment 2 Quentin Minster 2018-04-04 19:12:13 UTC
Ugh sorry, that's not quite correct: it applies cleanly (though with line adjustments that `patch` figures out on its own) to Gentoo's crda after you remove the crda-3.18-openssl.patch patch.
Comment 3 Andreas Sturmlechner gentoo-dev 2018-08-18 12:01:46 UTC
*** Bug 655684 has been marked as a duplicate of this bug. ***
Comment 4 Andreas Sturmlechner gentoo-dev 2018-08-18 12:08:08 UTC
Thanks for your patch, what's the status upstream? Please add a link so we are able to track its inclusion.
Comment 5 Andreas Sturmlechner gentoo-dev 2018-08-18 13:16:23 UTC
Package builds fine for me with your patch, thanks!
Comment 6 Quentin Minster 2018-08-29 18:42:49 UTC
Sorry for not providing an update earlier: upstream did not respond. I'm still not entirely sure I sent my email to the right address though. 
Right now I don't have time to spare to follow up on this, and I'm afraid that's not going to change before a while.
Please feel free to pick up the patch and try to upstream it.

However, how is this still an issue on Gentoo? I thought most of those OpenSSL 1.1 problems were gone when Gentoo decided to drop the `--api=` and `disable-deprecated` flags when configuring >=dev-libs/openssl-1.1.0.
Only lunatics like me that still have those flags enabled should need this now. :p
Comment 7 Larry the Git Cow gentoo-dev 2018-10-24 21:09:42 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7b3d816ab59a4e9a0b213743555f869141f0a071

commit 7b3d816ab59a4e9a0b213743555f869141f0a071
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2018-10-24 21:09:00 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2018-10-24 21:09:34 +0000

    net-wireless/crda: Revbump to fix openssl-1.1 build failure.
    
    Also bumped ebuild to EAPI-6.
    
    Closes: https://bugs.gentoo.org/652428
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>
    Package-Manager: Portage-2.3.51, Repoman-2.3.11

 net-wireless/crda/crda-3.18-r2.ebuild              |  81 ++++++
 .../crda-3.18-openssl-1.1.0-compatibility.patch    | 315 +++++++++++++++++++++
 2 files changed, 396 insertions(+)
Comment 8 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2018-10-25 06:41:18 UTC
*** Bug 669550 has been marked as a duplicate of this bug. ***