Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 652210 - media-video/xine-ui-0.99.10 fails to build with libcaca support (patch)
Summary: media-video/xine-ui-0.99.10 fails to build with libcaca support (patch)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal major (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords: EBUILD, PATCH
Depends on: 667666
Blocks:
  Show dependency tree
 
Reported: 2018-04-02 13:23 UTC by Joshua Clayton
Modified: 2018-10-03 18:07 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to fix compilation with (xine-ui-0.99.10-config-caca.patch,977 bytes, patch)
2018-04-02 13:23 UTC, Joshua Clayton
Details | Diff
proposed xine-ui-.99.10-r1.ebuild (xine-ui-0.99.10-r1.ebuild,1.99 KB, text/plain)
2018-04-02 13:25 UTC, Joshua Clayton
Details
xine-ui-.99.10-r1.ebuild redux (xine-ui-0.99.10-r1.ebuild,1.98 KB, text/plain)
2018-04-03 05:27 UTC, Joshua Clayton
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Clayton 2018-04-02 13:23:33 UTC
Created attachment 526330 [details, diff]
patch to fix compilation with

cacaxine fails to link due to a bug in the configure script.

x86_64-pc-linux-gnu-gcc  -DCACA  -Wall -D_FILE_OFFSET_BITS=64 -Wpointer-arith -Wnested-externs -Wcast-align -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -march=amdfam10 -O2 -pipe -fno-stack-protector    -DNDEBUG -Wformat=2 -Wno-format-zero-length -Wmissing-format-attribute  -Wmissing-noreturn -Wdisabled-optimization -Werror-implicit-function-declaration -Wstrict-aliasing=2  -Wl,-O1 -Wl,--as-needed -o cacaxine cacaxine-main.o -lcaca  -lm -lpthread ../../src/common/libcommon.a -lxine 
/usr/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: cacaxine-main.o: undefined reference to symbol 'dlclose@@GLIBC_2.2.5'
/lib64/libdl.so.2: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
make[3]: *** [Makefile:478: cacaxine] Error 1

Detail: a bug in the configure causes LD_ADD not to be set properly for the cacaxine target. This is an upstream bug, and I am hitting the xine-devel mailing list as well.
Comment 1 Joshua Clayton 2018-04-02 13:25:34 UTC
Created attachment 526332 [details]
proposed xine-ui-.99.10-r1.ebuild

ebuild upgrade the EAPI to 6 and adds PATCHES array with the patch
Comment 2 Jonas Stein gentoo-dev 2018-04-02 13:52:58 UTC
Thank you for your contribution. I had a short look on the ebuild. 
Here a few ideas:

* Please test the ebuild with repoman full -x https://wiki.gentoo.org/wiki/Repoman
* fdo-mime is obsolete. See also https://wiki.gentoo.org/wiki/Notes_on_ebuilds_with_GUI
Comment 3 Joshua Clayton 2018-04-03 05:27:37 UTC
Created attachment 526420 [details]
xine-ui-.99.10-r1.ebuild redux

New ebuild. Fix the business with  fdo-mime

Repoman full -x has no complaints

I started poking at a couple of other warnings, but they are more involved to fix, and I was regressing and had to pull back.
Comment 4 Larry the Git Cow gentoo-dev 2018-10-03 16:13:13 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=224b9ef113b7fe96a6130b023da57be16577e270

commit 224b9ef113b7fe96a6130b023da57be16577e270
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-10-03 16:12:41 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-10-03 16:12:41 +0000

    media-video/xine-ui: EAPI-6 bump, fix USE=libcaca
    
    Thanks-to: Joshua Clayton <stillcompiling@gmail.com>
    Closes: https://bugs.gentoo.org/652210
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
    Package-Manager: Portage-2.3.50, Repoman-2.3.11

 .../xine-ui/files/xine-ui-0.99.10-libcaca.patch    | 24 ++++++++++++++++++++
 media-video/xine-ui/xine-ui-0.99.10.ebuild         | 26 +++++++++++++---------
 2 files changed, 39 insertions(+), 11 deletions(-)
Comment 5 Andreas Sturmlechner gentoo-dev 2018-10-03 16:20:00 UTC
Thanks for your patch! And sorry that it took so long to merge it.