Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 652204 - sci-electronics/kicad-4.0.7: Unknown CMake command "_CHECK_SYMBOL_EXISTS".
Summary: sci-electronics/kicad-4.0.7: Unknown CMake command "_CHECK_SYMBOL_EXISTS".
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Zoltan Puskas
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-02 11:42 UTC by lekto
Modified: 2018-05-16 09:03 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge.info,5.61 KB, application/x-info)
2018-04-02 11:42 UTC, lekto
Details
CMakeOutput.log (CMakeOutput.log,58.06 KB, text/plain)
2018-04-02 11:43 UTC, lekto
Details
build.log (build.log,4.55 KB, text/plain)
2018-04-02 11:45 UTC, lekto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description lekto 2018-04-02 11:42:56 UTC
Created attachment 526320 [details]
emerge --info

ebuild  N     ] sci-electronics/kicad-4.0.7::gentoo  USE="github python -debug -doc -examples -i18n -libressl -minimal" L10N="pl -bg -ca -cs -de -el -es -fi -fr -hu -it -ja -ko -nl -pt -ru -sk -sl -sv -zh-CN" PYTHON_TARGETS="python2_7" 0 KiB




-- Looking for strncasecmp
-- Looking for strncasecmp - found
-- Looking for strtok_r
-- Looking for strtok_r - found
CMake Error at CMakeModules/CheckCXXSymbolExists.cmake:41 (_CHECK_SYMBOL_EXISTS):
  Unknown CMake command "_CHECK_SYMBOL_EXISTS".
Call Stack (most recent call first):
  CMakeModules/PerformFeatureChecks.cmake:86 (check_cxx_symbol_exists)
  CMakeLists.txt:141 (perform_feature_checks)


-- Configuring incomplete, errors occurred!
See also "/var/tmp/portage/sci-electronics/kicad-4.0.7/work/kicad-4.0.7_build/CMakeFiles/CMakeOutput.log".
Comment 1 lekto 2018-04-02 11:43:41 UTC
Created attachment 526322 [details]
CMakeOutput.log
Comment 2 lekto 2018-04-02 11:45:48 UTC
Created attachment 526326 [details]
build.log
Comment 3 Torsten Kaiser 2018-04-07 19:48:42 UTC
Testing things for a different Bug I hit this issue too. It seems to be causes by dev-util/cmake-3.11.0, as kicad builds successfully after downgrading to cmake-3.10.3.
Comment 4 Jonas Stein gentoo-dev 2018-04-07 20:00:22 UTC
Confirmed by Torsten
Comment 5 Zoltan Puskas 2018-04-16 01:04:23 UTC
Apparently the "CHECK_CXX_SYMBOL_EXISTS" macro override was unnecessary since CMake 2.8.6. CMake 3.11 broke the reference to the internal variable "_CHECK_SYMBOL_EXISTS", thus the failure.

Upstream has fixed this already [1]. I've backported the patch to kicad-4.0.{5|6|7} ebuilds and submitted PR [2].

Tested compiling affected kicad ebuilds with both cmake-3.10.3 and cmake-3.11.0.

[1] https://github.com/KiCad/kicad-source-mirror/commit/2e0b75c058d676f427328506bbf3bc10079da117
[2] https://github.com/gentoo/gentoo/pull/8020
Comment 6 Zoltan Puskas 2018-04-16 01:26:30 UTC
The issue also happens with sci-electronics/kicad-4.0.4 on the stable branch. I've updated the PR to fix that ebuild too.
Comment 7 Juergen Rose 2018-04-29 06:47:07 UTC
It still fails for me.
Comment 8 Zoltan Puskas 2018-04-30 17:56:57 UTC
(In reply to Juergen Rose from comment #7)
> It still fails for me.

PR has not landed yet, so it's not yet in main tree. Or does it fail after applying the content of the PR?
Comment 9 Larry the Git Cow gentoo-dev 2018-05-16 09:03:32 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d00cfe6700229442c37df3376a5b9220bc156a63

commit d00cfe6700229442c37df3376a5b9220bc156a63
Author:     Zoltan Puskas <zoltan@sinustrom.info>
AuthorDate: 2018-04-16 00:55:14 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-05-16 09:03:07 +0000

    sci-electronics/kicad: Fix configuration issue with >=CMake-3.11
    
    KiCad had a legacy redefinition of the CHECK_CXX_SYMBOL_EXISTS macro,
    that is not needed since CMake-2.8.6. Upstream fix:
    https://github.com/KiCad/kicad-source-mirror/commit/2e0b75c058d676f427328506bbf3bc10079da117
    Also fixed src_configure().
    
    Partial merge of https://github.com/gentoo/gentoo/pull/8020
    
    Closes: https://bugs.gentoo.org/652204
    Closes: https://bugs.gentoo.org/652736
    
    Package-Manager: Portage-2.3.28, Repoman-2.3.9

 .../files/kicad-cmake-checkcxxsymbolexists.patch   | 46 ++++++++++++++++++++++
 sci-electronics/kicad/kicad-4.0.5-r1.ebuild        |  8 ++--
 sci-electronics/kicad/kicad-4.0.6.ebuild           |  8 ++--
 sci-electronics/kicad/kicad-4.0.7.ebuild           |  5 ++-
 4 files changed, 59 insertions(+), 8 deletions(-)