Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 652178 - dev-lang/icon clean up
Summary: dev-lang/icon clean up
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Stabilization (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Cheyenne Wills
URL:
Whiteboard:
Keywords: STABLEREQ
Depends on:
Blocks:
 
Reported: 2018-04-01 23:40 UTC by Jonas Stein
Modified: 2018-05-20 17:35 UTC (History)
1 user (show)

See Also:
Package list:
=dev-lang/icon-9.5.1-r1
Runtime testing required: ---
stable-bot: sanity-check+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonas Stein gentoo-dev 2018-04-01 23:40:22 UTC
repoman full -x
returns several problems.

can we have a tidied up ebuild of 9.5.1 and stabilize it, please?

Some ideas: 
Please review the dodirs 
Bump to EAPI=6, remove eutils

Also the rest of the ebuild looks a bit strange to me.

See also 
https://devmanual.gentoo.org/ebuild-writing/eapi/
https://blogs.gentoo.org/mgorny/2015/11/13/the-ultimate-guide-to-eapi-6/

Please join the IRC support channel #gentoo-dev-help or #gentoo-proxy-maint, if you got stuck and need help.

Does it make sense to keep 9.4.3-r5 in the tree then?
Comment 1 Cheyenne Wills 2018-04-02 17:37:41 UTC
9.4.3-r5 can be removed.

I'll need some assistance on exactly what you are trying to "clean up" in the ebuild.  I wasn't the original author of the ebuild, though I took up as the proxy maintainer because of my familiarity with the upstream code and the language.
Comment 2 Larry the Git Cow gentoo-dev 2018-04-20 08:50:44 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1651eaaf8c8be56333e8b2d460913e27a97a1636

commit 1651eaaf8c8be56333e8b2d460913e27a97a1636
Author:     Cheyenne Wills <cheyenne.wills@gmail.com>
AuthorDate: 2018-04-19 02:41:16 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2018-04-20 08:50:30 +0000

    dev-lang/icon: EAPI 6 Cleanup
    
    * Document rationale for emake -j1
    
    Bug: https://bugs.gentoo.org/652178
    Package-Manager: Portage-2.3.24, Repoman-2.3.6
    Closes: https://github.com/gentoo/gentoo/pull/8064

 dev-lang/icon/icon-9.5.1-r1.ebuild | 110 +++++++++++++++++++++++++++++++++++++
 1 file changed, 110 insertions(+)}
Comment 3 Cheyenne Wills 2018-04-20 12:07:53 UTC
Once 9.5.1-r1 is stabilized, the other ebuilds can be removed.
Comment 4 Matt Turner gentoo-dev 2018-04-28 00:47:33 UTC
Please cc arches when appropriate.
Comment 5 Arfrever Frehtes Taifersar Arahesis 2018-05-12 02:45:52 UTC
Other versions of this package have only ~s390 keyword, not s390.
Comment 6 Cheyenne Wills 2018-05-12 15:27:55 UTC
(In reply to Arfrever Frehtes Taifersar Arahesis from comment #5)
> Other versions of this package have only ~s390 keyword, not s390.

The s390 version works.  I use it quite regularly
Comment 7 Larry the Git Cow gentoo-dev 2018-05-12 15:32:59 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=89d06193ec9f79cf6e8bfc40697e920023eeb2cd

commit 89d06193ec9f79cf6e8bfc40697e920023eeb2cd
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2018-05-12 15:31:52 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2018-05-12 15:31:52 +0000

    dev-lang/icon: stable 9.5.1-r1 for ia64, bug #652178
    
    Bug: https://bugs.gentoo.org/652178
    Package-Manager: Portage-2.3.36, Repoman-2.3.9
    RepoMan-Options: --include-arches="ia64"

 dev-lang/icon/icon-9.5.1-r1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 8 Larry the Git Cow gentoo-dev 2018-05-13 09:53:06 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f0e81b5cd3771f7d6a3ddb670ffbeb2dda4d00d7

commit f0e81b5cd3771f7d6a3ddb670ffbeb2dda4d00d7
Author:     Rolf Eike Beer <eike@sf-mail.de>
AuthorDate: 2018-05-13 06:54:15 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2018-05-13 09:52:54 +0000

    dev-lang/icon: stable 9.5.1-r1 for sparc
    
    Bug: https://bugs.gentoo.org/652178
    Package-Manager: Portage-2.3.24, Repoman-2.3.6
    RepoMan-Options: --include-arches="sparc"

 dev-lang/icon/icon-9.5.1-r1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 9 Thomas Deutschmann (RETIRED) gentoo-dev 2018-05-13 22:08:28 UTC
x86 stable
Comment 10 Tobias Klausmann (RETIRED) gentoo-dev 2018-05-14 14:28:24 UTC
Stable on alpha.
Comment 11 Agostino Sarubbo gentoo-dev 2018-05-16 12:23:10 UTC
amd64 stable
Comment 12 Matt Turner gentoo-dev 2018-05-20 17:33:30 UTC
stable ppc/ppc64/hppa keywords dropped.
Comment 13 Larry the Git Cow gentoo-dev 2018-05-20 17:35:17 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d060d5ce277e89ba856638a2bcd2c12a7d92a54e

commit d060d5ce277e89ba856638a2bcd2c12a7d92a54e
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2018-05-20 17:34:22 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2018-05-20 17:35:03 +0000

    dev-lang/icon: Drop old versions
    
    Dropping stable ppc, ppc64, and hppa keywords since there are no known
    users and no reverse dependencies.
    
    Closes: https://bugs.gentoo.org/652178

 dev-lang/icon/Manifest                     |   2 -
 dev-lang/icon/files/icon-9.4.3-flags.patch |  62 ----------------
 dev-lang/icon/files/icon-9.5.0-flags.patch |  75 -------------------
 dev-lang/icon/files/tests-943.patch        | 113 -----------------------------
 dev-lang/icon/icon-9.4.3-r5.ebuild         | 108 ---------------------------
 dev-lang/icon/icon-9.5.0-r1.ebuild         | 104 --------------------------
 dev-lang/icon/icon-9.5.0.ebuild            | 103 --------------------------
 dev-lang/icon/icon-9.5.1.ebuild            | 102 --------------------------
 8 files changed, 669 deletions(-)