Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 651956 - =media-libs/aubio-0.4.6 - src_compile() sandbox violations while erroneously running tests
Summary: =media-libs/aubio-0.4.6 - src_compile() sandbox violations while erroneously ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Professional Audio Applications Maintainers
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2018-03-30 02:58 UTC by Greg Turner
Modified: 2018-12-03 20:13 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
aubio-0.4.6-test-disablement-hack.patch (force-no-testing.patch,668 bytes, patch)
2018-03-30 02:58 UTC, Greg Turner
Details | Diff
build.log from my box (build.log,120.34 KB, text/plain)
2018-03-30 09:29 UTC, Greg Turner
Details
reporter_provided-build.log (build.log,120.09 KB, text/x-log)
2018-03-30 09:32 UTC, Greg Turner
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Turner 2018-03-30 02:58:38 UTC
Created attachment 526142 [details, diff]
aubio-0.4.6-test-disablement-hack.patch

It seems that =media-libs/aubio-0.4.6 has two problems.

First, although the ebuild attempts to explicitly request by command-line argument that tests not run, waf goes ahead and runs them anyhow.  Second, the tests want to do GPU things, causing a sandbox violation.

In order to prevent this, I implemented a local workaround which I've enclosed.  It's pretty kludgey.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2018-03-30 04:13:01 UTC
Comment on attachment 526142 [details, diff]
aubio-0.4.6-test-disablement-hack.patch

Not sure what this patch actually does.

Could you attach the entire build log to this bug report so that others can see the problem you're seeing?
Comment 2 Greg Turner 2018-03-30 09:29:29 UTC
Created attachment 526148 [details]
build.log from my box

Here's a build.log.

FWIW, of the two problems cited, I am coming to suspect that the sandbox violation is some kind of bug idiosyncratic to my workstation.  Or perhaps one of those things that only happens when you emerge -e @world, which I happen to be doing (in which case it will be "eventually ubiquitous" :P).  Anyhow I don't see bugzilla getting filled with similar reports and yet I've now found several seemingly harmless packages exhibiting this locally (often when some opencl-enabled executable is loaded).  I've been unable to figure out exactly what's going on even though I've chased it at length in gdb.

Anyhow: the first problem, that of the tests running when they shouldn't, is almost certainly legit.  See waf steps starting around #155.

My patch simply strips the tests out of the tree of script dependencies by telling the script to look for tests that aren't there (instead of tests that are).  But as I said, that's really kludgey.  Someone who understands waf should probably do something more elegant -- it's just a work-around.
Comment 3 Greg Turner 2018-03-30 09:32:02 UTC
Created attachment 526150 [details]
reporter_provided-build.log

updated build.log with ansi color disabled.
Comment 4 Greg Turner 2018-03-31 08:39:55 UTC
I've changed the summary to reflect the correct ebuild phase.

To be clear, the tests are running during src_compile.  The ebuild /attempts/ to support testing in src_test and furthermore, to suppress testing in src_compile. 
 But the mechanism it's using apparently doesn't work anymore.
Comment 5 Larry the Git Cow gentoo-dev 2018-10-01 20:08:34 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4f613c9fe28398d60b4329e2e9e64dd5316579fd

commit 4f613c9fe28398d60b4329e2e9e64dd5316579fd
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-10-01 20:07:08 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-10-01 20:08:19 +0000

    media-libs/aubio: Disable tests for real
    
    Tests were always built and run regardless. At least disable them
    if not requested.
    
    Bug: https://bugs.gentoo.org/651956
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
    Package-Manager: Portage-2.3.50, Repoman-2.3.11

 media-libs/aubio/aubio-0.4.7.ebuild | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
Comment 6 Andreas Sturmlechner gentoo-dev 2018-12-03 20:13:34 UTC
Assuming this is fixed.