Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 651810 - games-strategy/hedgewars - bugfix for writing settings on disk issue
Summary: games-strategy/hedgewars - bugfix for writing settings on disk issue
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Games
URL: https://github.com/hedgewars/hw/commi...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2018-03-28 09:48 UTC by Quentin Retornaz
Modified: 2018-03-29 18:56 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
updated qt5-2.patch that also include commit that fix writing settings on disk (hedgewars-0.9.23-qt5-2.patch,20.72 KB, patch)
2018-03-28 10:00 UTC, Quentin Retornaz
Details | Diff
settings saving bugfix (hedgewars-0.9.23-settings-saving-bugfix.patch,5.17 KB, patch)
2018-03-28 11:31 UTC, Quentin Retornaz
Details | Diff
ebuild to apply the patch (hedgewars-0.9.23-r3.ebuild,2.46 KB, text/plain)
2018-03-28 11:32 UTC, Quentin Retornaz
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Quentin Retornaz 2018-03-28 09:48:58 UTC
A commit from upstream that could be applied as-is is fixing a bug when built with Qt 5.9 where settings are not written on disk when changed.

Here is the bugfix commit: https://github.com/hedgewars/hw/commit/f8e302e5ac5033c1b7ac5d83d6d8df3f15eb6178
Comment 1 Quentin Retornaz 2018-03-28 10:00:53 UTC
Created attachment 525828 [details, diff]
updated qt5-2.patch that also include commit that fix writing settings on disk

I updated hedgewars-0.9.23-qt5-2.patch to add changes on that commit.
Comment 2 Quentin Retornaz 2018-03-28 11:31:30 UTC
Created attachment 525834 [details, diff]
settings saving bugfix

Changed by doing a separated patch instead.
Comment 3 Quentin Retornaz 2018-03-28 11:32:20 UTC
Created attachment 525836 [details]
ebuild to apply the patch
Comment 4 Larry the Git Cow gentoo-dev 2018-03-29 18:56:55 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2bc30a2ca0454d4c93ae8e7b88775b14dbe36841

commit 2bc30a2ca0454d4c93ae8e7b88775b14dbe36841
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-03-29 18:36:21 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-03-29 18:56:40 +0000

    games-strategy/hedgewars: Fix settings saving w/ Qt-5.9
    
    Thanks-to: Quentin R. <gentoo@retornaz.com>
    Closes: https://bugs.gentoo.org/651810
    Package-Manager: Portage-2.3.26, Repoman-2.3.7

 .../files/hedgewars-0.9.23-settings-saving.patch   | 134 +++++++++++++++++++++
 .../hedgewars/hedgewars-0.9.23-r3.ebuild           |  94 +++++++++++++++
 2 files changed, 228 insertions(+)