Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 650834 - dev-ruby/rbnacl: fix buffer size type in randombytes_buf() binding
Summary: dev-ruby/rbnacl: fix buffer size type in randombytes_buf() binding
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Ruby Team
URL: https://github.com/crypto-rb/rbnacl/p...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: 611168
  Show dependency tree
 
Reported: 2018-03-18 21:32 UTC by Sergei Trofimovich (RETIRED)
Modified: 2018-04-07 05:33 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
rbnacl-5.0.0-randombytes_buf.patch (rbnacl-5.0.0-randombytes_buf.patch,500 bytes, patch)
2018-03-18 21:32 UTC, Sergei Trofimovich (RETIRED)
Details | Diff
rbnacl-5.0.0-randombytes_buf.patch (rbnacl-5.0.0-randombytes_buf.patch,402 bytes, patch)
2018-03-18 21:39 UTC, Sergei Trofimovich (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergei Trofimovich (RETIRED) gentoo-dev 2018-03-18 21:32:24 UTC
Created attachment 524322 [details, diff]
rbnacl-5.0.0-randombytes_buf.patch

=dev-ruby/rbnacl-5.0.0 fails tests on powerpc32 due to a bug in randombytes_buf() binding

Proposed patch upstream as: https://github.com/crypto-rb/rbnacl/pull/174
Comment 1 Sergei Trofimovich (RETIRED) gentoo-dev 2018-03-18 21:39:47 UTC
Created attachment 524324 [details, diff]
rbnacl-5.0.0-randombytes_buf.patch

Fixed diff offset in the patch to be actually applicable.

Applies and passes all tests on rbnacl-5.0.0:5. I think it should apply as-is on rbnacl:4 as well.
Comment 2 Hans de Graaff gentoo-dev Security 2018-04-02 07:03:48 UTC
Given that this is a cryptography-related package I'll wait for a comment from upstream.
Comment 3 Sergei Trofimovich (RETIRED) gentoo-dev 2018-04-06 06:10:24 UTC
Upstream merged the change.
Comment 4 Larry the Git Cow gentoo-dev 2018-04-07 05:33:07 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a5ce5d3cecdf57bbac811abf0e6f9a1069f0ee8f

commit a5ce5d3cecdf57bbac811abf0e6f9a1069f0ee8f
Author:     Hans de Graaff <graaff@gentoo.org>
AuthorDate: 2018-04-07 05:32:12 +0000
Commit:     Hans de Graaff <graaff@gentoo.org>
CommitDate: 2018-04-07 05:32:43 +0000

    dev-ruby/rbnacl: fix buffer size on ppc32, bug 650834
    
    Thanks to slyfox for providing a patch.
    
    Closes: https://bugs.gentoo.org/650834
    Package-Manager: Portage-2.3.24, Repoman-2.3.6

 dev-ruby/rbnacl/files/rbnacl-buffer-size.patch | 24 ++++++++++++++++++
 dev-ruby/rbnacl/rbnacl-4.0.2-r1.ebuild         | 34 ++++++++++++++++++++++++++
 dev-ruby/rbnacl/rbnacl-5.0.0-r1.ebuild         | 34 ++++++++++++++++++++++++++
 3 files changed, 92 insertions(+)