Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 650164 - dev-libs/isl-0.19: Use preserve_old_lib()
Summary: dev-libs/isl-0.19: Use preserve_old_lib()
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Highest major (vote)
Assignee: Gentoo Toolchain Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-11 04:04 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2018-03-11 04:40 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch (isl.patch,1.17 KB, patch)
2018-03-11 04:32 UTC, Arfrever Frehtes Taifersar Arahesis
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis 2018-03-11 04:04:03 UTC
Internal executables of sys-devel/gcc[graphite] are linked against libisl.so:

$ scanelf -qF "%F: %n" $(qlist sys-devel/gcc | sort) | grep libisl.so
/usr/libexec/gcc/x86_64-pc-linux-gnu/6.4.0/cc1: libisl.so.15,libmpc.so.3,libmpfr.so.6,libgmp.so.10,libdl.so.2,libz.so.1,libm.so.6,libc.so.6,ld-linux-x86-64.so.2
/usr/libexec/gcc/x86_64-pc-linux-gnu/6.4.0/cc1plus: libisl.so.15,libmpc.so.3,libmpfr.so.6,libgmp.so.10,libdl.so.2,libz.so.1,libm.so.6,libc.so.6,ld-linux-x86-64.so.2
/usr/libexec/gcc/x86_64-pc-linux-gnu/6.4.0/lto1: libisl.so.15,libmpc.so.3,libmpfr.so.6,libgmp.so.10,libdl.so.2,libz.so.1,libm.so.6,libc.so.6,ld-linux-x86-64.so.2
/usr/libexec/gcc/x86_64-pc-linux-gnu/7.3.0/cc1: libisl.so.15,libmpc.so.3,libmpfr.so.6,libgmp.so.10,libdl.so.2,libz.so.1,libm.so.6,libc.so.6,ld-linux-x86-64.so.2
/usr/libexec/gcc/x86_64-pc-linux-gnu/7.3.0/cc1plus: libisl.so.15,libmpc.so.3,libmpfr.so.6,libgmp.so.10,libdl.so.2,libz.so.1,libm.so.6,libc.so.6,ld-linux-x86-64.so.2
/usr/libexec/gcc/x86_64-pc-linux-gnu/7.3.0/lto1: libisl.so.15,libmpc.so.3,libmpfr.so.6,libgmp.so.10,libdl.so.2,libz.so.1,libm.so.6,libc.so.6,ld-linux-x86-64.so.2


In order to allow upgrade for users of Portage with FEATURES="-preserve-libs" and users of PkgCore and users of Paludis, preserve_old_lib() should be used in dev-libs/isl-0.19:


inherit ... preserve-libs

pkg_preinst() {
    preserve_old_lib \
        /usr/$(get_libdir)/libisl$(get_libname 14)
        /usr/$(get_libdir)/libisl$(get_libname 15)
}

pkg_postinst() {
    preserve_old_lib_notify \
        /usr/$(get_libdir)/libisl$(get_libname 14)
        /usr/$(get_libdir)/libisl$(get_libname 15)
}
Comment 1 Anthony Basile gentoo-dev 2018-03-11 04:07:50 UTC
makes sense to me.  do you want to produce a patch?
Comment 2 Anthony Basile gentoo-dev 2018-03-11 04:08:38 UTC
(In reply to Anthony Basile from comment #1)
> makes sense to me.  do you want to produce a patch?

or are you suggesting this just for 0.19 in which case i can add it.
Comment 3 Arfrever Frehtes Taifersar Arahesis 2018-03-11 04:16:28 UTC
(There were some typos in example patch.)
(I will create patch after testing.)
Comment 4 Anthony Basile gentoo-dev 2018-03-11 04:20:21 UTC
(In reply to Arfrever Frehtes Taifersar Arahesis from comment #3)
> (There were some typos in example patch.)
> (I will create patch after testing.)

yeah i see you're missing a \
Comment 5 Arfrever Frehtes Taifersar Arahesis 2018-03-11 04:32:53 UTC
Created attachment 523396 [details, diff]
Patch

(Successfully tested patch.)
Comment 6 Larry the Git Cow gentoo-dev 2018-03-11 04:40:29 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cbbe96bd3260884fa279fab4e8c3ff3e9918e33f

commit cbbe96bd3260884fa279fab4e8c3ff3e9918e33f
Author:     Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
AuthorDate: 2018-03-11 04:29:29 +0000
Commit:     Anthony G. Basile <blueness@gentoo.org>
CommitDate: 2018-03-11 04:39:53 +0000

    dev-libs/isl: Call preserve_old_lib() to fix upgrade path.
    
    Closes: https://bugs.gentoo.org/650164

 dev-libs/isl/isl-0.19.ebuild | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)