/usr/bin/cross-emerge contains bashisms that should be fixed. > checkbashisms /usr/bin/cross-emerge possible bashism in /usr/bin/cross-emerge line 13 (alternative test command ([[ foo ]] should be [ foo ])): if [[ ${EPREFIX} == "@"GENTOO_PORTAGE_EPREFIX"@" ]] ; then possible bashism in /usr/bin/cross-emerge line 13 (should be 'b = a'): if [[ ${EPREFIX} == "@"GENTOO_PORTAGE_EPREFIX"@" ]] ; then Note: I only checked the 20171230 package; this bug may affect other versions as well.
Created attachment 523280 [details, diff] cross-emerge.patch cross-emerge.patch
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/proj/crossdev.git/commit/?id=21a0f5a3d83084436e6f6b66114cc5c593528866 commit 21a0f5a3d83084436e6f6b66114cc5c593528866 Author: Sergei Trofimovich <slyfox@gentoo.org> AuthorDate: 2018-03-10 13:04:46 +0000 Commit: Sergei Trofimovich <slyfox@gentoo.org> CommitDate: 2018-03-10 13:04:46 +0000 cross-emerge: tweak EPREFIX handling to be POSIX sh, bug #650100 Reported and fixed by Scall. Reported-by: Scall Fixed-by: Scall Closes: https://bugs.gentoo.org/650100 Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org> wrappers/cross-emerge | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Patch look s good! I've applied it as-is. Thank you!
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/crossdev.git/commit/?id=394fb518fbc0789402b853d7ec44eaf283ffae51 commit 394fb518fbc0789402b853d7ec44eaf283ffae51 Author: Sergei Trofimovich <slyfox@gentoo.org> AuthorDate: 2018-03-24 15:08:00 +0000 Commit: Sergei Trofimovich <slyfox@gentoo.org> CommitDate: 2018-03-24 15:12:51 +0000 cross-emerge: fix empty EPREFIX handling, bug #650100 commit 21a0f5a3d83084436e6f6b66114cc5c593528866 ("cross-emerge: tweak EPREFIX handling to be POSIX sh, bug #650100") introduced a bug: $ foo-emerge foo-emerge: line 13: [: =: unary operator expected Tweak it by quoting 'test' argument. Reported-by: Marty E. Plummer Bug: https://bugs.gentoo.org/650100 Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org> wrappers/cross-emerge | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)}
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=79e2aaafe727f09b7b6a34164a8e88bad6afcdd0 commit 79e2aaafe727f09b7b6a34164a8e88bad6afcdd0 Author: Sergei Trofimovich <slyfox@gentoo.org> AuthorDate: 2018-04-10 07:51:54 +0000 Commit: Sergei Trofimovich <slyfox@gentoo.org> CommitDate: 2018-04-10 07:51:54 +0000 sys-devel/crossdev: bump up to 20180410 Closes: https://bugs.gentoo.org/652724 Bug: https://bugs.gentoo.org/147155 Bug: https://bugs.gentoo.org/650100 Package-Manager: Portage-2.3.28, Repoman-2.3.9 sys-devel/crossdev/Manifest | 1 + sys-devel/crossdev/crossdev-20180410.ebuild | 39 +++++++++++++++++++++++++++++ 2 files changed, 40 insertions(+)}