Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 649590 - sys-apps/util-linux-2.31.1: doesn't respect -j1
Summary: sys-apps/util-linux-2.31.1: doesn't respect -j1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-04 20:57 UTC by Toralf Förster
Modified: 2018-03-07 02:56 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
23.20180304-215501 (23.20180304-215501,48.56 KB, text/plain)
2018-03-04 20:58 UTC, Toralf Förster
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2018-03-04 20:57:45 UTC
The tinderbox sets this :


MAKEOPTS="-j 1"
NINJAFLAGS="-j 1"
EGO_BUILD_FLAGS="-p 1"
GOMAXPROCS="1"
GO19CONCURRENTCOMPILATION=0
RUSTFLAGS="-C codegen-units=1"
RUST_TEST_THREADS=1
RUST_TEST_TASKS=1


but the attched pstree shows that - at least in the test phase - that is not respected.
Comment 1 Toralf Förster gentoo-dev 2018-03-04 20:58:01 UTC
Created attachment 522410 [details]
23.20180304-215501

pstree
Comment 2 Thomas Deutschmann (RETIRED) gentoo-dev 2018-03-04 23:12:52 UTC
Yeah, https://github.com/karelzak/util-linux/blob/master/tests/run.sh#L70 ... we would have to patch https://github.com/karelzak/util-linux/blob/master/tests/Makemodule.am#L19 however I cannot think about a reliable method.

Remember, "MAKEOPTS" can be set to

 -j2
 -j 2
 --jobs=2
 --jobs 2
 --jobs=2 --load-average=3.79
 ...

Reliable parsing in bash so that we can sed in number of parallel jobs seems to be hard.
Comment 3 Larry the Git Cow gentoo-dev 2018-03-07 02:56:00 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=57d163547a20c63eb22f37c339e46f463fe4dc62

commit 57d163547a20c63eb22f37c339e46f463fe4dc62
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2018-03-07 02:54:55 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2018-03-07 02:55:18 +0000

    sys-apps/util-linux: Make tests honor MAKEOPTS; Fix uuidd test
    
    Closes: https://bugs.gentoo.org/593304
    Closes: https://bugs.gentoo.org/649590
    Package-Manager: Portage-2.3.24, Repoman-2.3.6

 sys-apps/util-linux/util-linux-2.30.2.ebuild   | 11 +++++++++--
 sys-apps/util-linux/util-linux-2.31-r1.ebuild  | 13 ++++++++++---
 sys-apps/util-linux/util-linux-2.31.1.ebuild   | 13 ++++++++++---
 sys-apps/util-linux/util-linux-2.32_rc2.ebuild | 11 +++++++++--
 sys-apps/util-linux/util-linux-9999.ebuild     | 11 +++++++++--
 5 files changed, 47 insertions(+), 12 deletions(-)