Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 649464 - dev-util/gtk-update-icon-cache-3.22.19 - QA Notice: new icons were found installed but GTK+ icon cache has not been updated
Summary: dev-util/gtk-update-icon-cache-3.22.19 - QA Notice: new icons were found inst...
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: All Linux
: Normal QA
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 651804
  Show dependency tree
 
Reported: 2018-03-03 14:35 UTC by Francesco Turco
Modified: 2018-07-02 18:45 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.xz (build.log.xz,25.96 KB, application/x-xz)
2018-03-03 14:35 UTC, Francesco Turco
Details
emerge --info gtk-update-icon-cache (info.txt,5.78 KB, text/plain)
2018-03-03 14:35 UTC, Francesco Turco
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Francesco Turco 2018-03-03 14:35:31 UTC
Created attachment 522076 [details]
build.log.xz

Portage reports the following QA issue:

> QA Notice: new icons were found installed but GTK+ icon cache
> has not been updated:
>   /usr/share/icons/oxygen/base/256x256/mimetypes/text-x-c++hdr.png
>   /usr/share/icons/oxygen/base/256x256/mimetypes/application-x-dgn.png
>   /usr/share/icons/oxygen/base/256x256/mimetypes/encrypted.png
>   ...
Comment 1 Francesco Turco 2018-03-03 14:35:55 UTC
Created attachment 522078 [details]
emerge --info gtk-update-icon-cache
Comment 2 Mart Raudsepp gentoo-dev 2018-03-03 14:43:02 UTC
Sounds like a portage bug to me; gtk-update-icon-cache isn't installing any icons.
At most we might want to consider running it if it's a fresh install (to initially generate the cache if something has been installing icons while the cache updater wasn't available yet), but this warning is just wrong.

Is portage keeping a global list of icons it has seen or what?

Was this an initial gtk-update-icon-cache install or an upgrade/rebuild?
Comment 3 Francesco Turco 2018-03-03 21:00:30 UTC
# qlop -gv gtk-update-icon-cache
gtk-update-icon-cache-3.20.9: Mon Nov  7 15:05:10 2016: 17 seconds
gtk-update-icon-cache-3.22.2: Mon Nov 14 15:30:11 2016: 18 seconds
gtk-update-icon-cache-3.22.2: Thu Nov 17 03:18:30 2016: 27 seconds
gtk-update-icon-cache-3.22.2: Mon Nov 21 04:15:03 2016: 23 seconds
gtk-update-icon-cache-3.22.2: Wed Jan  4 19:11:40 2017: 23 seconds
gtk-update-icon-cache-3.22.2: Fri Mar 31 13:33:21 2017: 13 seconds
gtk-update-icon-cache-3.22.2: Wed Apr 19 10:50:10 2017: 14 seconds
gtk-update-icon-cache-3.22.2: Sat Jul 15 03:38:53 2017: 14 seconds
gtk-update-icon-cache-3.22.2: Sat Jul 22 08:29:52 2017: 6 seconds
gtk-update-icon-cache-3.22.2: Tue Aug  8 17:19:40 2017: 13 seconds
gtk-update-icon-cache-3.22.2: Sun Aug 13 09:59:25 2017: 4 seconds
gtk-update-icon-cache-3.22.19: Mon Aug 28 17:03:34 2017: 16 seconds
gtk-update-icon-cache-3.22.19: Sun Sep 24 10:47:46 2017: 15 seconds
gtk-update-icon-cache-3.22.19: Fri Jan  5 18:45:56 2018: 19 seconds
gtk-update-icon-cache-3.22.19: Thu Mar  1 16:58:15 2018: 479 seconds
gtk-update-icon-cache: 15 times
Comment 4 Mart Raudsepp gentoo-dev 2018-03-04 18:56:26 UTC
portage@ - any ideas what's going on here?
Comment 5 Zac Medico gentoo-dev 2018-03-04 19:11:33 UTC
We need to whitelist gtk-update-icon-cache for the first time that it is installed, this will fix it:

https://archives.gentoo.org/gentoo-portage-dev/message/a8848a392fb81bc00eb12e3fae347a3e
https://github.com/gentoo/portage/pull/263
Comment 6 Mart Raudsepp gentoo-dev 2018-03-04 20:17:02 UTC
(In reply to Zac Medico from comment #5)
> We need to whitelist gtk-update-icon-cache for the first time that it is
> installed

fturco log seems to suggest it wasn't a first install?
Though maybe it was first time QA check?

Also that code exits at top with gtk-update-icon-cache isn't present - so this must be obviously running after it's first installed, as to need the special case. That part seems clear.

Is there a global cache or how/why is it even considering these files here?
Comment 7 Larry the Git Cow gentoo-dev 2018-03-16 09:27:19 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=0d75a363355ad7b19e4f7ddbfa62e600c75f42ce

commit 0d75a363355ad7b19e4f7ddbfa62e600c75f42ce
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2018-03-04 19:02:52 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2018-03-16 09:26:23 +0000

    gnome2-utils postinst: fix false positive for gtk-update-icon-cache (bug 649464)
    
    For the first install of gtk-update-icon-cache, there's no
    way to initialize state during preinst, so we have to ignore
    this package in order to avoid false positives.
    
    Bug: https://bugs.gentoo.org/649464

 bin/postinst-qa-check.d/50gnome2-utils | 3 +++
 1 file changed, 3 insertions(+)}
Comment 8 Zac Medico gentoo-dev 2018-03-16 09:33:21 UTC
(In reply to Mart Raudsepp from comment #6)
> (In reply to Zac Medico from comment #5)
> > We need to whitelist gtk-update-icon-cache for the first time that it is
> > installed
> 
> fturco log seems to suggest it wasn't a first install?
> Though maybe it was first time QA check?

If it wasn't a first install, then it was probably temporarily unmerged for some reason. It seems that the above qlop command does not show unmerges.

> Also that code exits at top with gtk-update-icon-cache isn't present - so
> this must be obviously running after it's first installed, as to need the
> special case. That part seems clear.
> 
> Is there a global cache or how/why is it even considering these files here?

This QA check relies on initialization of a baseline state before the package is merged, and part of the initialization is to run gtk-update-icon-cache if there are any icons that are newer than the cache. The initialization is skipped if gtk-update-icon-cache is not installed yet.
Comment 9 Francesco Turco 2018-03-16 11:50:30 UTC
The following command shows unmerges:

$ qlop -uv gtk-update-icon-cache
Mon Nov 14 15:30:26 2016 <<< dev-util/gtk-update-icon-cache-3.20.9
Thu Nov 17 03:18:52 2016 <<< dev-util/gtk-update-icon-cache-3.22.2
Mon Nov 21 04:15:22 2016 <<< dev-util/gtk-update-icon-cache-3.22.2
Wed Jan  4 19:11:59 2017 <<< dev-util/gtk-update-icon-cache-3.22.2
Wed Mar 29 16:40:43 2017 <<< dev-util/gtk-update-icon-cache-3.22.2
Fri Apr  7 12:09:30 2017 <<< dev-util/gtk-update-icon-cache-3.22.2
Sun Apr 23 19:53:19 2017 <<< dev-util/gtk-update-icon-cache-3.22.2
Fri Jul 21 23:46:52 2017 <<< dev-util/gtk-update-icon-cache-3.22.2
Sat Jul 22 20:04:34 2017 <<< dev-util/gtk-update-icon-cache-3.22.2
Wed Aug  9 22:01:41 2017 <<< dev-util/gtk-update-icon-cache-3.22.2
Wed Aug 16 16:39:34 2017 <<< dev-util/gtk-update-icon-cache-3.22.2
Sat Sep 23 18:07:44 2017 <<< dev-util/gtk-update-icon-cache-3.22.19
Wed Oct  4 18:44:10 2017 <<< dev-util/gtk-update-icon-cache-3.22.19
Fri Jan 12 19:54:47 2018 <<< dev-util/gtk-update-icon-cache-3.22.19

So I removed gtk-update-icon-cache on January 12th and then I reinstalled it on March 1st according to comment #3.
Comment 10 Zac Medico gentoo-dev 2018-07-02 18:45:33 UTC
Fixed in portage-2.3.40-r1.