Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 649310 - app-editors/atom-1.24.0 version bump
Summary: app-editors/atom-1.24.0 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Elvis Pranskevichus
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2018-03-02 00:38 UTC by Audiodef
Modified: 2018-11-10 22:37 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Audiodef 2018-03-02 00:38:31 UTC
Stable app-editors/atom is now version. 1.24.0. Ebuild could be updated. https://github.com/atom/atom/releases/tag/v1.24.0

This might possibly work with dev-util/electron-1.8.2. https://electronjs.org/releases#1.8.2
Comment 1 Pavel Volkov 2018-03-16 08:33:00 UTC
Current release is 1.25.0 now.
Comment 2 Leho Kraav (:macmaN @lkraav) 2018-05-22 12:52:11 UTC
Current release is 1.27.1 now. Is there an overlay working on this package?
Comment 3 Pavel Volkov 2018-05-22 19:40:09 UTC
There's app-editors/atom-bin-1.27.0 in jorgicio overlay.
Comment 4 Leho Kraav (:macmaN @lkraav) 2018-05-23 12:58:21 UTC
Thanks.

Itmw, working with `elprans` overlay atom ebuild, I had great trouble getting Git integration to work, until I specified `LOCAL_GIT_DIRECTORY=/usr`

For some reason, the build has trouble finding its internal git implementation, so none of the `git-shell-out-strategy.js` spawned shell commands work.
Comment 5 Elvis Pranskevichus 2018-05-23 14:01:00 UTC
> I had great trouble getting Git integration to work, until I specified `LOCAL_GIT_DIRECTORY=/usr`

That bit somehow slipped through cracks when I the electron unbundling patch got bumped last time:  https://github.com/gentoo/gentoo/blob/86c5fc23402880ae5a24116dabb21bebe27cc072/app-editors/atom/files/atom-unbundle-electron-r1.patch#L25
Comment 6 Cynede (RETIRED) gentoo-dev 2018-05-23 14:02:58 UTC
you can use one from my overlay too, I focus on beta versions...
Comment 7 Elvis Pranskevichus 2018-05-23 14:13:27 UTC
I just pushed 1.27.1 to the atom overlay.
Comment 8 Sander Sweers 2018-10-01 20:20:59 UTC
It would be nice if atom can be bumped in the tree because of https://github.com/atom/atom/issues/15737. Electron 1.8 (>=1.7.10) should solve the font rendering problem.
Comment 9 Leho Kraav (:macmaN @lkraav) 2018-10-02 07:47:03 UTC
Chaos overlay has done significant work on `atom` ebuild that works w/ `electron-bin`. We're already at 1.31.1

* https://gitlab.com/chaoslab/chaoslab-overlay/issues/33
* https://gitlab.com/chaoslab/chaoslab-overlay/tree/master/app-editors/atom

I'd recommend bringing both this ebuild and `electron-bin` in the main tree. Building `electron` is highly resource intensive - is it really worth it for majority of the apps?
Comment 10 Elvis Pranskevichus 2018-10-02 12:54:27 UTC
New atom versions are staged in the atom overlay (which chaoslab's ebuilds are based on).  I'm against merging that version as it doesn't do proper unbundling of the binaries.  There is an entire distribution of Git in there, for example.

As for electron-bin, sure, if somebody is willing to spend the effort, PRs are welcome.
Comment 11 Leho Kraav (:macmaN @lkraav) 2018-10-02 17:07:15 UTC
Thanks for the updates. We worked on it in Chaos overlay, because Atom overlay didn't seem to move much for a while, but probably more importantly, Chaos  already had `electron-bin` ready-made from before.

I could file a new bug for `electron-bin`, but perhaps one step of preliminary research could be done in this comment? Based on
https://gitlab.com/chaoslab/chaoslab-overlay/tree/master/dev-util/electron-bin

* should `electron` and `electron-bin` block each other, for any version?

* is it technically possible to have both simultaneously installed? What would be an example use case? We should probably not bother supporting complicated uber-edge use cases.

* based on your expert evaluation, what items of work would be needed for adopting Chaos overlay `electron-bin` into the main tree?
Comment 12 Elvis Pranskevichus 2018-10-02 17:30:43 UTC
Please open a new bug for 'electron-bin' and let's take that discussion there.  This is an atom bump bug.
Comment 13 John Stile 2018-11-02 23:03:15 UTC
Stable version is now app-editors/atom--1.31.2
Comment 14 John Stile 2018-11-05 03:14:48 UTC
I was able to install and run atom-1.32.1
by making an overlay using
https://gitlab.com/chaoslab/chaoslab-overlay/tree/master/app-editors/atom

I had to hack atom-1.32.1.ebuild 
changing:
 electron-bin 
to
 electron

I had to install dev-util/electron-2.0.10

After the emerge completed, I had to edit /usr/libexec/atom/resources/app/atom.sh
Fixing the path:
 ATOM_PATH="/usr/lib64/electron-2.0/electron"

At least now the editor launches.
Comment 15 Larry the Git Cow gentoo-dev 2018-11-10 22:37:17 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=556193a8e22c7f5201c7a1a0740dcd1e53f518a6

commit 556193a8e22c7f5201c7a1a0740dcd1e53f518a6
Author:     Elvis Pranskevichus <elvis@magic.io>
AuthorDate: 2018-11-04 20:43:10 +0000
Commit:     Patrice Clement <monsieurp@gentoo.org>
CommitDate: 2018-11-10 22:37:09 +0000

    app-editors/atom: version bump to 1.32.1.
    
    Closes: https://bugs.gentoo.org/649310
    Package-Manager: Portage-2.3.49, Repoman-2.3.11
    Signed-off-by: Elvis Pranskevichus <elvis@magic.io>
    Closes: https://github.com/gentoo/gentoo/pull/10339
    Signed-off-by: Patrice Clement <monsieurp@gentoo.org>

 app-editors/atom/Manifest                          |  26 +
 app-editors/atom/atom-1.32.1.ebuild                | 561 +++++++++++++++++++++
 .../atom/files/atom-fix-app-restart-r2.patch       |  24 +
 .../atom/files/atom-fix-config-watcher-r1.patch    |  41 ++
 app-editors/atom/files/atom-python-r1.patch        |  25 +
 .../atom/files/atom-unbundle-electron-r3.patch     |  39 ++
 app-editors/atom/files/transpile-coffee-script.js  |   6 +-
 7 files changed, 720 insertions(+), 2 deletions(-)