Electron stable release is now 1.8.2. Ebuild could be updated. https://electronjs.org/releases#1.8.2
May be should not because of https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2018-1000136
Latest Electron is 2.0.1 now. Are there any dependency issues with updating?
https://github.com/elprans/atom-overlay is currently the most up to date overlays, so I'll just exploring this. Electron is still 1.7.13 here, though.
I'll work on a bump to 2.0 soon. It seems that app-editors/atom skipped 1.8 and went straight to 2.0 in the latest beta, so it's not worth spending time on the 1.8 bump.
Thanks. Itmw, I just built atom-1.27.1 on top of electron-1.17.15 and it seems to work OK.
Considering the size of ElectronJS and how it takes a ton of resource to build at reasonable speed, using https://gitlab.com/chaoslab/chaoslab-overlay/tree/master/dev-util/electron-bin would seem to be sensible. Thoughts?
Elvis: It's the first time I look at this package and I'm impressed by how heavily you had to patch electron to make it work in Gentoo! Looks well done, although this package+patches is too big for a thorough review. On the surface though, it all looks good to me. You have a significant maintainership history, so I'll go with trusting you. Merging. There's one nitpick I have but I don't want to hold merging because of it. The ffmpeg/samba thing added in 2.0.10's COMMON_DEPEND, there could be a comment talking about this. Its purpose is not obvious (especially with the fact that you require "ffmpeg[-samba]" AND samba. it's confusing). I'm guessing that it's linked to some tricky issue, but without a comment, it looks like dead weight. Another nitpick for next time: you might want to look at removing a couple of subslot-ties in your deps. Not all of these deps have subslots. It's true that in most cases, you'll want to rebuild on subslot changes, but not in all cases. Because electron is a huge package, you will want to look into each dependency to make sure that a subslot-change rebuild is necessary. Also, the presence of this kind of deps slows down portage dependency resolution by a great deal, so we don't want to overuse them.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a14ff3dacbf3704e3463a19192c2621b9cb2febb commit a14ff3dacbf3704e3463a19192c2621b9cb2febb Author: Elvis Pranskevichus <elvis@magic.io> AuthorDate: 2018-09-28 20:56:32 +0000 Commit: Virgil Dupras <vdupras@gentoo.org> CommitDate: 2018-10-23 13:20:09 +0000 dev-util/electron: Bump to 1.6.16, 1.7.15, and 2.0.10 This adds electron-2.0.10 and picks up latest security and compilation fixes for 1.6.x and 1.7.x. Closes: https://bugs.gentoo.org/661050 Closes: https://bugs.gentoo.org/649308 Package-Manager: Portage-2.3.49, Repoman-2.3.10 Signed-off-by: Elvis Pranskevichus <elvis@magic.io> Closes: https://github.com/gentoo/gentoo/pull/10009 Signed-off-by: Virgil Dupras <vdupras@gentoo.org> dev-util/electron/Manifest | 12 + dev-util/electron/electron-1.6.18.ebuild | 883 ++++++++++++++++++++++++++++ dev-util/electron/electron-1.7.16.ebuild | 889 ++++++++++++++++++++++++++++ dev-util/electron/electron-2.0.10.ebuild | 908 +++++++++++++++++++++++++++++ dev-util/electron/files/toolchain/BUILD.gn | 18 + 5 files changed, 2710 insertions(+)
Thanks for the review and merging, Virgil! > The ffmpeg/samba thing added in 2.0.10's COMMON_DEPEND That was added (in www-client/chromium) because of https://bugs.gentoo.org/622164. I'll investigate if it's still necessary on the next bump (and add a link to the bug if it is). > you might want to look at removing a couple of subslot-ties in your deps I mostly just follow what the www-client/chromium guys are doing (since Electron is basically Chromium with a bunch of patches). But it might be true that some aren't necessary, I'll check.
