Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 649274 - dev-lang/php[acl]: Unconditionally forces -lacl while acl_*() are built-in on FreeBSD
Summary: dev-lang/php[acl]: Unconditionally forces -lacl while acl_*() are built-in on...
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: FreeBSD (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: PHP Bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-01 21:45 UTC by Michał Górny
Modified: 2019-10-11 17:37 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
dev-lang:php-7.2.2:20180301-213955.log (dev-lang:php-7.2.2:20180301-213955.log,45.92 KB, text/plain)
2018-03-01 21:45 UTC, Michał Górny
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-03-01 21:45:41 UTC
Created attachment 521758 [details]
dev-lang:php-7.2.2:20180301-213955.log

sapi/fpm/config.m4 states:

  if test "$PHP_FPM_ACL" != "no" ; then
    AC_CHECK_HEADERS([sys/acl.h])
    AC_CHECK_LIB(acl, acl_free, [
      PHP_ADD_LIBRARY(acl)
      AC_DEFINE(HAVE_FPM_ACL, 1, [ POSIX Access Control List ])
    ],[
      AC_MSG_ERROR(libacl required not found)
    ])
  fi

This is wrong since acl_* routines are built-in in libc on FreeBSD (i.e. don't require extra -l flags).
Comment 1 Larry the Git Cow gentoo-dev 2018-03-02 00:49:30 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bd1acc61d95897f7326d69f1bf07ec4abbdf2d4c

commit bd1acc61d95897f7326d69f1bf07ec4abbdf2d4c
Author:     Brian Evans <grknight@gentoo.org>
AuthorDate: 2018-03-02 00:49:15 +0000
Commit:     Brian Evans <grknight@gentoo.org>
CommitDate: 2018-03-02 00:49:15 +0000

    dev-lang/php: Version bump for 7.0.28
    
    Bug: https://bugs.gentoo.org/649274
    Package-Manager: Portage-2.3.24, Repoman-2.3.6

 dev-lang/php/Manifest          |   1 +
 dev-lang/php/php-7.0.28.ebuild | 739 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 740 insertions(+)}
Comment 2 Larry the Git Cow gentoo-dev 2018-03-02 02:10:37 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b92d451af8317c4ec1999eb99f0732c1d33a77af

commit b92d451af8317c4ec1999eb99f0732c1d33a77af
Author:     Brian Evans <grknight@gentoo.org>
AuthorDate: 2018-03-02 02:02:05 +0000
Commit:     Brian Evans <grknight@gentoo.org>
CommitDate: 2018-03-02 02:10:21 +0000

    dev-lang/php: Version bump for 7.2.3
    
    Bug: https://bugs.gentoo.org/649274
    Package-Manager: Portage-2.3.24, Repoman-2.3.6

 dev-lang/php/Manifest         |   1 +
 dev-lang/php/php-7.2.3.ebuild | 737 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 738 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ede12cb50b03daac81f5e5573ad890c4c11a8e33

commit ede12cb50b03daac81f5e5573ad890c4c11a8e33
Author:     Brian Evans <grknight@gentoo.org>
AuthorDate: 2018-03-02 01:22:15 +0000
Commit:     Brian Evans <grknight@gentoo.org>
CommitDate: 2018-03-02 02:10:19 +0000

    dev-lang/php: Version bump for 5.6.34
    
    Bug: https://bugs.gentoo.org/649274
    Package-Manager: Portage-2.3.24, Repoman-2.3.6

 dev-lang/php/Manifest          |   1 +
 dev-lang/php/php-5.6.34.ebuild | 775 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 776 insertions(+)}
Comment 3 Larry the Git Cow gentoo-dev 2018-03-02 02:25:40 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7f3408e7f15e4beffe5f7366a76d9687d79f1ec4

commit 7f3408e7f15e4beffe5f7366a76d9687d79f1ec4
Author:     Brian Evans <grknight@gentoo.org>
AuthorDate: 2018-03-02 02:24:14 +0000
Commit:     Brian Evans <grknight@gentoo.org>
CommitDate: 2018-03-02 02:24:14 +0000

    profiles: default/bsd/fbsd/package.use.mask - acl on php broken
    
    Mask this use until upstream can be contacted and
    a patch can be worked up.
    
    Bug: https://bugs.gentoo.org/649274

 profiles/default/bsd/fbsd/package.use.mask | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)}
Comment 4 Brian Evans (RETIRED) gentoo-dev 2018-03-02 02:29:53 UTC
Oops, wrong bug for the version bumps.
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-03-02 07:54:23 UTC
(In reply to Brian Evans from comment #4)
> Oops, wrong bug for the version bumps.

And I already thought you have a magical power and made upstream make releases for this fix instantly :-D.

Are you aware if upstream supports FreeBSD at all? I've also noticed incorrect 'date' syntax in configure, so maybe they don't test it at all.
Comment 6 Brian Evans (RETIRED) gentoo-dev 2018-03-02 13:40:15 UTC
(In reply to Michał Górny from comment #5)
> Are you aware if upstream supports FreeBSD at all? I've also noticed
> incorrect 'date' syntax in configure, so maybe they don't test it at all.

The bug tracker does show reports from FreeBSD.  I can only guess not many of them use ports and rely on the packaged versions (if any).

Feel free to file bugs and PRs upstream.
Comment 7 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-10-11 17:37:15 UTC
*-fbsd is gone.