Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 649184 - media-video/smplayer should not depend on net-misc/youtube-dl
Summary: media-video/smplayer should not depend on net-misc/youtube-dl
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2018-03-01 13:43 UTC by M
Modified: 2019-03-03 19:23 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description M 2018-03-01 13:43:17 UTC
Currently smplayer has the following runtime dependencies:
RDEPEND="${COMMON_DEPEND}
        || (
                media-video/mplayer[bidi?,libass,png,X]
                (
                        >=media-video/mpv-0.15.0[libass,X]
                        >=net-misc/youtube-dl-2014.11.26
                )
        )
"
Which means I have to install youtube-dl if I want to use mpv and not mplayer as a backend. This should be changed so that youtube-dl is not a requirement to use mpv as a backend for smplayer (perhaps move youtube-dl to a useflag?).
Comment 1 Larry the Git Cow gentoo-dev 2019-03-03 19:12:13 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1007da21e7bac6634da052fb939054902dc456ab

commit 1007da21e7bac6634da052fb939054902dc456ab
Author:     William Breathitt Gray <vilhelm.gray@gmail.com>
AuthorDate: 2019-03-03 01:51:55 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2019-03-03 19:12:05 +0000

    media-video/smplayer: Remove youtube-dl runtime dependency
    
    The net-misc/youtube-dl package is not a required dependency to use
    media-video/mpv as a backend for smplayer. This patch removes the
    net-misc/youtube-dl package RDEPEND line and adds an informative
    pkg_postinst message instead to advise the user to install the
    net-misc/youtube-dl package for URL support.
    
    Closes: https://bugs.gentoo.org/649184
    Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/11223
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 media-video/smplayer/smplayer-19.1.0-r1.ebuild | 134 +++++++++++++++++++++++++
 1 file changed, 134 insertions(+)