Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 648838 - sci-geosciences/josm-99999 - logo.png has been replaced with logo.svg
Summary: sci-geosciences/josm-99999 - logo.png has been replaced with logo.svg
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Sci-geo Project
URL:
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks:
 
Reported: 2018-02-26 10:55 UTC by INODE64 Sistemas
Modified: 2021-08-29 22:46 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Just an proposed patch for the icon(s) in e.g. r15155... (josm-99999-icons.patch,826 bytes, patch)
2019-07-02 20:11 UTC, David Haller
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description INODE64 Sistemas 2018-02-26 10:55:06 UTC
After few days logo.png was change to logo.svg

Reproducible: Always
Comment 1 INODE64 Sistemas 2018-02-26 10:55:28 UTC
The patch

--- josm-99999.ebuild.old       2017-02-28 20:50:50.000000000 +0100                                                                                                                                                
+++ josm-99999.ebuild   2018-02-26 11:51:29.183919012 +0100                                                                                                                                                        
@@ -45,6 +45,6 @@                                                                                                                                                                                                  
        java-pkg_newjar "dist/${PN}-custom-optimized.jar" "${PN}.jar" || die "java-pkg_newjar failed"                                                                                                              
        java-pkg_dolauncher "${PN}" --jar "${PN}.jar" || die "java-pkg_dolauncher failed"                                                                                                                          
                                                                                                                                                                                                                   
-       newicon images/logo.png josm.png || die "newicon failed"                                                                                                                                                   
+       newicon images/logo.svg josm.svg || die "newicon failed"                                                                                                                                                   
        make_desktop_entry "${PN}" "Java OpenStreetMap Editor" josm "Utility;Science;Geoscience"                                                                                                                   
 }
Comment 2 silver_ghost 2018-08-11 01:38:24 UTC
Up.
Comment 3 silver_ghost 2018-10-21 03:00:59 UTC
bump
Comment 4 silver_ghost 2018-11-02 23:43:52 UTC
ping
Comment 5 David Haller 2019-07-02 20:11:37 UTC
Created attachment 581816 [details, diff]
Just an proposed patch for the icon(s) in e.g. r15155...

With that patch, current stable (r15155) builds nicely, so if one would want to version bump the non-99999 ebuild ... ;)
Comment 6 silver_ghost 2019-07-17 14:37:07 UTC
Could you approve one of three proposed solutions, please?
Comment 7 Anton Lavrov 2019-10-11 14:32:22 UTC
Bump!

Just checked the patch attached here on a local overlay - it just works. Please merge it.
Comment 8 Henning Schild 2021-08-04 17:48:51 UTC
Note that "sci-geosciences/josm-bin" was recently added as a new package. Switching to it might just solve this one for some people, while others might not like -bin. Give it a try and maybe rant on -bin.
Comment 9 Larry the Git Cow gentoo-dev 2021-08-29 22:46:54 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6c32c60da84b778583aaf7227bc9f0b24b15e89d

commit 6c32c60da84b778583aaf7227bc9f0b24b15e89d
Author:     Guillaume Castagnino <casta@xwing.info>
AuthorDate: 2018-09-03 07:51:42 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2021-08-29 22:43:47 +0000

    sci-geosciences/josm: josm now uses a svg icon
    
    PR from the INODE64 Sistemas patch on gentoo bug #648838
    
    Closes: https://github.com/gentoo/gentoo/pull/9771
    Closes: https://bugs.gentoo.org/648838
    Package-Manager: Portage-2.3.48, Repoman-2.3.10
    Signed-off-by: Guillaume Castagnino <casta@xwing.info>
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 sci-geosciences/josm/josm-99999.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)