Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 648256 - =dev-python/git-review-1.26.0 stable request
Summary: =dev-python/git-review-1.26.0 stable request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Stabilization (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Matthew Thode ( prometheanfire )
URL: https://storyboard.openstack.org/#!/s...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-20 10:55 UTC by j.harbott
Modified: 2018-02-20 16:29 UTC (History)
0 users

See Also:
Package list:
=git-review-1.26.0
Runtime testing required: No


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description j.harbott 2018-02-20 10:55:41 UTC
The previous version, =git-review-1.25.0 is incompatible with git >=2.15 due to a command change in git, leading to an error like

$ git review -d '545783'                                  
Downloading refs/changes/83/545783/1 from gerrit                                                        
Cannot set upstream to remote branch                                      
The following command failed with exit code 128                           
    "git branch --set-upstream review/jens_harbott_frickler_/bug/1750121 gerrit/master"           
-----------------------                                                                          
fatal: the '--set-upstream' option is no longer supported. Please use '--track' or '--set-upstream-to' instead.
-----------------------

This is resolved in the latest version, so since =git-2.16.1 has been stabilized at least for some arches, git-review needs to follow in order to keep working.

See URL for upstream bug report.
Comment 1 Larry the Git Cow gentoo-dev 2018-02-20 16:29:26 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4b544439f44b4e12527393be71dbfb70e3478de5

commit 4b544439f44b4e12527393be71dbfb70e3478de5
Author:     Matthew Thode <prometheanfire@gentoo.org>
AuthorDate: 2018-02-20 16:23:35 +0000
Commit:     Matthew Thode <prometheanfire@gentoo.org>
CommitDate: 2018-02-20 16:29:10 +0000

    dev-python/git-review: 1.26.0 stable
    
    Closes: https://bugs.gentoo.org/648256
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 dev-python/git-review/Manifest                 |  2 --
 dev-python/git-review/git-review-1.24.ebuild   | 24 ---------------------
 dev-python/git-review/git-review-1.25.0.ebuild | 29 --------------------------
 dev-python/git-review/git-review-1.26.0.ebuild |  2 +-
 4 files changed, 1 insertion(+), 56 deletions(-)