Bug 647958 – www-servers/nginx-1.13.8-r1 - In file included from njs/njs_fs.c:24:0: njs/njs_fs.c: In function 'njs_fs_write_file_sync': njs/njs_error.h:24:5: error: 'flag.length' may be used uninitialized in this function [-Werror=maybe-uninitialized]

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Conrad Kostecki 2018-02-17 21:51:16 UTC]

x86_64-pc-linux-gnu-gcc -c -o build/njs_parser_expression.o \
        -D_GNU_SOURCE -pipe -fPIC -fvisibility=hidden -O -W -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wmissing-prototypes -Werror -g -march=silvermont -mfpmath=sse,387 -mtune=intel -O3 -fomit-frame-pointer -maes -malign-data=abi -mcx16 -mfxsr -mmmx -mmovbe -mpclmul -mpopcnt -mprfchw -mrdrnd -msahf -msse -msse2 -msse3 -mssse3 -msse4 -msse4.1 -msse4.2 -mtls-dialect=gnu2 -pipe -I/usr/include -Wno-deprecated-declarations -Inxt -Injs \
        njs/njs_parser_expression.c
x86_64-pc-linux-gnu-gcc -c -o build/njs_generator.o -D_GNU_SOURCE -pipe -fPIC -fvisibility=hidden -O -W -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wmissing-prototypes -Werror -g -march=silvermont -mfpmath=sse,387 -mtune=intel -O3 -fomit-frame-pointer -maes -malign-data=abi -mcx16 -mfxsr -mmmx -mmovbe -mpclmul -mpopcnt -mprfchw -mrdrnd -msahf -msse -msse2 -msse3 -mssse3 -msse4 -msse4.1 -msse4.2 -mtls-dialect=gnu2 -pipe -I/usr/include -Wno-deprecated-declarations \
        -Inxt -Injs \
        njs/njs_generator.c
x86_64-pc-linux-gnu-gcc -c -o build/njs_disassembler.o -D_GNU_SOURCE -pipe -fPIC -fvisibility=hidden -O -W -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wmissing-prototypes -Werror -g -march=silvermont -mfpmath=sse,387 -mtune=intel -O3 -fomit-frame-pointer -maes -malign-data=abi -mcx16 -mfxsr -mmmx -mmovbe -mpclmul -mpopcnt -mprfchw -mrdrnd -msahf -msse -msse2 -msse3 -mssse3 -msse4 -msse4.1 -msse4.2 -mtls-dialect=gnu2 -pipe -I/usr/include -Wno-deprecated-declarations \
        -Inxt -Injs \
        njs/njs_disassembler.c
In file included from njs/njs_fs.c:24:0:
njs/njs_fs.c: In function 'njs_fs_write_file_sync':
njs/njs_error.h:24:5: error: 'flag.length' may be used uninitialized in this function [-Werror=maybe-uninitialized]
     njs_exception_error_create(vm, NJS_OBJECT_TYPE_ERROR, fmt, __VA_ARGS__)
     ^~~~~~~~~~~~~~~~~~~~~~~~~~
njs/njs_fs.c:733:31: note: 'flag.length' was declared here
     nxt_str_t           data, flag, encoding;
                               ^~~~
In file included from njs/njs_fs.c:24:0:
njs/njs_fs.c: In function 'njs_fs_append_file_sync':
njs/njs_error.h:24:5: error: 'flag.length' may be used uninitialized in this function [-Werror=maybe-uninitialized]
     njs_exception_error_create(vm, NJS_OBJECT_TYPE_ERROR, fmt, __VA_ARGS__)
     ^~~~~~~~~~~~~~~~~~~~~~~~~~
njs/njs_fs.c:733:31: note: 'flag.length' was declared here
     nxt_str_t           data, flag, encoding;
                               ^~~~
cc1: all warnings being treated as errors
make[2]: *** [Makefile:324: build/njs_fs.o] Error 1
make[2]: Leaving directory '/var/tmp/portage/www-servers/nginx-1.13.8-r1/work/njs-0.1.15'
make[1]: *** [objs/Makefile:1905: /var/tmp/portage/www-servers/nginx-1.13.8-r1/work/njs-0.1.15/nginx/../build/libnjs.a] Error 2
make[1]: Leaving directory '/var/tmp/portage/www-servers/nginx-1.13.8-r1/work/nginx-1.13.8'
make: *** [Makefile:8: build] Error 2
 * ERROR: www-servers/nginx-1.13.8-r1::gentoo failed (compile phase):
 *   emake failed
 *
 * If you need support, post the output of `emerge --info '=www-servers/nginx-1.13.8-r1::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=www-servers/nginx-1.13.8-r1::gentoo'`.
 * The complete build log is located at '/var/tmp/portage/www-servers/nginx-1.13.8-r1/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/www-servers/nginx-1.13.8-r1/temp/environment'.
 * Working directory: '/var/tmp/portage/www-servers/nginx-1.13.8-r1/work/nginx-1.13.8'
 * S: '/var/tmp/portage/www-servers/nginx-1.13.8-r1/work/nginx-1.13.8'

[Comment 1 Conrad Kostecki 2018-02-17 21:51:33 UTC]

Portage 2.3.24 (python 3.6.4-final-0, default/linux/amd64/17.1, gcc-7.3.0, glibc-2.26-r6, 4.14.14-gentoo x86_64)
=================================================================
System uname: Linux-4.14.14-gentoo-x86_64-Intel-R-_Atom-TM-_CPU_C2758_@_2.40GHz-with-gentoo-2.4.1
KiB Swap:   36700156 total,  36700156 free
Timestamp of repository gentoo: Sat, 17 Feb 2018 14:45:01 +0000
Head commit of repository gentoo: e6572429168e1ee74dfec6b4849b308093254312
sh bash 4.4_p19
ld GNU ld (Gentoo 2.30 p1) 2.30.0
distcc 3.2rc1 x86_64-pc-linux-gnu [disabled]
ccache version 3.3.4 [enabled]
app-shells/bash:          4.4_p19::gentoo
dev-java/java-config:     2.2.0-r3::gentoo
dev-lang/perl:            5.26.1-r1::gentoo
dev-lang/python:          2.7.14-r1::gentoo, 3.5.4-r1::gentoo, 3.6.4::gentoo
dev-util/ccache:          3.3.4-r1::gentoo
dev-util/cmake:           3.10.2::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.4.1-r2::gentoo
sys-apps/openrc:          0.34.11::gentoo
sys-apps/sandbox:         2.12::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.11.6-r2::gentoo, 1.15.1-r1::gentoo
sys-devel/binutils:       2.30::gentoo
sys-devel/gcc:            7.3.0::gentoo
sys-devel/gcc-config:     1.9.1::gentoo
sys-devel/libtool:        2.4.6-r4::gentoo
sys-devel/make:           4.2.1-r1::gentoo
sys-kernel/linux-headers: 4.15::gentoo (virtual/os-headers)
sys-libs/glibc:           2.26-r6::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.de.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-metamanifest: yes
    sync-rsync-extra-opts: --exclude-from=/etc/portage/rsync_excludes

galactica
    location: /usr/local/portage
    masters: gentoo

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=silvermont -mfpmath=sse,387 -mtune=intel -O3 -fomit-frame-pointer -maes -malign-data=abi -mcx16 -mfxsr -mmmx -mmovbe -mpclmul -mpopcnt -mprfchw -mrdrnd -msahf -msse -msse2 -msse3 -mssse3 -msse4 -msse4.1 -msse4.2 -mtls-dialect=gnu2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /etc/stunnel/stunnel.conf /usr/share/gnupg/qualified.txt /var/lib/fhem /var/lib/pyload /var/lib/slimserver/prefs /var/lib/unifi/data/system.properties"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php7.2/ext-active/ /etc/php/cgi-php7.2/ext-active/ /etc/php/cli-php7.2/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/splash /etc/terminfo"
CXXFLAGS="-march=silvermont -mfpmath=sse,387 -mtune=intel -O3 -fomit-frame-pointer -maes -malign-data=abi -mcx16 -mfxsr -mmmx -mmovbe -mpclmul -mpopcnt -mprfchw -mrdrnd -msahf -msse -msse2 -msse3 -mssse3 -msse4 -msse4.1 -msse4.2 -mtls-dialect=gnu2 -pipe -fvisibility-inlines-hidden"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--autounmask=n --quiet-build=n --with-bdeps=y"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs ccache config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync multilib-strict news parallel-fetch protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://mirror.netcologne.de/gentoo/"
INSTALL_MASK="/etc/systemd/* /etc/xinetd.d/* /usr/lib/systemd/system/*"
LANG="de_DE.UTF-8"
LC_ALL="de_DE.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--sort-common -Wl,-z,now"
LINGUAS="de de_DE"
MAKEOPTS="-j9 -l8"
PKGDIR="/usr/portage/packages"
PORTAGE_BUNZIP2_COMMAND="pbunzip2"
PORTAGE_BZIP2_COMMAND="pbzip2"
PORTAGE_COMPRESS="xz"
PORTAGE_COMPRESS_FLAGS="-9e"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_EXTRA_OPTS="--exclude-from=/etc/portage/rsync_excludes"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X aac acl alsa amd64 bcmath berkdb bzip2 cairo caps cddb cgi cjk cracklib crypt ctype curl cvs cxx dbus dga djvu encode exif fbcon ffmpeg fftw flite fontconfig ftp gd gif git gmp gnutls gphoto2 gpm graphviz gsm hddtemp iconv icu idn imlib inotify introspection ipv6 javascript jbig jit jpeg jpeg2k lcms ldap libcaca libnotify libsamplerate libv4l lm_sensors lzma lzo maildir mbox mhash mikmod mime mmap mng modplug mp3 mysql mysqli ncurses nls nntp nptl offensive ogg openal opencl openexr opengl openmp orc oss pam pcre pdf perl pie png policykit posix postproc postscript pulseaudio python raw readline rtmp samba scanner sdl seccomp session simplexml slang sndfile sockets sound speex spell sqlite ssl subversion suid svg symlink syslog tcpd theora threads tiff truetype udev unicode usb v4l vaapi vdpau vhosts vim-syntax vorbis wavpack webp wmf x264 xattr xcb xface xft xml xmlrpc xmp xpm xscreensaver xvid zeroconf zlib zsh-completion" ABI_X86="32 64" COLLECTD_PLUGINS="apcups cgroups conntrack contextswitch cpu cpusleep df disk dns entropy ethstat exec filecount hddtemp hugepages interface ipc iptables ipmi irq load lvm md memory mysql netlink nfs nginx ntpd openvpn ping processes protocols rrdcached sensors serial smart swap syslog tcpconns thermal turbostat unixsock uptime users" CPU_FLAGS_X86="aes mmx mmxext sse sse2 sse3 ssse3 sse4_1 sse4_2" CURL_SSL="openssl" ELIBC="glibc" INPUT_DEVICES="libinput" KERNEL="linux" L10N="de de_DE" LCD_DEVICES="crystalfontz glcd2usb lcd2usb" NGINX_MODULES_HTTP="access auth_basic autoindex brotli browser charset fancyindex fastcgi geo geoip gunzip gzip headers_more limit_conn javascript proxy realip referer rewrite sticky stub_status upstream_keepalive vhost_traffic_status" NGINX_MODULES_STREAM="access geo geoip javascript limit_conn realip return ssl_preread" PHP_TARGETS="php7-2" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_6" USERLAND="GNU" VIDEO_CARDS="ast fbdev"
Unset:  CC, CPPFLAGS, CTARGET, CXX

[Comment 2 Conrad Kostecki 2018-02-17 21:52:12 UTC]

Created attachment 519904 [details]
build.log

[Comment 3 Conrad Kostecki 2018-02-17 22:23:15 UTC]

Seems to be a -O3 problem, fixed by upstream:
http://hg.nginx.org/njs/rev/22cc52416e84

After applying this one, it works for me.

But there is no new release..

[Comment 4 Larry the Git Cow 2018-02-18 16:05:20 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=da7d02ca95226161605c105a07d3d341fcb6477e

commit da7d02ca95226161605c105a07d3d341fcb6477e
Author:     Thomas Deutschmann <[e-mail]>
AuthorDate: 2018-02-18 16:04:41 +0000
Commit:     Thomas Deutschmann <[e-mail]>
CommitDate: 2018-02-18 16:05:12 +0000

    www-servers/nginx: Fix building of nginScript with -O3
    
    Closes: https://bugs.gentoo.org/647958
    Package-Manager: Portage-2.3.24, Repoman-2.3.6

 .../nginx/files/njs-0.1.15-fix-o3-building.patch   | 24 ++++++++++++++++++++++
 www-servers/nginx/nginx-1.13.8-r1.ebuild           | 10 +++++++--
 2 files changed, 32 insertions(+), 2 deletions(-)