Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 647864 - sci-geosciences/qgis-2.18.14 stabilisation (was: sci-geosciences/qgis-2.18.12 with dev-python/sip-4.19.3 - YES?)
Summary: sci-geosciences/qgis-2.18.14 stabilisation (was: sci-geosciences/qgis-2.18.12...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Stabilization (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sci-geo Project
URL:
Whiteboard:
Keywords:
Depends on: 648132
Blocks:
  Show dependency tree
 
Reported: 2018-02-16 15:33 UTC by vonabarak
Modified: 2018-03-30 16:52 UTC (History)
1 user (show)

See Also:
Package list:
sci-geosciences/qgis-2.18.14
Runtime testing required: ---
stable-bot: sanity-check+


Attachments
Patch from debian's bugtracker (remove-sip-workaround.patch,345 bytes, patch)
2018-02-16 15:33 UTC, vonabarak
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description vonabarak 2018-02-16 15:33:29 UTC
Created attachment 519714 [details, diff]
Patch from debian's bugtracker

sci-geosciences/qgis-2.18.12 fails to build with dev-python/sip-4.19.3
With previous versions of dev-python/sip builds fine.
Related bug in debian's bugtracker: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=872640
Patch from debian's bugtracker resolves this bug (in attachment)
Comment 1 Andreas Sturmlechner gentoo-dev 2018-02-16 18:35:55 UTC
Can you test with 2.18.14?
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2018-02-16 23:48:12 UTC
What is the actual problem? Please describe that in the Summary so everyone can know.
Comment 3 Dion Moult 2018-02-18 20:03:30 UTC
I am able to replicate this issue. Patch works. I'm copying and pasting the summary from the Debian bug report for convenience.

> qgis fails to build with sip 4.19.3 and python-qt4 4.12.1, both of which
> are available in experimental:
> 
>   /build/qgis-2.14.17+dfsg/debian/build/python/core/sip_corepart0.cpp:15288:40:
>           error: conflicting declaration ‘PyObject* sipExportedExceptions__core [3]’
>   /build/qgis-2.14.17+dfsg/python/core/qgscoordinatetransform.sip:18:18:
>           note: previous declaration as ‘PyObject* sipExportedExceptions__core [2]’
>    extern PyObject *sipExportedExceptions__core[2];  // workaround: sipExportedExceptions__core is only defined in the first sip part
>                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> The reason is that since sip 4.19.3, the sipExportedExceptions arrays
> always have a NULL pointer as a trailing member, so size of this particular
> array is 2 with sip 4.19.2 and 3 with sip 4.19.3.
> 
> https://riverbankcomputing.com/hg/sip/rev/974a4d77314b#l1.14
> 
> I am attaching a patch to remove this workaround line completely. It fixes
> build with sip 4.19.3 for me and does not affect build with sip 4.18.1.
> (I do not know why upstream needed this workaround.)

Also just confirming that this sip behaviour persists in later / unstable versions of sip, so the patch really is required.
Comment 4 Andreas Sturmlechner gentoo-dev 2018-02-18 21:48:41 UTC
The question was if you can reproduce the problem with qgis-2.18.14, please.
Comment 5 Andreas Sturmlechner gentoo-dev 2018-02-19 09:54:10 UTC
In tree for long enough, arches, please stabilise.
Comment 6 Thomas Deutschmann (RETIRED) gentoo-dev 2018-02-19 16:49:41 UTC
x86 stopped stabilization due to bug 648132.
Comment 7 Aaron Bauman (RETIRED) gentoo-dev 2018-03-30 16:07:14 UTC
Please CC arches when fixed.
Comment 8 Larry the Git Cow gentoo-dev 2018-03-30 16:52:02 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0a2e8183a0b23aefe1818b9384e95fb4881f0a33

commit 0a2e8183a0b23aefe1818b9384e95fb4881f0a33
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-03-30 16:48:54 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-03-30 16:51:48 +0000

    sci-geosciences/qgis: Drop 2.8.14, aborting stabilisation
    
    Closes: https://bugs.gentoo.org/647864
    Closes: https://bugs.gentoo.org/648132
    Closes: https://bugs.gentoo.org/641406
    Package-Manager: Portage-2.3.27, Repoman-2.3.9

 sci-geosciences/qgis/Manifest            |   1 -
 sci-geosciences/qgis/qgis-2.18.14.ebuild | 207 -------------------------------
 2 files changed, 208 deletions(-)