gnome USE flag is simply adding a requirement on gnome-base/libgnomeui, that is a completely deprecated, dead and obsolete lib that we will need to kill soon. Maybe this optional support could be dropped then Thanks a lot
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b72c974e746022f83a229dc76f6e5dc719d8bfbb commit b72c974e746022f83a229dc76f6e5dc719d8bfbb Author: Patrice Clement <monsieurp@gentoo.org> AuthorDate: 2018-05-12 21:07:48 +0000 Commit: Patrice Clement <monsieurp@gentoo.org> CommitDate: 2018-05-12 21:09:53 +0000 app-editors/gvim: remove libgnomeui dependency. Bug: https://bugs.gentoo.org/647602 Package-Manager: Portage-2.3.24, Repoman-2.3.6 app-editors/gvim/gvim-8.0.1699-r1.ebuild | 372 +++++++++++++++++++++++++++++++ 1 file changed, 372 insertions(+)
Hey Pacho Can you please double check? I've remove the dependency as you suggested. Thanks.
Are you sure if just disabling libgnomeui like that is OK? Will it not be automagic then or still fail with USE="gnome gtk -gtk3" as you still pass --enable-gui=gnome2 then? I tried to read src/configure.ac, but rather complicated handling there and taking more time than I have right now to find out without testing (and actually having libgnomeui installed temporarily for a test of automagic usage of it or not). I also am not fond of the IUSE=gtk3 abuse that gvim is doing. See https://wiki.gentoo.org/wiki/Project:GNOME/Gnome_Team_Ebuild_Policies#GTK.2B_USE-flag_and_slots_usage USE=gtk3 should only be used for cases where it's about _additional_ support for gtk3, e.g. installing a gtk3 input method module, or printer backend, etc. Not choosing gtk3 usage instead of gtk2 for an end-user application. I would suggest to just completely drop gtk2 support, as gtk3 is clearly the preferred one per upstream preference that is even described in the ebuild. If not, then using USE=gtk2 to use the deprecated gtk2 instead of gtk3 would be more acceptable to gnome team than the vice-versa you have now.
(In reply to Patrice Clement from comment #2) > Hey Pacho > > Can you please double check? I've remove the dependency as you suggested. > Thanks. Hi! No, now the dependency is automagic, if libgnomeui is present in the system and you build with USE="gtk -gtk3" it will link to it still To prevent the automagic linking, --with-gnome=no needs to be passed I also agree with changing the logic to: - drop "gnome" USE - Make "gtk" enable GTK3 support - I wouldn't allow gtk2, but if people are really against that, I would put it under gtk2 USE Thanks
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=23da79bd9b80d2e092e0210cd3e22b1845470014 commit 23da79bd9b80d2e092e0210cd3e22b1845470014 Author: Tim Harder <radhermit@gentoo.org> AuthorDate: 2019-04-12 05:58:16 +0000 Commit: Tim Harder <radhermit@gentoo.org> CommitDate: 2019-04-12 06:10:32 +0000 app-editors/gvim: version bump to 8.1.1155 Drop gnome USE flag, disable support, and rename gtk USE flags, now gtk enables gtk3 support while gtk2 enables the older gtk2-based UI. Closes: https://bugs.gentoo.org/647602 Restrict tests until various failures are skipped and/or resolved. Signed-off-by: Tim Harder <radhermit@gentoo.org> app-editors/gvim/Manifest | 1 + app-editors/gvim/gvim-8.1.1155.ebuild | 370 ++++++++++++++++++++++++++++++++++ app-editors/gvim/gvim-9999.ebuild | 45 ++--- app-editors/gvim/metadata.xml | 1 + 4 files changed, 393 insertions(+), 24 deletions(-)
Thanks!
