Bug 647088 – app-admin/system-config-printer version bump to 1.5.11

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Drunkard Zhang 2018-02-09 06:39:05 UTC]

This is app-admin/system-config-printer version bump request, 1.5.x released, and my test ebuild works for me.

Reproducible: Always

[Comment 1 Drunkard Zhang 2018-02-09 06:44:15 UTC]

Created attachment 518716 [details, diff]
ebuild file

My test passed.

[Comment 2 Jonas Stein 2018-02-09 16:41:40 UTC]

Thank you for your contribution. I had a short look on the ebuild. 
Here a few ideas:

* Please test the ebuild with repoman full -x https://wiki.gentoo.org/wiki/Repoman

>> KEYWORDS="~alpha amd64 ~arm ~arm64 ~ia64 ppc ppc64 ~sh ~sparc x86"

* KEYWORDS need ~ after a version bump run ekeyword ~all YOUREBUILD
* We usually sort the KEYWORDS as ekeywords does. This makes comparison between packages easier. Simply run ekeywords on the ebuild to let it sort.

Is this still required? Bug #471472
MAKEOPTS+=" -j1"

[Comment 3 Drunkard Zhang 2018-02-10 14:32:14 UTC]

(In reply to Jonas Stein from comment #2)
> Thank you for your contribution. I had a short look on the ebuild. 
> Here a few ideas:
> 
> * Please test the ebuild with repoman full -x
> https://wiki.gentoo.org/wiki/Repoman
> 
> >> KEYWORDS="~alpha amd64 ~arm ~arm64 ~ia64 ppc ppc64 ~sh ~sparc x86"
> 
> * KEYWORDS need ~ after a version bump run ekeyword ~all YOUREBUILD
> * We usually sort the KEYWORDS as ekeywords does. This makes comparison
> between packages easier. Simply run ekeywords on the ebuild to let it sort.
> 
> Is this still required? Bug #471472
> MAKEOPTS+=" -j1"
Build with "-j8" passed.

It seems that app-admin/system-config-printer-1.5.11 supports only python3.
And USE=doc depends on dev-python/epydoc, which only needs the epydoc binary command, restricting of PYTHON_USEDEP is not necessary.

Fixed following your advice, thank you very much.

[Comment 4 Drunkard Zhang 2018-02-10 14:38:29 UTC]

Created attachment 518950 [details, diff]
Fullly tested ebuild

[Comment 5 poncho 2018-03-21 11:00:58 UTC]

I had a quick look at the ebuild as well and would recommend the following changes:


You should update the gnome-keyring useflag to depend on app-crypt/libsecret[introspection]

see: "use libsecret instead of libgnome-keyring"
https://github.com/zdohnal/system-config-printer/pull/67


http://cyberelk.net/tim/software/system-config-printer/ mentions:

"Please note that I no longer maintain system-config-printer. Please visit its new home at GitHub."

Therefore, I'd update the HOMEPAGE variable to:
https://github.com/zdohnal/system-config-printer

[Comment 6 Joakim Tjernlund 2018-09-04 15:01:42 UTC]

Yes please, the current version is getting very old.

[Comment 7 Drunkard Zhang 2018-09-08 04:39:20 UTC]

Created attachment 546230 [details]
updated according to poncho's advice

system-config-printer-1.5.11.ebuild updated according to poncho's advice, thank you very much for pointing that.

[Comment 8 Larry the Git Cow 2018-10-14 09:04:56 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=276c9e74df77bdb8ed9073c13682d54b18d63d54

commit 276c9e74df77bdb8ed9073c13682d54b18d63d54
Author:     Andreas Sturmlechner <[e-mail]>
AuthorDate: 2018-10-14 07:45:07 +0000
Commit:     Andreas Sturmlechner <[e-mail]>
CommitDate: 2018-10-14 09:04:43 +0000

    app-admin/system-config-printer: 1.5.11 version bump, EAPI-6 bump
    
    Switch to new HOMEPAGE.
    Switch to python3.
    Switch to gnome-base/libgnome-keyring.
    Fix license, drop LINGUAS hack.
    
    Closes: https://bugs.gentoo.org/647088
    
    Thanks-to: poncho <[e-mail]>
    Thanks-to: Drunkard Zhang <[e-mail]>
    Thanks-to: Mart Raudsepp <[e-mail]>
    Signed-off-by: Andreas Sturmlechner <[e-mail]>
    Package-Manager: Portage-2.3.51, Repoman-2.3.11

 app-admin/system-config-printer/Manifest           |  2 +
 .../system-config-printer-1.5.11.ebuild            | 89 ++++++++++++++++++++++
 2 files changed, 91 insertions(+)