Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 646902 - qt5-build.eclass: fix failing newins commands in qt5_install_module_config()
Summary: qt5-build.eclass: fix failing newins commands in qt5_install_module_config()
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords: PATCH
: 647844 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-02-07 15:00 UTC by hsk17
Modified: 2018-02-20 23:42 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
patch to qt5-build.eclass fixing arguments to newins (qt5-build.eclass.patch,616 bytes, patch)
2018-02-07 15:00 UTC, hsk17 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description hsk17 2018-02-07 15:00:18 UTC 
Created attachment 518362 [details, diff]
patch to qt5-build.eclass fixing arguments to newins

the newins commands in qt5_install_module_config() that were added recently to qt5-build.eclass, fail in a prefix installation ("file does not exist").  the first argument of the newins should be "${QT5_ARCHDATADIR}"/.... instead of "${D}${QT5_ARCHDATADIR#${EPREFIX}}"/....

see attached patch.
Comment 1 Davide Pesavento (RETIRED) gentoo-dev 2018-02-07 15:42:44 UTC 
Thanks for your report.

The patch doesn't look right though. The correct fix is using

  "${D}${QT5_ARCHDATADIR}"

instead of

  "${D}${QT5_ARCHDATADIR#${EPREFIX}}"
Comment 2 Larry the Git Cow gentoo-dev 2018-02-09 23:19:23 UTC 
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/qt.git/commit/?id=92b7e6c8b72ded7e357353209254a42a08b20ad0

commit 92b7e6c8b72ded7e357353209254a42a08b20ad0
Author:     Michael Palimaka <kensington@gentoo.org>
AuthorDate: 2018-02-09 23:18:58 +0000
Commit:     Michael Palimaka <kensington@gentoo.org>
CommitDate: 2018-02-09 23:19:05 +0000

    qt5-build.eclass: fix install on prefix
    
    Bug: https://bugs.gentoo.org/646902

 eclass/qt5-build.eclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)}
Comment 3 Michael Palimaka (kensington) gentoo-dev 2018-02-16 10:39:19 UTC 
*** Bug 647844 has been marked as a duplicate of this bug. ***
Comment 4 hsk17 2018-02-19 16:38:32 UTC 
thanks for your fix.
how long should it take, that this fix shows up in gentoo's /usr/portage/eclass/qt5build.eclass ?   i.e., in https://gitweb.gentoo.org/repo/gentoo.git/tree/eclass/qt5-build.eclass