Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 646570 - dev-libs/pigpio - a library for the Raspberry which allows control of the General Purpose Input Outputs (GPIO)
Summary: dev-libs/pigpio - a library for the Raspberry which allows control of the Gen...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Default Assignee for New Packages
URL: http://abyz.me.uk/rpi/pigpio/index.html
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-04 11:29 UTC by Daniel Kenzelmann
Modified: 2018-03-23 22:11 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
pigpio.tar.gz (pigpio.tar.gz,2.95 KB, application/gzip-compressed-tar)
2018-02-04 11:30 UTC, Daniel Kenzelmann
Details
pigpio-9999.ebuild (pigpio-9999.ebuild,1.17 KB, text/plain)
2018-02-10 10:03 UTC, Daniel Kenzelmann
Details
pigpio-66.ebuild (pigpio-66.tar.gz,1.85 KB, application/gzip)
2018-02-25 17:01 UTC, Daniel Kenzelmann
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Kenzelmann 2018-02-04 11:29:39 UTC
Trying to submit a new ebuild for the pigpio library..
Created pull request https://github.com/gentoo/gentoo/pull/7053

however it mentioned that I should add the bug to the commit message (can you really do that after it has been committed?)

So I'll just attach the ebuild and files here.

Regarding the pull request, do I have to send that again?

Reproducible: Always
Comment 1 Daniel Kenzelmann 2018-02-04 11:30:25 UTC
Created attachment 517770 [details]
pigpio.tar.gz
Comment 2 Daniel Kenzelmann 2018-02-10 10:03:19 UTC
Created attachment 518938 [details]
pigpio-9999.ebuild

sysmacros patch no longer needed, fixed by upstream
Comment 3 jannis 2018-02-25 13:59:46 UTC
Thank you very much for your work! I was able to persuade the developer to tag releases in git (https://github.com/joan2937/pigpio/issues/199) so we more easily have ebuilds for "released version" of pigpio.
I used your ebuild as a base but with release V66 (remove git eclass and use "https://github.com/joan2937/pigpio/archive/V${PV}.tar.gz" as SRC_URI).
I'd love to see this in the official tree
Comment 4 jannis 2018-02-25 14:19:23 UTC
Oh, what I just realized: The ebuild installs the library but no header files.... Is this intentional?
Will investigate later
Comment 5 Daniel Kenzelmann 2018-02-25 16:13:59 UTC
I think that was just an oversight ...
(I personally only needed pigs for my raspberry, thus didn't really look into the libraries etc and just missed to install them .. i think because there was no "default" way to install them like with "dolib.so")
And I'm not really an expert in creating ebuilds ..

If i were to write it I would just add

        insinto /usr/include/
        doins pigpio.h
        doins pigpiod_if.h
        doins pigpiod_if2.h

after the libraries, but I'm not sure if that is the correct way to do it (does this ensure permissions/ownership?, is there maybe a better way to get/specify the include dir?)
Comment 6 Daniel Kenzelmann 2018-02-25 17:01:44 UTC
Created attachment 521036 [details]
pigpio-66.ebuild
Comment 7 Daniel Kenzelmann 2018-02-25 17:04:33 UTC
Argh,.. I think the flu got me a bit ... the last attached file is a tar.gz file not an ebuild file (containing all the ebuild files for v66)
- Installs header files
- Installs systemd file

Maybe next week or when I feel better I can delete the whole borked up pull request and create a new one (this time correctly).
In the mean time feel free to use the attached files if needed :-)
-> or create a pull request yourself based on the files
Comment 8 jannis 2018-02-25 17:56:41 UTC
Wow, that was a quick fix. I can confirm that the new ebuild also installs header files :D
Comment 9 Larry the Git Cow gentoo-dev 2018-03-23 22:11:36 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cd447c2a8620458f170d749eaebc5f02f05c2fbc

commit cd447c2a8620458f170d749eaebc5f02f05c2fbc
Author:     Daniel Kenzelmann <gentoo@k8n.de>
AuthorDate: 2018-03-17 13:00:48 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-03-23 22:10:04 +0000

    dev-libs/pigpio: initial pull request (v67)
    
    This is a new ebuild for the pigpio library
    ( http://abyz.me.uk/rpi/pigpio/ )
    Supports systemd and openrc start files and also optional python support
    currently needed Makefile patches will be reported/requested upstream
    
    Closes: https://bugs.gentoo.org/646570
    Closes: https://github.com/gentoo/gentoo/pull/7484

 dev-libs/pigpio/Manifest                       |  1 +
 dev-libs/pigpio/files/pigpio-67-makefile.patch | 64 ++++++++++++++++++++++++++
 dev-libs/pigpio/files/pigpiod.confd            |  4 ++
 dev-libs/pigpio/files/pigpiod.initd            |  7 +++
 dev-libs/pigpio/files/pigpiod.systemd          |  9 ++++
 dev-libs/pigpio/metadata.xml                   | 12 +++++
 dev-libs/pigpio/pigpio-67.ebuild               | 40 ++++++++++++++++
 7 files changed, 137 insertions(+)