Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 646262 - =app-admin/rsyslog-8.32.0-r1 without net-misc/curl fails to build
Summary: =app-admin/rsyslog-8.32.0-r1 without net-misc/curl fails to build
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Thomas Deutschmann (RETIRED)
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2018-02-01 03:14 UTC by Maxim Britov
Modified: 2018-02-09 23:21 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for remove include curl.h for builds with useflag -curl (nocurl2.patch,1.39 KB, patch)
2018-02-01 03:16 UTC, Maxim Britov
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maxim Britov 2018-02-01 03:14:38 UTC
With USE='-curl' and without net-misc/curl installed app-admin/rsyslog-8.32.0-r1 wont buil.
Patch rsyslog-8.32.0-fix-building-without-curl-r1.patch doesn't remove include curl.h and it fails on this ones.
I build rsyslog with additional patch: attached

Reproducible: Always
Comment 1 Maxim Britov 2018-02-01 03:16:33 UTC
Created attachment 517332 [details, diff]
Patch for remove include curl.h for builds with useflag -curl
Comment 2 Larry the Git Cow gentoo-dev 2018-02-09 14:26:14 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e49658404784a043f47f3d9dcb27938b244d33cb

commit e49658404784a043f47f3d9dcb27938b244d33cb
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2018-02-09 14:25:29 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2018-02-09 14:25:29 +0000

    app-admin/rsyslog: Fix building without net-misc/curl
    
    Closes: https://bugs.gentoo.org/646262
    Package-Manager: Portage-2.3.24, Repoman-2.3.6
    RepoMan-Options: --force

 ...slog-8.32.0-fix-building-without-curl-r2.patch} | 61 +++++++++++++++++-----
 ...g-8.32.0-r1.ebuild => rsyslog-8.32.0-r2.ebuild} |  2 +-
 2 files changed, 48 insertions(+), 15 deletions(-)
Comment 3 Maxim Britov 2018-02-09 18:34:18 UTC
Hmm... Nothing new, -r2 still fail to build.

libtool: compile:  x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -I../runtime -I.. -I../grammar -I/usr/include/libfastjson -W -Wall -Wformat-security -Wshadow -Wcast-align -Wpointer-arith -Wmissing-format-attribute -Werror=implicit-function-declaration -fno-strict-aliasing -Wall -Wextra -Wundef -Wnested-externs -Wwrite-strings -Wpointer-arith -Wmissing-declarations -Wmissing-prototypes -Wstrict-prototypes -Wredundant-decls -Wno-unused-parameter -Wno-missing-field-initializers -Wdeclaration-after-statement -Wformat=2 -Wold-style-definition -Wcast-align -Wformat-nonliteral -Wformat-security -Wsign-compare -Wstrict-aliasing -Wshadow -Winline -Wpacked -Wmissing-format-attribute -Wmissing-noreturn -Winit-self -Wmissing-include-dirs -Wunused-but-set-variable -Warray-bounds -Wimplicit-function-declaration -Wreturn-type -Wswitch-enum -Wswitch-default -Wno-error=unused-parameter -Wno-error=missing-field-initializers -O2 -march=native -pipe -c rainerscript.c  -fPIC -DPIC -o .libs/libgrammar_la-rainerscript.o
rainerscript.c:39:23: fatal error: curl/curl.h: No such file or directory
 #include <curl/curl.h>
                       ^
compilation terminated.
make[3]: *** [Makefile:528: libgrammar_la-rainerscript.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory '/var/tmp/portage/app-admin/rsyslog-8.32.0-r2/work/rsyslog-8.32.0/grammar'
make[2]: *** [Makefile:424: all] Error 2
make[2]: Leaving directory '/var/tmp/portage/app-admin/rsyslog-8.32.0-r2/work/rsyslog-8.32.0/grammar'
make[1]: *** [Makefile:812: all-recursive] Error 1
make[1]: Leaving directory '/var/tmp/portage/app-admin/rsyslog-8.32.0-r2/work/rsyslog-8.32.0'
make: *** [Makefile:639: all] Error 2
Comment 4 Thomas Deutschmann (RETIRED) gentoo-dev 2018-02-09 23:14:51 UTC
Indeed, we missed the header include. Thank you.
Comment 5 Larry the Git Cow gentoo-dev 2018-02-09 23:21:36 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cd2e1aa22d7d3e899a09d74030bc785fac170d53

commit cd2e1aa22d7d3e899a09d74030bc785fac170d53
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2018-02-09 23:16:41 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2018-02-09 23:21:26 +0000

    app-admin/rsyslog: Fix building without net-misc/curl
    
    Previous patch was incomplete and missed a header include.
    
    Closes: https://bugs.gentoo.org/646262
    Package-Manager: Portage-2.3.24, Repoman-2.3.6
    RepoMan-Options: --force

 ...h => rsyslog-8.32.0-fix-building-without-curl-r3.patch} | 14 ++++++++++++++
 .../{rsyslog-8.32.0-r2.ebuild => rsyslog-8.32.0-r3.ebuild} |  2 +-
 2 files changed, 15 insertions(+), 1 deletion(-)