Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 645918 - net-im/slack-bin-3.0.2 missing appindicator support
Summary: net-im/slack-bin-3.0.2 missing appindicator support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Vladimir Pavljuchenkov (SpiderX)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 626846
  Show dependency tree
 
Reported: 2018-01-27 21:45 UTC by Simon
Modified: 2018-02-09 09:33 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Simon 2018-01-27 21:45:46 UTC
net-im/slack-bin-3.0.2 is missing appindicator support, which means no "tray" icon on appindicator supporting DE's.
There's already an "appindicator" USE flag used by other applications, we can use that to depend on the required dev-libs/libappindicator:2?

Only question/issue I have is that for GNOME with gnome-shell-extension-appindicator it still won't work after this change because Electron checks XDG_CURRENT_DESKTOP and doesn't use appindicator support on GNOME. See https://github.com/Ubuntu/gnome-shell-extension-appindicator/issues/74

I've fixed that locally for now by patching /usr/share/applications/slack.desktop so the Exec line reads "Exec=env XDG_CURRENT_DESKTOP=Unity /usr/bin/slack --disable-gpu %U".
Any idea how we could properly address this?
Comment 1 Simon 2018-02-02 08:56:11 UTC
Apparently the global USE flag for appindicator is called "ayatana" :?
So that should probably be used instead of "appindicator" as I wrote before.
Comment 2 Vladimir Pavljuchenkov (SpiderX) 2018-02-03 08:17:41 UTC
Simon, could you test ebuild for slack 3.0.5 from https://github.com/SpiderX/portage-overlay/tree/master/net-im/slack-bin ?
Does it resolve this problem?
Comment 3 Simon 2018-02-04 11:25:06 UTC
@Vladimir

AFAIK it should depend on libappindicator:2 and not libappindicator:3 since it's a gtk2 app.
I've emerged libappindicator:2 manually and that makes it work.
Have you tested libappindicator:3 works (without having libappindicator:2 installed)?
Comment 4 Vladimir Pavljuchenkov (SpiderX) 2018-02-04 11:49:24 UTC
> since it's a gtk2 app.

It sounds reasonable.
I changed commit.
Thanks.
Comment 5 Larry the Git Cow gentoo-dev 2018-02-09 09:33:01 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0be003699372b4da0912aa7a6ab97ec9d03b65e7

commit 0be003699372b4da0912aa7a6ab97ec9d03b65e7
Author:     Vladimir Pavljuchenkov (SpiderX) <spiderx@spiderx.dp.ua>
AuthorDate: 2018-02-06 16:32:38 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-02-09 09:32:43 +0000

    net-im/slack-bin: fix 645918 (support for ayatana)
    
    Closes: https://bugs.gentoo.org/645918
    Closes: https://github.com/gentoo/gentoo/pull/7051
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 net-im/slack-bin/slack-bin-3.0.5.ebuild | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)