Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 645900 - sys-fs/udisks:2 should not warn if CONFIG_SWAP=y is not set
Summary: sys-fs/udisks:2 should not warn if CONFIG_SWAP=y is not set
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Freedesktop bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-27 16:28 UTC by Michael Yagliyan
Modified: 2018-01-27 18:00 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Yagliyan 2018-01-27 16:28:03 UTC
I don't have CONFIG_SWAP enabled in my kernel, and every time I emerge udisks:2 I get a warning about it not being set.  I've never have a problem with it, so I started looking into this.  It looks like the warning was added to the ebuilds back in May 2012 as a result of this forum thread:
https://forums.gentoo.org/viewtopic-t-923640.html
Indeed the ebuilds contain a comment pointing to that thread.

However it seems shortly thereafter (October 2012), the upstream code was changed to no longer require CONFIG_SWAP as of version 2.0.0:
https://bugs.freedesktop.org/show_bug.cgi?id=50142
https://github.com/storaged-project/udisks/blob/master/NEWS

Please remove the warning about CONFIG_SWAP from the udisks:2 ebuilds.
Comment 1 Larry the Git Cow gentoo-dev 2018-01-27 18:00:47 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=90a980ae938943cdaff26a0daeb32cef11ed2133

commit 90a980ae938943cdaff26a0daeb32cef11ed2133
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2018-01-27 18:00:11 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2018-01-27 18:00:33 +0000

    sys-fs/udisks: drop CONFIG_SWAP check
    
    Closes: https://bugs.gentoo.org/645900
    Package-Manager: Portage-2.3.19_p11, Repoman-2.3.6_p45

 sys-fs/udisks/udisks-2.1.8.ebuild    | 3 +--
 sys-fs/udisks/udisks-2.6.5.ebuild    | 3 +--
 sys-fs/udisks/udisks-2.7.4-r1.ebuild | 1 -
 sys-fs/udisks/udisks-2.7.5-r1.ebuild | 1 -
 4 files changed, 2 insertions(+), 6 deletions(-)