Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 645814 - net-im/signal-desktop-bin - make libappindicator optional or remove this dependency
Summary: net-im/signal-desktop-bin - make libappindicator optional or remove this depe...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Robert G. Siebeck
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-26 16:48 UTC by Gleb
Modified: 2018-02-01 19:00 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gleb 2018-01-26 16:48:31 UTC
Is there any reason to force installation of this package? I have a local copy of the same ebuild with removed libappindicator and Signal works as expected without any issues, including notifications and tray icon.

For example, slack-bin and skypeforlinux on the same electron does not require this package. Electron itself also doesn't have such dependency.

I also don't see any linked libraries to the binary file.

For example, Xfce can work withour libappindicator and all tray icons will work just fine.
Comment 1 Gleb 2018-01-27 04:18:42 UTC
Well, I see now that deb package requires libappindicator.

However Electron documentations states that "On Linux the app indicator will be used if it is supported, otherwise GtkStatusIcon will be used instead." [1]

So it definitely can be optional.

[1]: https://github.com/electron/electron/blob/master/docs/api/tray.md
Comment 2 Simon 2018-01-27 21:13:47 UTC
An `appindicator` USE flag would probably make sense?

I ran into missing support/dependencies for appindicator in slack-bin, another Electron app. There are probably more Electron apps with appindicator support either enabled or disabled in the tree, they should probably all get the same USE flag.
Comment 3 Larry the Git Cow gentoo-dev 2018-02-01 19:00:01 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e3587c87f9d45eb2accaad1a300af9ac5e9473c4

commit e3587c87f9d45eb2accaad1a300af9ac5e9473c4
Author:     Robert Siebeck <gentoo.bugzilla.2012@r123.de>
AuthorDate: 2018-01-31 21:39:39 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-02-01 18:56:41 +0000

    net-im/signal-desktop-bin: new version 1.3.0
    
    Add use flag ayatana for dependency to appindicator.
    
    Closes: https://bugs.gentoo.org/645814

 net-im/signal-desktop-bin/Manifest                 |  1 +
 .../signal-desktop-bin-1.3.0.ebuild                | 51 ++++++++++++++++++++++
 2 files changed, 52 insertions(+)