Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 645638 - media-libs/liblastfm: install /usr/include/lastfm5 symlink
Summary: media-libs/liblastfm: install /usr/include/lastfm5 symlink
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-24 23:48 UTC by Diogo Pereira
Modified: 2018-02-17 19:17 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Diogo Pereira 2018-01-24 23:48:23 UTC
Debian has two packages for liblastfm, one built with Qt 4 [1] and the other with Qt 5 [2]. They both install the same headers, but in different directories. The Qt 4 package installs them in /usr/include/lastfm/, while the Qt 5 package installs them in /usr/include/lastfm5/.

Due to this, some Qt 5 applications, such as an as-yet unreleased version of Clementine, expect the liblastfm headers to be in a directory named lastfm5 [3].

Gentoo currently only installs the headers in /usr/include/lastfm/, making it impossible to build such applications.

To solve this problem, I suggest installing a symlink from /usr/include/lastfm5 to /usr/include/lastfm, when liblastfm is built with USE=qt5.


[1] https://packages.debian.org/sid/liblastfm-dev
[2] https://packages.debian.org/sid/liblastfm5-dev
[3] https://github.com/clementine-player/Clementine/blob/qt5/src/internet/lastfm/lastfmsettingspage.cpp#L25
Comment 1 Andreas Sturmlechner gentoo-dev 2018-01-25 00:00:55 UTC
That's a very odd thing for Debian to do, and I don't think clementine upstream should follow this. Not least since Qt4 is going away. Do you know of any other applications expecting headers in that place?
Comment 2 Diogo Pereira 2018-01-25 00:09:27 UTC
> Do you know of any other applications expecting headers in that place?

I googled "#include <lastfm5/" and found Tomahawk: https://github.com/tomahawk-player/tomahawk/blob/master/src/tomahawk/Scrobbler.h#L28


Fedora apparently also installs in /usr/include/lastfm5: https://fedora.pkgs.org/27/fedora-x86_64/liblastfm-qt5-devel-1.0.9-9.fc27.x86_64.rpm.html
Comment 3 Larry the Git Cow gentoo-dev 2018-02-17 19:17:03 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=79de2de023843ad9849d7c070065c2127e18da8a

commit 79de2de023843ad9849d7c070065c2127e18da8a
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-02-17 17:16:31 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-02-17 19:16:06 +0000

    media-sound/clementine: Fix lastfm paths
    
    Unfortunately clementine relies on downstream paths.
    
    Closes: https://bugs.gentoo.org/645638
    Package-Manager: Portage-2.3.24, Repoman-2.3.6

 media-sound/clementine/clementine-1.3.1_p20180203.ebuild | 8 ++++++++
 media-sound/clementine/clementine-9999.ebuild            | 8 ++++++++
 2 files changed, 16 insertions(+)