Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 645566 - media-sound/spotify: Bad usage of IUSE=gnome
Summary: media-sound/spotify: Bad usage of IUSE=gnome
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Matthew Thode ( prometheanfire )
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-24 16:20 UTC by Mart Raudsepp
Modified: 2018-01-26 00:56 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mart Raudsepp gentoo-dev 2018-01-24 16:20:29 UTC
media-sound/spotify USE=gnome pulls in gnome-extra/gnome-integration-spotify, but this is rather counter-intuitive, as GNOME does not need any such legacy X11 integration package. In GNOME3 everything seems to work as needed via spotify MPRIS support, and pulling this extra stuff (that can not ever work in wayland, e.g) in via USE=gnome is wrong. And USE=gnome is default enabled on gnome profiles.
Please use a different USE flag for this, preferably something that isn't default enabled in gnome profiles; also the extra package name is rather counter-intuitive, but I guess that's the upstream package name.
The thing is useful to non-GNOME non-MPRIS desktop environments really, I suppose; so actually people NOT on GNOME want this (and those people tend to blindly disable USE=gnome).
Comment 1 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2018-01-24 16:34:12 UTC
maybe use a 'systray' use flag?
Comment 2 Pacho Ramos gentoo-dev 2018-01-25 17:00:00 UTC
Well, upstream README shows that it supposedly provides much more features :/, then, I am not sure about what would be the best option:

https://github.com/mrpdaemon/gnome-integration-spotify

Notification display with cover art when changing tracks
Use media keys to control playback (patch by Mathieu Virbel)
Notification tray icon for current track
DBUS integration (Media Player Indicator gnome-shell extension displays what Spotify is playing)
Launch spotify:// URL's (playlists etc.) from other applications such as a browser.
Comment 3 Mart Raudsepp gentoo-dev 2018-01-25 17:41:01 UTC
(In reply to Pacho Ramos from comment #2)
> Well, upstream README shows that it supposedly provides much more features
> :/, then, I am not sure about what would be the best option:
> 
> https://github.com/mrpdaemon/gnome-integration-spotify
> 
> Notification display with cover art when changing tracks
> Use media keys to control playback (patch by Mathieu Virbel)
> Notification tray icon for current track
> DBUS integration (Media Player Indicator gnome-shell extension displays what
> Spotify is playing)
> Launch spotify:// URL's (playlists etc.) from other applications such as a
> browser.

All of those things work without gnome-integration-spotify in gnome-shell via MPRIS (which is now builtin gnome-shell feature, not a "Media Player Indicator" extension) and even in native wayland gnome-shell session (unlike the wmctrl based extra package). I'm only not sure about spotify:// URL's, but spotify itself does define itself as a MIME Handler for it in its desktop file, so should theoretically work as well. It even works with MPRIS with Laine extension (per-stream volume control in the shell sound tuning).
Just it's in the notification area (popdown from clock or Super+M), not the dead systray that needs a non-default extension to even display. And therefore there's also no minimize to tray, but that's how GNOME goes now.
Comment 4 Pacho Ramos gentoo-dev 2018-01-25 18:09:08 UTC
Taking into account that, I would even opt for dropping that package and dropping the USE flag then
Comment 5 Mart Raudsepp gentoo-dev 2018-01-25 18:38:33 UTC
Presumably it is useful for other environments, that don't do MPRIS natively. XFCE4, MATE and others I suppose. Though the extra package (upstream) naming is rather unfortunate by now. My goal is to not get this pulled in by default on gnome profiles, as it's redundant and doesn't work on wayland session and doubles what the native MPRIS stuff already does on GNOME.
Comment 6 Larry the Git Cow gentoo-dev 2018-01-26 00:56:11 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3cc1b713d0a0971cfa2816b91779a95036676991

commit 3cc1b713d0a0971cfa2816b91779a95036676991
Author:     Matthew Thode <prometheanfire@gentoo.org>
AuthorDate: 2018-01-26 00:55:39 +0000
Commit:     Matthew Thode <prometheanfire@gentoo.org>
CommitDate: 2018-01-26 00:56:00 +0000

    media-sound/spotify: switch use flag to systray from gnome
    
    Closes: https://bugs.gentoo.org/645566
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 media-sound/spotify/metadata.xml             |   1 +
 media-sound/spotify/spotify-1.0.70-r1.ebuild | 118 +++++++++++++++++++++++++++
 2 files changed, 119 insertions(+)