Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 645242 - =dev-db/tora-3.2-r1 revision bump
Summary: =dev-db/tora-3.2-r1 revision bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Sergey S. Starikoff
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2018-01-21 13:04 UTC by Sergey S. Starikoff
Modified: 2018-07-02 15:56 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
tora-3.2-r1.patch (tora-3.2-r1.patch,1.47 KB, patch)
2018-01-21 13:04 UTC, Sergey S. Starikoff
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey S. Starikoff 2018-01-21 13:04:03 UTC
Created attachment 515642 [details, diff]
tora-3.2-r1.patch

Planned review.

Changes:
1. Default database back-end set to postgres;
2. Added check at least one database back-end selected;
3. Patch is applied only when it needed (i.e. for release 3.2);
4. Dropped oracle's notice, duplicates obsolete version of dev-db/oracle-instantclient-basic;
5. oracle use dependency is satisfied by both Oracle 11 and Oracle 12 clients.

At least recent -9999 in the default configuration (+postgres -mysql -oracle) builds with pch use enabled.
But I remember the failure with this use for release.
Some tests needed, but probably we should force -pch for 3.2 release.

Please, update both release and live ebuilds.
Comment 1 Andreas Sturmlechner gentoo-dev 2018-07-01 09:48:58 UTC
No objections, except:

(In reply to Sergey S. Starikoff from comment #0)
> 3. Patch is applied only when it needed (i.e. for release 3.2);
Unnecessary change, 3.2 is 3.2 and 9999 is 9999, we don't do symlink-ready ebuild master files. It would not work if you started to stabilise 3.2 either. A new release will be made from 9999, not 3.2, and for that purpose the existing conditional block in 9999 works fine.
Comment 2 Larry the Git Cow gentoo-dev 2018-07-02 15:56:59 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bb07d154b32c83f3e29fc6dee2d15602d639ce4f

commit bb07d154b32c83f3e29fc6dee2d15602d639ce4f
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-07-02 15:30:45 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-07-02 15:56:41 +0000

    dev-db/tora: Switch to +postgres default, drop obsolete warning
    
    Thanks-to: Sergey S. Starikoff <Ikonta@yandex.ru>
    Closes: https://bugs.gentoo.org/645242
    Package-Manager: Portage-2.3.41, Repoman-2.3.9

 dev-db/tora/tora-3.2-r1.ebuild | 93 ++++++++++++++++++++++++++++++++++++++++++
 dev-db/tora/tora-9999.ebuild   | 20 ++-------
 2 files changed, 97 insertions(+), 16 deletions(-)