Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 645238 - app-emulation/wine-vanilla-3.0 - Restore `failglob` state
Summary: app-emulation/wine-vanilla-3.0 - Restore `failglob` state
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Wine Maintainers
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2018-01-21 12:26 UTC by Alex Turbov
Modified: 2018-01-22 22:53 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Restore original `failglob` state (wine-vanilla-3.0-restore-failglob.patch,395 bytes, patch)
2018-01-21 12:26 UTC, Alex Turbov 		Details | Diff
Restore original `failglob` state (correct way) (wine-vanilla-3.0-restore-failglob.patch,386 bytes, patch)
2018-01-21 12:34 UTC, Alex Turbov 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Turbov 2018-01-21 12:26:06 UTC 
The ebuild in portage changes the `failglob` state and forget to restore it.

Going to attach a patch...

Reproducible: Always
Comment 1 Alex Turbov 2018-01-21 12:26:57 UTC 
Created attachment 515636 [details, diff]
Restore original `failglob` state
Comment 2 Alex Turbov 2018-01-21 12:34:14 UTC 
Created attachment 515638 [details, diff]
Restore original `failglob` state (correct way)
Comment 3 Larry the Git Cow gentoo-dev 2018-01-22 22:51:01 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/wine.git/commit/?id=8d71ac4a9f2b2a19cf932542d78e198bdef8e174

commit 8d71ac4a9f2b2a19cf932542d78e198bdef8e174
Author:     NP-Hardass <NP-Hardass@gentoo.org>
AuthorDate: 2018-01-22 22:40:34 +0000
Commit:     NP-Hardass <NP-Hardass@gentoo.org>
CommitDate: 2018-01-22 22:40:34 +0000

    app-emulation/wine-any: Clean up manpage fixes
    
    Use estack eclass to avoid dealing with specifics of shopt usage
    Change implementation to handle any manpage from any locale
    Remove linguas references, finishing l10n switch
    
    Closes: https://bugs.gentoo.org/645238
    Bug: https://bugs.gentoo.org/617864
    Closes: https://bugs.gentoo.org/643576
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 app-emulation/wine-any/Manifest                |  2 +-
 app-emulation/wine-any/wine-any-2.0-r1.ebuild  | 54 +++++++++++++-------------
 app-emulation/wine-any/wine-any-2.1-r1.ebuild  | 54 +++++++++++++-------------
 app-emulation/wine-any/wine-any-2.10-r1.ebuild | 54 +++++++++++++-------------
 app-emulation/wine-any/wine-any-2.11-r1.ebuild | 54 +++++++++++++-------------
 app-emulation/wine-any/wine-any-2.12-r1.ebuild | 54 +++++++++++++-------------
 app-emulation/wine-any/wine-any-2.13-r1.ebuild | 54 +++++++++++++-------------
 app-emulation/wine-any/wine-any-2.14-r1.ebuild | 54 +++++++++++++-------------
 app-emulation/wine-any/wine-any-2.15-r1.ebuild | 54 +++++++++++++-------------
 app-emulation/wine-any/wine-any-2.16-r1.ebuild | 54 +++++++++++++-------------
 app-emulation/wine-any/wine-any-2.17-r1.ebuild | 54 +++++++++++++-------------
 app-emulation/wine-any/wine-any-2.18.ebuild    | 54 +++++++++++++-------------
 app-emulation/wine-any/wine-any-2.19.ebuild    | 54 +++++++++++++-------------
 app-emulation/wine-any/wine-any-2.2-r1.ebuild  | 54 +++++++++++++-------------
 app-emulation/wine-any/wine-any-2.20.ebuild    | 54 +++++++++++++-------------
 app-emulation/wine-any/wine-any-2.21.ebuild    | 54 +++++++++++++-------------
 app-emulation/wine-any/wine-any-2.3-r1.ebuild  | 54 +++++++++++++-------------
 app-emulation/wine-any/wine-any-2.4-r1.ebuild  | 54 +++++++++++++-------------
 app-emulation/wine-any/wine-any-2.5-r1.ebuild  | 54 +++++++++++++-------------
 app-emulation/wine-any/wine-any-2.6-r1.ebuild  | 54 +++++++++++++-------------
 app-emulation/wine-any/wine-any-2.7-r1.ebuild  | 54 +++++++++++++-------------
 app-emulation/wine-any/wine-any-2.8-r1.ebuild  | 54 +++++++++++++-------------
 app-emulation/wine-any/wine-any-2.9-r1.ebuild  | 54 +++++++++++++-------------
 app-emulation/wine-any/wine-any-9999.ebuild    | 54 +++++++++++++-------------
 24 files changed, 622 insertions(+), 622 deletions(-)

https://gitweb.gentoo.org/repo/proj/wine.git/commit/?id=c6424c7e33bc44b6b73741087ba04ff79241f4f8

commit c6424c7e33bc44b6b73741087ba04ff79241f4f8
Author:     NP-Hardass <NP-Hardass@gentoo.org>
AuthorDate: 2018-01-22 22:39:37 +0000
Commit:     NP-Hardass <NP-Hardass@gentoo.org>
CommitDate: 2018-01-22 22:39:37 +0000

    app-emulation/wine-d3d9: Clean up manpage fixes
    
    Use estack eclass to avoid dealing with specifics of shopt usage
    Change implementation to handle any manpage from any locale
    Remove linguas references, finishing l10n switch
    
    Closes: https://bugs.gentoo.org/645238
    Bug: https://bugs.gentoo.org/617864
    Closes: https://bugs.gentoo.org/643576
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 app-emulation/wine-d3d9/Manifest                 |  2 +-
 app-emulation/wine-d3d9/wine-d3d9-2.0-r1.ebuild  | 54 ++++++++++++------------
 app-emulation/wine-d3d9/wine-d3d9-2.1-r1.ebuild  | 54 ++++++++++++------------
 app-emulation/wine-d3d9/wine-d3d9-2.10-r1.ebuild | 54 ++++++++++++------------
 app-emulation/wine-d3d9/wine-d3d9-2.11-r1.ebuild | 54 ++++++++++++------------
 app-emulation/wine-d3d9/wine-d3d9-2.12-r1.ebuild | 54 ++++++++++++------------
 app-emulation/wine-d3d9/wine-d3d9-2.13-r1.ebuild | 54 ++++++++++++------------
 app-emulation/wine-d3d9/wine-d3d9-2.14-r1.ebuild | 54 ++++++++++++------------
 app-emulation/wine-d3d9/wine-d3d9-2.15-r1.ebuild | 54 ++++++++++++------------
 app-emulation/wine-d3d9/wine-d3d9-2.16-r1.ebuild | 54 ++++++++++++------------
 app-emulation/wine-d3d9/wine-d3d9-2.17-r1.ebuild | 54 ++++++++++++------------
 app-emulation/wine-d3d9/wine-d3d9-2.18.ebuild    | 54 ++++++++++++------------
 app-emulation/wine-d3d9/wine-d3d9-2.19.ebuild    | 54 ++++++++++++------------
 app-emulation/wine-d3d9/wine-d3d9-2.2-r1.ebuild  | 54 ++++++++++++------------
 app-emulation/wine-d3d9/wine-d3d9-2.20.ebuild    | 54 ++++++++++++------------
 app-emulation/wine-d3d9/wine-d3d9-2.21.ebuild    | 54 ++++++++++++------------
 app-emulation/wine-d3d9/wine-d3d9-2.3-r1.ebuild  | 54 ++++++++++++------------
 app-emulation/wine-d3d9/wine-d3d9-2.4-r1.ebuild  | 54 ++++++++++++------------
 app-emulation/wine-d3d9/wine-d3d9-2.5-r1.ebuild  | 54 ++++++++++++------------
 app-emulation/wine-d3d9/wine-d3d9-2.6-r1.ebuild  | 54 ++++++++++++------------
 app-emulation/wine-d3d9/wine-d3d9-2.7-r1.ebuild  | 54 ++++++++++++------------
 app-emulation/wine-d3d9/wine-d3d9-2.8-r1.ebuild  | 54 ++++++++++++------------
 app-emulation/wine-d3d9/wine-d3d9-2.9-r1.ebuild  | 54 ++++++++++++------------
 app-emulation/wine-d3d9/wine-d3d9-9999.ebuild    | 54 ++++++++++++------------
 24 files changed, 622 insertions(+), 622 deletions(-)

https://gitweb.gentoo.org/repo/proj/wine.git/commit/?id=e6de1eec1e48a7394fbcfec7d3dd7ddabfceb9c5

commit e6de1eec1e48a7394fbcfec7d3dd7ddabfceb9c5
Author:     NP-Hardass <NP-Hardass@gentoo.org>
AuthorDate: 2018-01-22 22:38:32 +0000
Commit:     NP-Hardass <NP-Hardass@gentoo.org>
CommitDate: 2018-01-22 22:38:32 +0000

    app-emulation/wine-staging: Clean up manpage fixes
    
    Use estack eclass to avoid dealing with specifics of shopt usage
    Change implementation to handle any manpage from any locale
    Remove linguas references, finishing l10n switch
    
    Closes: https://bugs.gentoo.org/645238
    Bug: https://bugs.gentoo.org/617864
    Closes: https://bugs.gentoo.org/643576
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 app-emulation/wine-staging/Manifest                |  2 +-
 .../wine-staging/wine-staging-2.0-r1.ebuild        | 54 +++++++++++-----------
 .../wine-staging/wine-staging-2.1-r1.ebuild        | 54 +++++++++++-----------
 .../wine-staging/wine-staging-2.10-r1.ebuild       | 54 +++++++++++-----------
 .../wine-staging/wine-staging-2.11-r1.ebuild       | 54 +++++++++++-----------
 .../wine-staging/wine-staging-2.12-r1.ebuild       | 54 +++++++++++-----------
 .../wine-staging/wine-staging-2.13-r1.ebuild       | 54 +++++++++++-----------
 .../wine-staging/wine-staging-2.14-r1.ebuild       | 54 +++++++++++-----------
 .../wine-staging/wine-staging-2.15-r1.ebuild       | 54 +++++++++++-----------
 .../wine-staging/wine-staging-2.16-r1.ebuild       | 54 +++++++++++-----------
 .../wine-staging/wine-staging-2.17-r1.ebuild       | 54 +++++++++++-----------
 .../wine-staging/wine-staging-2.18.ebuild          | 54 +++++++++++-----------
 .../wine-staging/wine-staging-2.19.ebuild          | 54 +++++++++++-----------
 .../wine-staging/wine-staging-2.2-r1.ebuild        | 54 +++++++++++-----------
 .../wine-staging/wine-staging-2.20.ebuild          | 54 +++++++++++-----------
 .../wine-staging/wine-staging-2.21.ebuild          | 54 +++++++++++-----------
 .../wine-staging/wine-staging-2.3-r1.ebuild        | 54 +++++++++++-----------
 .../wine-staging/wine-staging-2.4-r1.ebuild        | 54 +++++++++++-----------
 .../wine-staging/wine-staging-2.5-r1.ebuild        | 54 +++++++++++-----------
 .../wine-staging/wine-staging-2.6-r1.ebuild        | 54 +++++++++++-----------
 .../wine-staging/wine-staging-2.7-r1.ebuild        | 54 +++++++++++-----------
 .../wine-staging/wine-staging-2.8-r1.ebuild        | 54 +++++++++++-----------
 .../wine-staging/wine-staging-2.9-r1.ebuild        | 54 +++++++++++-----------
 .../wine-staging/wine-staging-9999.ebuild          | 54 +++++++++++-----------
 24 files changed, 622 insertions(+), 622 deletions(-)

https://gitweb.gentoo.org/repo/proj/wine.git/commit/?id=640cf35776ca65ffd65eafda8543cb069d57fdac

commit 640cf35776ca65ffd65eafda8543cb069d57fdac
Author:     NP-Hardass <NP-Hardass@gentoo.org>
AuthorDate: 2018-01-22 22:36:35 +0000
Commit:     NP-Hardass <NP-Hardass@gentoo.org>
CommitDate: 2018-01-22 22:36:35 +0000

    app-emulation/wine-vanilla: Clean up manpage fixes
    
    Use estack eclass to avoid dealing with specifics of shopt usage
    Change implementation to handle any manpage from any locale
    Remove linguas references, finishing l10n switch
    
    Closes: https://bugs.gentoo.org/645238
    Bug: https://bugs.gentoo.org/617864
    Closes: https://bugs.gentoo.org/643576
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 app-emulation/wine-vanilla/Manifest                |  2 +-
 .../wine-vanilla/wine-vanilla-2.0-r1.ebuild        | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-2.0.1-r1.ebuild      | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-2.0.2-r1.ebuild      | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-2.0.3.ebuild         | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-2.0.4.ebuild         | 54 +++++++++++-----------
 app-emulation/wine-vanilla/wine-vanilla-2.0.ebuild | 52 ++++++++++-----------
 .../wine-vanilla/wine-vanilla-2.1-r1.ebuild        | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-2.10-r1.ebuild       | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-2.11-r1.ebuild       | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-2.12-r1.ebuild       | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-2.13-r1.ebuild       | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-2.14-r1.ebuild       | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-2.15-r1.ebuild       | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-2.16-r1.ebuild       | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-2.17-r1.ebuild       | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-2.18-r2.ebuild       | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-2.19-r1.ebuild       | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-2.2-r1.ebuild        | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-2.20.ebuild          | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-2.21.ebuild          | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-2.22.ebuild          | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-2.3-r1.ebuild        | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-2.4-r1.ebuild        | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-2.5-r1.ebuild        | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-2.6-r1.ebuild        | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-2.7-r1.ebuild        | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-2.8-r1.ebuild        | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-2.9-r1.ebuild        | 54 +++++++++++-----------
 app-emulation/wine-vanilla/wine-vanilla-3.0.ebuild | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-9999.ebuild          | 54 +++++++++++-----------
 31 files changed, 810 insertions(+), 810 deletions(-)
Comment 4 Larry the Git Cow gentoo-dev 2018-01-22 22:51:26 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=12b38f5a8967f6eec0df09f4af4c3c8d9ec80ae0

commit 12b38f5a8967f6eec0df09f4af4c3c8d9ec80ae0
Author:     NP-Hardass <NP-Hardass@gentoo.org>
AuthorDate: 2018-01-22 22:50:32 +0000
Commit:     NP-Hardass <NP-Hardass@gentoo.org>
CommitDate: 2018-01-22 22:51:19 +0000

    app-emulation/wine-any: Sync from ::wine
    
    Clean up manpage fixes
    
    Use estack eclass to avoid dealing with specifics of shopt usage
    Change implementation to handle any manpage from any locale
    Remove linguas references, finishing l10n switch
    
    Closes: https://bugs.gentoo.org/645238
    Bug: https://bugs.gentoo.org/617864
    Closes: https://bugs.gentoo.org/643576
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 app-emulation/wine-any/Manifest               |  2 +-
 app-emulation/wine-any/wine-any-2.0-r1.ebuild | 54 +++++++++++++--------------
 app-emulation/wine-any/wine-any-2.19.ebuild   | 54 +++++++++++++--------------
 app-emulation/wine-any/wine-any-2.20.ebuild   | 54 +++++++++++++--------------
 app-emulation/wine-any/wine-any-2.21.ebuild   | 54 +++++++++++++--------------
 app-emulation/wine-any/wine-any-9999.ebuild   | 54 +++++++++++++--------------
 6 files changed, 136 insertions(+), 136 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e4c2fdb2823ebd63c38d07e539aa4db08e92861e

commit e4c2fdb2823ebd63c38d07e539aa4db08e92861e
Author:     NP-Hardass <NP-Hardass@gentoo.org>
AuthorDate: 2018-01-22 22:49:48 +0000
Commit:     NP-Hardass <NP-Hardass@gentoo.org>
CommitDate: 2018-01-22 22:51:17 +0000

    app-emulation/wine-d3d9: Sync from ::wine
    
    Use estack eclass to avoid dealing with specifics of shopt usage
    Change implementation to handle any manpage from any locale
    Remove linguas references, finishing l10n switch
    
    Closes: https://bugs.gentoo.org/645238
    Bug: https://bugs.gentoo.org/617864
    Closes: https://bugs.gentoo.org/643576
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 app-emulation/wine-d3d9/Manifest                |  2 +-
 app-emulation/wine-d3d9/wine-d3d9-2.0-r1.ebuild | 54 ++++++++++++-------------
 app-emulation/wine-d3d9/wine-d3d9-2.19.ebuild   | 54 ++++++++++++-------------
 app-emulation/wine-d3d9/wine-d3d9-2.20.ebuild   | 54 ++++++++++++-------------
 app-emulation/wine-d3d9/wine-d3d9-2.21.ebuild   | 54 ++++++++++++-------------
 app-emulation/wine-d3d9/wine-d3d9-9999.ebuild   | 54 ++++++++++++-------------
 6 files changed, 136 insertions(+), 136 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=42a2669dacc28c4614cfb7f810ff22e64cf44087

commit 42a2669dacc28c4614cfb7f810ff22e64cf44087
Author:     NP-Hardass <NP-Hardass@gentoo.org>
AuthorDate: 2018-01-22 22:48:56 +0000
Commit:     NP-Hardass <NP-Hardass@gentoo.org>
CommitDate: 2018-01-22 22:51:16 +0000

    app-emulation/wine-staging: Sync from ::wine
    
    Use estack eclass to avoid dealing with specifics of shopt usage
    Change implementation to handle any manpage from any locale
    Remove linguas references, finishing l10n switch
    
    Closes: https://bugs.gentoo.org/645238
    Bug: https://bugs.gentoo.org/617864
    Closes: https://bugs.gentoo.org/643576
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 app-emulation/wine-staging/Manifest                |  2 +-
 .../wine-staging/wine-staging-2.0-r1.ebuild        | 54 +++++++++++-----------
 .../wine-staging/wine-staging-2.19.ebuild          | 54 +++++++++++-----------
 .../wine-staging/wine-staging-2.20.ebuild          | 54 +++++++++++-----------
 .../wine-staging/wine-staging-2.21.ebuild          | 54 +++++++++++-----------
 .../wine-staging/wine-staging-9999.ebuild          | 54 +++++++++++-----------
 6 files changed, 136 insertions(+), 136 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ef405d728fa9e00b95c44feae79a00169b36b04f

commit ef405d728fa9e00b95c44feae79a00169b36b04f
Author:     NP-Hardass <NP-Hardass@gentoo.org>
AuthorDate: 2018-01-22 22:46:19 +0000
Commit:     NP-Hardass <NP-Hardass@gentoo.org>
CommitDate: 2018-01-22 22:51:14 +0000

    app-emulation/wine-vanilla: Sync from ::wine
    
    Use estack eclass to avoid dealing with specifics of shopt usage
    Change implementation to handle any manpage from any locale
    Remove linguas references, finishing l10n switch
    
    Closes: https://bugs.gentoo.org/645238
    Bug: https://bugs.gentoo.org/617864
    Closes: https://bugs.gentoo.org/643576
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 app-emulation/wine-vanilla/Manifest                |  2 +-
 .../wine-vanilla/wine-vanilla-2.0-r1.ebuild        | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-2.0.1-r1.ebuild      | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-2.0.2-r1.ebuild      | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-2.0.3.ebuild         | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-2.0.4.ebuild         | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-2.20.ebuild          | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-2.21.ebuild          | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-2.22.ebuild          | 54 +++++++++++-----------
 app-emulation/wine-vanilla/wine-vanilla-3.0.ebuild | 54 +++++++++++-----------
 .../wine-vanilla/wine-vanilla-9999.ebuild          | 54 +++++++++++-----------
 11 files changed, 271 insertions(+), 271 deletions(-)
Comment 5 Adam Feldman gentoo-dev 2018-01-22 22:53:52 UTC 
Thanks for the report and patch.  I opted to switch to using the estack eclass to handle the shopts setting and unsetting.  I'll leave the discussions on the best way to do that to the eclass instead of doing that on my own.