Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 644910 - www-apps/novnc-0.6.2: use ebuild helpers
Summary: www-apps/novnc-0.6.2: use ebuild helpers
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Deadline: 2018-01-25
Assignee: Matthew Thode ( prometheanfire )
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-18 07:46 UTC by Benda Xu
Modified: 2018-01-19 03:49 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
novnc-0.6.2.patch (novnc.patch,1.29 KB, patch)
2018-01-18 07:46 UTC, Benda Xu
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benda Xu gentoo-dev 2018-01-18 07:46:32 UTC
Created attachment 515216 [details, diff]
novnc-0.6.2.patch

Hi Matthew, the ebuild can be simplified and improved as attached.  Does it look good to you?
Comment 1 Larry the Git Cow gentoo-dev 2018-01-18 20:10:45 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=36c099bfc38a921ca4382fea09efa62a95a76ae2

commit 36c099bfc38a921ca4382fea09efa62a95a76ae2
Author:     Matthew Thode <prometheanfire@gentoo.org>
AuthorDate: 2018-01-18 20:09:32 +0000
Commit:     Matthew Thode <prometheanfire@gentoo.org>
CommitDate: 2018-01-18 20:10:34 +0000

    www-apps/novnc: fixing bugs, and an eapi bump
    
    Closes: https://bugs.gentoo.org/644914
    Closes: https://bugs.gentoo.org/644910
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 www-apps/novnc/novnc-0.6.2-r1.ebuild | 47 ++++++++++++++++++++++++++++++++++++
 www-apps/novnc/novnc-9999.ebuild     | 47 +++++++++++++++---------------------
 2 files changed, 67 insertions(+), 27 deletions(-)
Comment 2 Benda Xu gentoo-dev 2018-01-19 03:49:13 UTC
Thanks Matthew!