Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 644632 - app-emulation/libvirt - add bash completion support
Summary: app-emulation/libvirt - add bash completion support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Matthias Maier
URL: https://www.redhat.com/archives/libvi...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2018-01-15 07:59 UTC by Michal Privoznik
Modified: 2018-01-30 17:55 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
0001-app-emulation-libvirt-Install-bash-completion-files.patch (0001-app-emulation-libvirt-Install-bash-completion-files.patch,1.28 KB, patch)
2018-01-15 07:59 UTC, Michal Privoznik
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Privoznik 2018-01-15 07:59:05 UTC
Created attachment 514854 [details, diff]
0001-app-emulation-libvirt-Install-bash-completion-files.patch

Libvirt gained support for bash-completion [1] and we need to install the shell script. I was able to achieve the result with just a few lines of code (see attached patch).

1: https://libvirt.org/git/?p=libvirt.git;a=commit;h=f0d390bc161e3845554244b319e36907d40ad6ef
Comment 1 Michal Privoznik 2018-01-25 14:24:34 UTC
It probably doesn't make much sense to spend any time on this until these are merged:

https://www.redhat.com/archives/libvir-list/2018-January/msg00902.html

The attached patch will need to look slightly different then too.
Comment 2 Larry the Git Cow gentoo-dev 2018-01-30 17:55:04 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0a987006baf8f3267fb9df03e16baab99bf1f98b

commit 0a987006baf8f3267fb9df03e16baab99bf1f98b
Author:     Matthias Maier <tamiko@gentoo.org>
AuthorDate: 2018-01-30 17:39:01 +0000
Commit:     Matthias Maier <tamiko@gentoo.org>
CommitDate: 2018-01-30 17:54:56 +0000

    app-emulation/libvirt: add bashcompletion support
    
     - also apply two minor bugfixes for version 4.0.0 (hopefully fixed in
       the live version soon.)
    
    Closes: https://bugs.gentoo.org/644632
    Package-Manager: Portage-2.3.20, Repoman-2.3.6

 .../libvirt-4.0.0-bash_completion_bugfixes.patch   | 42 ++++++++++++++++++++++
 app-emulation/libvirt/libvirt-4.0.0.ebuild         |  6 +++-
 app-emulation/libvirt/libvirt-9999.ebuild          |  7 ++--
 3 files changed, 52 insertions(+), 3 deletions(-)