Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 644466 - media-libs/opencolorio-1.1.0: Lut1DOp.cpp:192:14: error: ‘void OpenColorIO::v1::{anonymous}::Lut1D_Nearest(float*, long int, const OpenColorIO::v1::Lut1D&)’ defined but not used [-Werror=unused-function]
Summary: media-libs/opencolorio-1.1.0: Lut1DOp.cpp:192:14: error: ‘void OpenColorIO::v...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Graphics Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-13 14:52 UTC by Kobboi
Modified: 2018-01-19 11:57 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
build.log (build.log,54.53 KB, text/x-log)
2018-01-13 14:53 UTC, Kobboi 		Details
opencolorio-1.1.0-fix-compile-error.patch (opencolorio-1.1.0-fix-compile-error.patch,2.69 KB, patch)
2018-01-14 20:15 UTC, Jonathan Scruggs (RETIRED) 		Details | Diff
Werror patch (opencolorio-1.1.0-Werror.patch,422 bytes, patch)
2018-01-15 08:57 UTC, Michelangelo Scopelliti 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kobboi 2018-01-13 14:52:10 UTC 
[ 51%] Building CXX object src/core/CMakeFiles/OpenColorIO.dir/Lut3DOp.cpp.o
cd /mnt/oldhome/tmp-portage/portage/media-libs/opencolorio-1.1.0/work/opencolorio-1.1.0_build/src/core && /usr/bin/x86_64-pc-linux-gnu-g++ -DOpenColorIO_EXPORTS -DUSE_SSE -I/mnt/oldhome/tmp-portage/portage/media-libs/opencolorio-1.1.0/work/opencolorio-1.1.0/export -I/mnt/oldhome/tmp-portage/portage/media-libs/opencolorio-1.1.0/work/opencolorio-1.1.0_build/export -I/mnt/oldhome/tmp-portage/portage/media-libs/opencolorio-1.1.0/work/opencolorio-1.1.0/ext/oiio/src/include -I/mnt/oldhome/tmp-portage/portage/media-libs/opencolorio-1.1.0/work/opencolorio-1.1.0_build/ext/dist/include   -DNDEBUG -O2 -march=native -pipe -fomit-frame-pointer -Wall -Wextra -Wshadow -Wconversion -Wcast-qual -Wformat=2 -msse2 -fPIC   -DTIXML_USE_STL   -fPIC -fvisibility=hidden -Werror -o CMakeFiles/OpenColorIO.dir/Lut3DOp.cpp.o -c /mnt/oldhome/tmp-portage/portage/media-libs/opencolorio-1.1.0/work/opencolorio-1.1.0/src/core/Lut3DOp.cpp
[ 52%] Building CXX object src/core/CMakeFiles/OpenColorIO.dir/MathUtils.cpp.o
cd /mnt/oldhome/tmp-portage/portage/media-libs/opencolorio-1.1.0/work/opencolorio-1.1.0_build/src/core && /usr/bin/x86_64-pc-linux-gnu-g++ -DOpenColorIO_EXPORTS -DUSE_SSE -I/mnt/oldhome/tmp-portage/portage/media-libs/opencolorio-1.1.0/work/opencolorio-1.1.0/export -I/mnt/oldhome/tmp-portage/portage/media-libs/opencolorio-1.1.0/work/opencolorio-1.1.0_build/export -I/mnt/oldhome/tmp-portage/portage/media-libs/opencolorio-1.1.0/work/opencolorio-1.1.0/ext/oiio/src/include -I/mnt/oldhome/tmp-portage/portage/media-libs/opencolorio-1.1.0/work/opencolorio-1.1.0_build/ext/dist/include   -DNDEBUG -O2 -march=native -pipe -fomit-frame-pointer -Wall -Wextra -Wshadow -Wconversion -Wcast-qual -Wformat=2 -msse2 -fPIC   -DTIXML_USE_STL   -fPIC -fvisibility=hidden -Werror -o CMakeFiles/OpenColorIO.dir/MathUtils.cpp.o -c /mnt/oldhome/tmp-portage/portage/media-libs/opencolorio-1.1.0/work/opencolorio-1.1.0/src/core/MathUtils.cpp
/mnt/oldhome/tmp-portage/portage/media-libs/opencolorio-1.1.0/work/opencolorio-1.1.0/src/core/Lut1DOp.cpp:192:14: error: ‘void OpenColorIO::v1::{anonymous}::Lut1D_Nearest(float*, long int, const OpenColorIO::v1::Lut1D&)’ defined but not used [-Werror=unused-function]
         void Lut1D_Nearest(float* rgbaBuffer, long numPixels, const Lut1D & lut)
              ^~~~~~~~~~~~~
[ 53%] Building CXX object src/core/CMakeFiles/OpenColorIO.dir/MatrixOps.cpp.o
cd /mnt/oldhome/tmp-portage/portage/media-libs/opencolorio-1.1.0/work/opencolorio-1.1.0_build/src/core && /usr/bin/x86_64-pc-linux-gnu-g++ -DOpenColorIO_EXPORTS -DUSE_SSE -I/mnt/oldhome/tmp-portage/portage/media-libs/opencolorio-1.1.0/work/opencolorio-1.1.0/export -I/mnt/oldhome/tmp-portage/portage/media-libs/opencolorio-1.1.0/work/opencolorio-1.1.0_build/export -I/mnt/oldhome/tmp-portage/portage/media-libs/opencolorio-1.1.0/work/opencolorio-1.1.0/ext/oiio/src/include -I/mnt/oldhome/tmp-portage/portage/media-libs/opencolorio-1.1.0/work/opencolorio-1.1.0_build/ext/dist/include   -DNDEBUG -O2 -march=native -pipe -fomit-frame-pointer -Wall -Wextra -Wshadow -Wconversion -Wcast-qual -Wformat=2 -msse2 -fPIC   -DTIXML_USE_STL   -fPIC -fvisibility=hidden -Werror -o CMakeFiles/OpenColorIO.dir/MatrixOps.cpp.o -c /mnt/oldhome/tmp-portage/portage/media-libs/opencolorio-1.1.0/work/opencolorio-1.1.0/src/core/MatrixOps.cpp
cc1plus: all warnings being treated as errors
make[2]: *** [src/core/CMakeFiles/OpenColorIO.dir/Lut1DOp.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
/mnt/oldhome/tmp-portage/portage/media-libs/opencolorio-1.1.0/work/opencolorio-1.1.0/src/core/MathUtils.cpp:333:10: error: ‘void OpenColorIO::v1::{anonymous}::GetMxbResult(float*, float*, float*, float*)’ defined but not used [-Werror=unused-function]
     void GetMxbResult(float* vout, float* m, float* x, float* v)
          ^~~~~~~~~~~~
cc1plus: all warnings being treated as errors
make[2]: *** [src/core/CMakeFiles/OpenColorIO.dir/MathUtils.cpp.o] Error 1
make[2]: Leaving directory `/mnt/oldhome/tmp-portage/portage/media-libs/opencolorio-1.1.0/work/opencolorio-1.1.0_build'
make[1]: *** [src/core/CMakeFiles/OpenColorIO.dir/all] Error 2
make[1]: Leaving directory `/mnt/oldhome/tmp-portage/portage/media-libs/opencolorio-1.1.0/work/opencolorio-1.1.0_build'
make: *** [all] Error 2
Comment 1 Kobboi 2018-01-13 14:53:26 UTC 
Created attachment 514656 [details]
build.log
Comment 2 Jonathan Scruggs (RETIRED) gentoo-dev 2018-01-14 20:15:47 UTC 
Created attachment 514812 [details, diff]
opencolorio-1.1.0-fix-compile-error.patch

Hi, can you try this patch for me? If this fixes your issue, I'll make a -r1 release.

Thanks.
Comment 3 Kobboi 2018-01-14 22:08:45 UTC 
(In reply to Jonathan Scruggs from comment #2)
> Hi, can you try this patch for me?

Your patch fixes at least the compilation (can't easily check runtime behavior).
Comment 4 Michelangelo Scopelliti 2018-01-15 08:57:23 UTC 
Created attachment 514856 [details, diff]
Werror patch

There is a less aggressive way to compile the package (patch included). Since the error is triggered by a warning, and not a "real" error, removing such a conversion solves the issue -- and no source is modified.
Comment 5 Jonathan Scruggs (RETIRED) gentoo-dev 2018-01-15 11:46:47 UTC 
I thought about doing that as well, but the patch I found is an official one that's already in upstream master branch, so I thought I would use that as it truly address the issue. :)
Comment 6 tman 2018-01-15 19:18:14 UTC 
(In reply to Michelangelo Scopelliti from comment #4)
> Created attachment 514856 [details, diff] [details, diff]
> Werror patch
> 
> There is a less aggressive way to compile the package (patch included).
> Since the error is triggered by a warning, and not a "real" error, removing
> such a conversion solves the issue -- and no source is modified.

this patch not work
Comment 7 Ștefan Talpalaru 2018-01-18 01:00:55 UTC 
media-libs/opencolorio-1.1.0-r1 with the first proposed patch was added to my overlay: https://github.com/stefantalpalaru/gentoo-overlay

I tested it from Krita, using this as a guide: https://krita.org/en/item/new-in-krita-painting-with-exposure-and-gamma/
Comment 8 Jonathan Scruggs (RETIRED) gentoo-dev 2018-01-18 07:35:07 UTC 
I have a PR and just waiting for it to be approved. There's other fixes besides this one. If you have your own overlay, you'll want to use the one going into postage.
Comment 9 Larry the Git Cow gentoo-dev 2018-01-19 11:57:58 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e1190425c7265517e4e90e67ef82abcca66006db

commit e1190425c7265517e4e90e67ef82abcca66006db
Author:     Jonathan Scruggs <j.scruggs@gmail.com>
AuthorDate: 2018-01-15 15:02:16 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2018-01-19 11:57:41 +0000

    media-libs/opencolorio: Revision bump to fix Lut1DOp error
    
    Fix the compile error in the Lut1DOp.cpp file
    Fix install location of the CMake files
    Split the patches to make it easier to maintain
    
    Closes: https://bugs.gentoo.org/644466
    Closes: https://github.com/gentoo/gentoo/pull/6870

 ...-1.1.0-fix-compile-error-with-Lut1DOp.cpp.patch |  92 ++++++++++++
 ...1.1.0-remove-building-of-bundled-programs.patch | 154 +++++++++++++++++++++
 ...nstallDirs-and-fix-cmake-install-location.patch | 102 ++++++++++++++
 media-libs/opencolorio/metadata.xml                |   3 +-
 media-libs/opencolorio/opencolorio-1.1.0-r1.ebuild |  85 ++++++++++++
 5 files changed, 435 insertions(+), 1 deletion(-)