644064 – xfce-extra/thunar-archive-plugin-0.3.1-r3 - Some patches are not applied due to autotools not invoked

Bug 644064 - xfce-extra/thunar-archive-plugin-0.3.1-r3 - Some patches are not applied due to autotools not invoked

Summary: xfce-extra/thunar-archive-plugin-0.3.1-r3 - Some patches are not applied due ...

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal enhancement (vote)
Assignee:	XFCE Team

URL:
Whiteboard:
Keywords:

Duplicates (1):	644066 (view as bug list)
Depends on:
Blocks:

Reported:	2018-01-09 20:44 UTC by Daniel Pielmeier
Modified:	2018-02-13 20:36 UTC (History)
CC List:	3 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Run eautoreconf so patches get actually applied (thunar-archive-plugin.diff,623 bytes, patch) 2018-01-09 20:44 UTC, Daniel Pielmeier	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Daniel Pielmeier gentoo-dev

2018-01-09 20:44:50 UTC

The commit [1] migrating the ebuild away from xfconf eclass now does not run eautoreconf any more. However there are patches to Makefile.am which do not take effect without running it.

[1] https://gitweb.gentoo.org/repo/gentoo.git/commit/xfce-extra/thunar-archive-plugin?id=1f7e2e4a44ce0628bcde5cfa0345669b03d493a9

Comment 1 Daniel Pielmeier gentoo-dev

2018-01-09 20:48:54 UTC

*** Bug 644066 has been marked as a duplicate of this bug. ***

Comment 2 Denis Dupeyron (RETIRED) gentoo-dev

2018-01-09 20:55:25 UTC

I vaguely remember looking at this and concluding the patch was no longer needed for some reason. I may have been entirely wrong though. Is something now actually broken as the result of this?

Comment 3 Daniel Pielmeier gentoo-dev

2018-01-09 20:58:19 UTC

It is not needed for 0.4 as this has been applied upstream.

However for 0.3.1 the patches for engrampa support and the symlinks to ark and file-roller are still needed else the thunar integration for the archivers does not work.

Comment 4 tt_1 2018-01-18 15:55:14 UTC

This broke the usage of the plugin via the context menu of thunar, the error states that no binary for compression or decompression can be found. Makes sense to me, if the patches providing the correct symlinks does not get applied anymore by the ebuild. -r2 is not affected, and from what I can tell the attached patch works for -r3.

Comment 5 Gleb 2018-02-13 14:03:15 UTC

Symlinks are missing, so the file-roller does not work. It also includes current stable version. Is it possible to fix this problem?

Comment 6 Larry the Git Cow gentoo-dev

2018-02-13 15:28:59 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1bd3ee17d5a79048d830423aa151085eb1e5f39e

commit 1bd3ee17d5a79048d830423aa151085eb1e5f39e
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2018-02-13 15:21:11 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-02-13 15:27:09 +0000

    xfce-extra/thunar-archive-plugin: Readd missing eautoreconf
    
    Readd missing eautoreconf after applying patches. Thanks to Daniel
    Pielmeier for the report and the patch.
    
    Closes: https://bugs.gentoo.org/644064

 .../thunar-archive-plugin-0.3.1-r3.ebuild                      | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

Comment 7 Daniel Pielmeier gentoo-dev

2018-02-13 20:34:12 UTC

Thanks for fixing this. Totally forgot about the m4macros being part of xfce4-dev-tools.

Comment 8 Michał Górny archtester

2018-02-13 20:36:54 UTC

No problem. I'm sorry it took this long to get it fixed.