Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 643902 - =app-text/nfoview-1.23 version bump / undo removal
Summary: =app-text/nfoview-1.23 version bump / undo removal
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2018-01-08 13:51 UTC by Till Schäfer
Modified: 2018-01-15 11:16 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
nfoview-1.23.ebuild (nfoview-1.23.ebuild,845 bytes, text/plain)
2018-01-08 13:51 UTC, Till Schäfer
Details
nfoview-1.23.ebuild (v2, fixed header, removed keywords) (nfoview-1.23.ebuild,847 bytes, text/plain)
2018-01-08 17:12 UTC, Till Schäfer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Till Schäfer 2018-01-08 13:51:29 UTC
Created attachment 513760 [details]
nfoview-1.23.ebuild

nfoview is sheduled for removal since, no up-to-date version is in the tree and the current version has a bug (see Bug 614314). 

Instead removing nfoview completely, please add the current version to the tree. An ebuild is attached. I changed the website and download URL. Otherwise it is identical to the current tree version.
Comment 1 Jonas Stein gentoo-dev 2018-01-08 15:22:12 UTC
Thank you for your contribution. I had a short look on the ebuild. 
Here a few ideas:

* Please test the ebuild with repoman full -x https://wiki.gentoo.org/wiki/Repoman

* KEYWORDS need ~ after a version bump run ekeyword ~all YOUREBUILD
* please fix the header. (see /usr/portage/skel.ebuild and https://devmanual.gentoo.org/ebuild-writing/eapi/)

# Copyright 1999-2017 Gentoo Foundation
-> 
# Copyright 1999-2018 Gentoo Foundation

is #614314 fixed in this version?

Do you know this package well and want to take care of future bug reports and maintain this ebuild as proxied maintainer?

-----8<----------------------------------------------
# Pacho Ramos <pacho@gentoo.org> (28 Dec 2017)
# Fails at runtime (#614314). Removal in a month.
app-text/nfoview
Comment 2 Till Schäfer 2018-01-08 17:12:26 UTC
Created attachment 513778 [details]
nfoview-1.23.ebuild (v2, fixed header, removed keywords)

* Header is fixed
* Keywords are removed
* I am unsure if the errors given in Bug 614314 are related to the crash, but both warnings/errors given the bug are fixed in 1.23 (also see the other bug for details)
* RepoMan sez(sic! / :-)) OK



-----
# repoman -dx full 

RepoMan scours the neighborhood...

Note: use --without-mask to check KEYWORDS on dependencies of masked packages

RepoMan sez: "If everyone were like you, I'd be out of business!"
Comment 3 Till Schäfer 2018-01-08 17:36:17 UTC
(of course the keywords are not removed, but adjusted to testing)

Regarding the proxy-maintainership: I am willing to do the work. I am not familiar to any code details in the nfoview project (yet), but I am willing to investigate them as necessary. 

I do not fully get the git pull request procedure in https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers/User_Guide. Should I discuss the details in the IRC channel #gentoo-proxy-maint?
Comment 4 Pacho Ramos gentoo-dev 2018-01-08 19:22:49 UTC
I won't undo the removal until the package finally gets a new maintainer taking care of it, I will CC proxy-maint then :/
Comment 5 Till Schäfer 2018-01-08 19:27:46 UTC
OK, I am currently creating the pull request to become the proxy maintainer.
Comment 6 Larry the Git Cow gentoo-dev 2018-01-08 20:10:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=834fadaabc9fdc0d09a8c2380d536b62ad08a0ca

commit 834fadaabc9fdc0d09a8c2380d536b62ad08a0ca
Author:     Till Schäfer <till2.schaefer@uni-dortmund.de>
AuthorDate: 2018-01-08 19:31:00 +0000
Commit:     Craig Andrews <candrews@gentoo.org>
CommitDate: 2018-01-08 20:10:25 +0000

    app-text/nfoview: version bump to 1.23
    
    Closes: https://bugs.gentoo.org/643902
    Closes: https://bugs.gentoo.org/614314
    Package-Manager: Portage-2.3.13, Repoman-2.3.3

 app-text/nfoview/Manifest            |  1 +
 app-text/nfoview/nfoview-1.23.ebuild | 41 ++++++++++++++++++++++++++++++++++++
 app-text/nfoview/nfoview-9999.ebuild |  6 +++---
 3 files changed, 45 insertions(+), 3 deletions(-)
Comment 7 Till Schäfer 2018-01-15 11:13:55 UTC
Can someone please undo the removal mask? Everything is in place (new version in tree, package got a (proxy-)maintainer).
Comment 8 Larry the Git Cow gentoo-dev 2018-01-15 11:16:23 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a6fd70158eaa5be4da4fdbe1c457aa660414c31e

commit a6fd70158eaa5be4da4fdbe1c457aa660414c31e
Author:     Michael Palimaka <kensington@gentoo.org>
AuthorDate: 2018-01-15 11:16:01 +0000
Commit:     Michael Palimaka <kensington@gentoo.org>
CommitDate: 2018-01-15 11:16:13 +0000

    profiles: drop mask for app-text/nfoview
    
    Bug: https://bugs.gentoo.org/643902

 profiles/package.mask | 4 ----
 1 file changed, 4 deletions(-)}