Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 643888 - sci-visualization/gnuplot: use flag to enable ReGIS support
Summary: sci-visualization/gnuplot: use flag to enable ReGIS support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Ulrich Müller
URL:
Whiteboard:
Keywords: PATCH, UPSTREAM
Depends on:
Blocks:
 
Reported: 2018-01-08 11:03 UTC by Nikita Zlobin
Modified: 2018-01-12 08:38 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
files/gnuplot-5.2.2-regis.patch (gnuplot-5.2.2-regis.patch,1.14 KB, patch)
2018-01-10 10:44 UTC, Ulrich Müller
Details | Diff
Patch for gnuplot-5.2.2.ebuild (gnuplot-5.2.2.ebuild.patch,1.08 KB, patch)
2018-01-10 10:46 UTC, Ulrich Müller
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Zlobin 2018-01-08 11:03:50 UTC
Some terminals, e.g. mlterm and terminology, have support for ReGIS in-terminal vector graphics, and gnuplot has support for it. However, it's a bit tricky way to enable it - there is explanation, how to do it:
http://gnuplot.10905.n7.nabble.com/Enable-regis-terminal-when-compile-gnuplot-td17712.html

Quoting the reply:
--------------------------------------------
This is mentioned in the INSTALL instructions, although it would be easy 
to miss.   Basically you edit the file .../src/term.h and uncomment the 
line containing     #include "regis.trm" 

  /* REGIS graphics language */ 
  /* # include "regis.trm" */
Comment 1 Ulrich Müller gentoo-dev 2018-01-10 10:43:13 UTC
Seems simple enough (and I am going to attach a patch).

However, term/regis.trm says "Note: legacy terminal", and in src/term.h support is only enabled under a VMS conditional. So I wonder if we should add support for a feature that upstream considers to be legacy.
Comment 2 Ulrich Müller gentoo-dev 2018-01-10 10:44:57 UTC
Created attachment 514072 [details, diff]
files/gnuplot-5.2.2-regis.patch

Patch for package. This adds a --with-regis configure option.
Comment 3 Ulrich Müller gentoo-dev 2018-01-10 10:46:32 UTC
Created attachment 514074 [details, diff]
Patch for gnuplot-5.2.2.ebuild

Patch for ebuild. Please test.
Comment 4 Nikita Zlobin 2018-01-10 18:18:14 UTC
It works).
Tried these examples:
http://gnuplot.sourceforge.net/demo/
Comment 5 Nikita Zlobin 2018-01-10 18:22:36 UTC
It works)
Comment 6 Ulrich Müller gentoo-dev 2018-01-11 22:13:40 UTC
I have submitted a feature request upstream:
https://sourceforge.net/p/gnuplot/feature-requests/472/

If upstream accepts it, we can patch gnuplot-5.2.2 to include the feature.
Comment 7 Ethan Merritt 2018-01-11 23:01:58 UTC
(upstream here)
I've added this to git tip (not yet to branch-5-2-stable)

But I seriously suggest that you would be better off using gnuplot's sixel or dom terminals. Gnuplot's regis code is 20 years old and does not support all the nice features and plot modes added since then.  The sixel and dom terminals are fully up to date.   Any terminal emulator that supports ReGIS almost certainly supports sixel as well.  The dom terminal requires in-terminal svg support, which is a bit more obscure.  See the documentation for pointers on compatible terminal emulators.
Comment 8 Larry the Git Cow gentoo-dev 2018-01-12 08:37:30 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d16bf2294acc3e5d523da4a4c0544ae7a02d4558

commit d16bf2294acc3e5d523da4a4c0544ae7a02d4558
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2018-01-12 08:35:46 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2018-01-12 08:36:57 +0000

    sci-visualization/gnuplot: New regis USE flag to enable ReGIS terminal.
    
    Closes: https://bugs.gentoo.org/643888
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 .../gnuplot/files/gnuplot-5.2.2-regis.patch        | 43 ++++++++++++++++++++++
 sci-visualization/gnuplot/gnuplot-5.2.2.ebuild     |  6 ++-
 sci-visualization/gnuplot/metadata.xml             |  1 +
 3 files changed, 48 insertions(+), 2 deletions(-)
Comment 9 Ulrich Müller gentoo-dev 2018-01-12 08:38:10 UTC
Added to gnuplot-5.2.2, without revision bump.